Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 07/10] iwlwifi: mvm: handle FIF_ALLMULTI when setting multicast addresses
Date: Fri,  8 Sep 2017 12:12:53 +0300	[thread overview]
Message-ID: <20170908091256.25279-8-luca@coelho.fi> (raw)
In-Reply-To: <20170908091256.25279-1-luca@coelho.fi>

From: Luca Coelho <luciano.coelho@intel.com>

We were ignoring the FIF_ALLMULTI flag when setting the multicast
addresses with MCAST_FILTER_CMD.  Check if this flag is set and enable
pass_all accordingly.  We also need to set the count to 0 if pass_all
is enable so we don't pass addresses to the firmware when not needed
(as doing so causes an assert).

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=196741

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 635db63f972e..3bcaa82f59b2 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -1643,6 +1643,12 @@ static void iwl_mvm_configure_filter(struct ieee80211_hw *hw,
 	if (!cmd)
 		goto out;
 
+	if (changed_flags & FIF_ALLMULTI)
+		cmd->pass_all = !!(*total_flags & FIF_ALLMULTI);
+
+	if (cmd->pass_all)
+		cmd->count = 0;
+
 	iwl_mvm_recalc_multicast(mvm);
 out:
 	mutex_unlock(&mvm->mutex);
-- 
2.14.1

  parent reply	other threads:[~2017-09-08  9:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08  9:12 [PATCH 00/10] iwlwifi: fixes intended for 4.14 2017-09-08 Luca Coelho
2017-09-08  9:12 ` [PATCH 01/10] iwlwifi: mvm: fix wowlan resume failed to load INIT ucode Luca Coelho
2017-09-08  9:12 ` [PATCH 02/10] iwlwifi: mvm: Flush non STA TX queues Luca Coelho
2017-09-08  9:12 ` [PATCH 03/10] iwlwifi: mvm: send all non-bufferable frames on the probe queue Luca Coelho
2017-09-08  9:12 ` [PATCH 04/10] iwlwifi: mvm: change state when queueing agg start work Luca Coelho
2017-09-08  9:12 ` [PATCH 05/10] iwlwifi: mvm: wake the correct mac80211 queue Luca Coelho
2017-09-08  9:12 ` [PATCH 06/10] iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD Luca Coelho
2017-09-08  9:12 ` Luca Coelho [this message]
2017-09-08  9:12 ` [PATCH 08/10] iwlwifi: mvm: initialize status in iwl_mvm_add_int_sta_common() Luca Coelho
2017-09-08  9:12 ` [PATCH 09/10] iwlwifi: mvm: set status before calling iwl_mvm_send_cmd_status() Luca Coelho
2017-09-08  9:12 ` [PATCH 10/10] iwlwifi: mvm: fix reorder buffer for 9000 devices Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170908091256.25279-8-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox