From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>
Subject: Re: [PATCH 2/2] qtnfmac: abort scans on wireless interface changes
Date: Mon, 18 Sep 2017 13:31:01 +0300 [thread overview]
Message-ID: <20170918103101.o3u6v6jncsvh6qkn@bars> (raw)
In-Reply-To: <1505730039.13691.3.camel@sipsolutions.net>
> > > > > > - if (timer_pending(&mac->scan_timeout))
> > > > > > - del_timer_sync(&mac->scan_timeout);
>
> > I don't quite understand the question. Do you mean it makes sense to
> > call cfg80211_scan_done first and then cancel timer ?
>
> No, I'm just not sure why you call timer_pending() first.
Well, it looks like before this change it was redundant. But now it makes
sense to avoid deadlock when this function is called from the timer itself.
Regards,
Sergey
next prev parent reply other threads:[~2017-09-18 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 8:04 [PATCH RESEND 0/2] qtnfmac: misc fixes intended for 4.14 Sergey Matyukevich
2017-09-18 8:04 ` [PATCH 1/2] qtnfmac: lock access to h/w in tx path Sergey Matyukevich
2017-09-18 8:04 ` [PATCH 2/2] qtnfmac: abort scans on wireless interface changes Sergey Matyukevich
2017-09-18 8:41 ` Johannes Berg
2017-09-18 9:57 ` Sergey Matyukevich
2017-09-18 10:03 ` Johannes Berg
2017-09-18 10:16 ` Sergey Matyukevich
2017-09-18 10:20 ` Johannes Berg
2017-09-18 10:31 ` Sergey Matyukevich [this message]
2017-09-18 12:51 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2017-09-15 11:52 [PATCH 0/2] qtnfmac: misc fixes intended for 4.14 Sergey Matyukevich
2017-09-15 11:53 ` [PATCH 2/2] qtnfmac: abort scans on wireless interface changes Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918103101.o3u6v6jncsvh6qkn@bars \
--to=sergey.matyukevich.os@quantenna.com \
--cc=avinashp@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox