From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/5] mt76x02: minor beaconing init changes
Date: Fri, 9 Nov 2018 14:59:13 +0100 [thread overview]
Message-ID: <20181109135912.GD9453@localhost.localdomain> (raw)
In-Reply-To: <20181109131608.GB8054@redhat.com>
> On Fri, Nov 09, 2018 at 12:33:32PM +0100, Lorenzo Bianconi wrote:
> > > Disable BEACON timer during init and remove interrupt registers
> > > initalization form generic conde since they are PCIe specific.
> > >
> >
> > Since the timer is actually disabled (MT_INT_TIMER_EN set to 0) and
> > we just set the timer timeout here, does it worth to copy/paste
> > the same code?
>
> As I pointed somwhere else I have some random, not easy to reproduce
> performance drops on MT7610U sta mode, starting when AP mode support
> was added. I'm can not be sure if this is by this setting this
> timer, but I would rather accept slight code duplication, than
> do something that (even with very low probability) can cause
> troubles and for sure is not necessary.
I am fine with this patch but I do not see how original code can cause issues since
MT_INT_TIMER_EN is already set it to 0 (comment mt76_wr(dev, MT_INT_TIMER_EN, 0) out
in the original code)
Regards,
Lorenzo
>
> Thanks
> Stanislaw
next prev parent reply other threads:[~2018-11-09 13:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 10:20 [PATCH 0/5] mt76x02: bssid setup corrections for STA Stanislaw Gruszka
2018-11-09 10:20 ` [PATCH 1/5] mt76x02: correct set bssid " Stanislaw Gruszka
2018-11-09 11:09 ` Lorenzo Bianconi
2018-11-09 11:49 ` Stanislaw Gruszka
2018-11-09 11:52 ` Felix Fietkau
2018-11-09 12:50 ` Lorenzo Bianconi
2018-11-09 13:26 ` Stanislaw Gruszka
2018-11-09 13:42 ` Lorenzo Bianconi
2018-11-09 13:47 ` Felix Fietkau
2018-11-09 10:20 ` [PATCH 2/5] mt76x02: initalize mutli bss mode by default Stanislaw Gruszka
2018-11-09 11:26 ` Lorenzo Bianconi
2018-11-09 13:10 ` Stanislaw Gruszka
2018-11-09 13:31 ` Lorenzo Bianconi
2018-11-09 16:25 ` Stanislaw Gruszka
2018-11-09 16:51 ` Lorenzo Bianconi
2018-11-09 10:20 ` [PATCH 3/5] mt76x2u: use common mt76x02_add_interface Stanislaw Gruszka
2018-11-09 11:18 ` Lorenzo Bianconi
2018-11-09 10:20 ` [PATCH 4/5] mt76x02: minor beaconing init changes Stanislaw Gruszka
2018-11-09 11:33 ` Lorenzo Bianconi
2018-11-09 13:16 ` Stanislaw Gruszka
2018-11-09 13:59 ` Lorenzo Bianconi [this message]
2018-11-09 10:20 ` [PATCH 5/5] mt76x02: remove no longer actual comment Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109135912.GD9453@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox