Re: [PATCH 2/5] mt76x02: initalize mutli bss mode by default

[Lorenzo Bianconi <lorenzo.bianconi@redhat.com>]

> On Fri, Nov 09, 2018 at 02:31:31PM +0100, Lorenzo Bianconi wrote:
> > > 
> > > Anyway I think, to support MAC address change, we should not filter
> > > based on MAC address, but maybe only on BSSID ? 
> > > 
> > > Thanks
> > > Stanislaw
> > 
> > You can create the interface with a given mac address
> > 
> > # iw phy phy0 interface add wlp0s4u1 type managed addr 00:11:22:33:44:55
> 
> I realized I have ancient version of iw :-)
> 
> Ok, so to do not break that we can add it to common function like this:
> 
> +	if (vif->type == NL80211_IFTYPE_STATION) {
> +		if (idx == 0)
> +			mt76x02_mac_init_mbss(dev, vif->addr);
>  		idx += 8;
> +	}
> 
> Thanks
> Stanislaw
>  

Does this patch break AP + STA configuration (since we are changing MT_MAC_ADDR_DW{0,1}
regs with a possible complete different value)? I think (but not 100% sure)
MT_MAC_ADDR_DW is linked to BSSID used.
Maybe it is safer to maintain mt76x2u_add_interface routine since it is just a static
function used in mt76x2u module

Regards,
Lorenzo