* [PATCH] libertas_tf: remove set but not used variable 'flags'
@ 2019-02-13 1:49 YueHaibing
2019-02-14 15:58 ` Steve deRosier
2019-02-19 15:14 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-02-13 1:49 UTC (permalink / raw)
To: Kalle Valo, Colin Ian King
Cc: YueHaibing, linux-wireless, kernel-janitors, netdev
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/marvell/libertas_tf/main.c: In function 'lbtf_rx':
drivers/net/wireless/marvell/libertas_tf/main.c:554:15: warning:
variable 'flags' set but not used [-Wunused-but-set-variable]
It never used and can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/marvell/libertas_tf/main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/libertas_tf/main.c b/drivers/net/wireless/marvell/libertas_tf/main.c
index a7cb7d06e5e6..d36962528838 100644
--- a/drivers/net/wireless/marvell/libertas_tf/main.c
+++ b/drivers/net/wireless/marvell/libertas_tf/main.c
@@ -551,7 +551,6 @@ int lbtf_rx(struct lbtf_private *priv, struct sk_buff *skb)
struct ieee80211_rx_status stats;
struct rxpd *prxpd;
int need_padding;
- unsigned int flags;
struct ieee80211_hdr *hdr;
lbtf_deb_enter(LBTF_DEB_RX);
@@ -572,7 +571,6 @@ int lbtf_rx(struct lbtf_private *priv, struct sk_buff *skb)
skb_pull(skb, sizeof(struct rxpd));
hdr = (struct ieee80211_hdr *)skb->data;
- flags = le32_to_cpu(*(__le32 *)(skb->data + 4));
need_padding = ieee80211_is_data_qos(hdr->frame_control);
need_padding ^= ieee80211_has_a4(hdr->frame_control);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libertas_tf: remove set but not used variable 'flags'
2019-02-13 1:49 [PATCH] libertas_tf: remove set but not used variable 'flags' YueHaibing
@ 2019-02-14 15:58 ` Steve deRosier
2019-02-19 15:14 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Steve deRosier @ 2019-02-14 15:58 UTC (permalink / raw)
To: YueHaibing
Cc: Kalle Valo, Colin Ian King, linux-wireless, kernel-janitors,
Network Development
On Tue, Feb 12, 2019 at 5:35 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/marvell/libertas_tf/main.c: In function 'lbtf_rx':
> drivers/net/wireless/marvell/libertas_tf/main.c:554:15: warning:
> variable 'flags' set but not used [-Wunused-but-set-variable]
>
> It never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Steve deRosier <derosier@cal-sierra.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libertas_tf: remove set but not used variable 'flags'
2019-02-13 1:49 [PATCH] libertas_tf: remove set but not used variable 'flags' YueHaibing
2019-02-14 15:58 ` Steve deRosier
@ 2019-02-19 15:14 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-02-19 15:14 UTC (permalink / raw)
To: YueHaibing
Cc: Colin Ian King, YueHaibing, linux-wireless, kernel-janitors,
netdev
YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/marvell/libertas_tf/main.c: In function 'lbtf_rx':
> drivers/net/wireless/marvell/libertas_tf/main.c:554:15: warning:
> variable 'flags' set but not used [-Wunused-but-set-variable]
>
> It never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Steve deRosier <derosier@cal-sierra.com>
Patch applied to wireless-drivers-next.git, thanks.
e97cb6ea71b0 libertas_tf: remove set but not used variable 'flags'
--
https://patchwork.kernel.org/patch/10808997/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-19 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-13 1:49 [PATCH] libertas_tf: remove set but not used variable 'flags' YueHaibing
2019-02-14 15:58 ` Steve deRosier
2019-02-19 15:14 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox