* [mac80211-next:master 25/27] net/ipv6/ila/ila_xlat.c:420 ila_xlat_nl_cmd_flush() error: uninitialized symbol 'ret'.
@ 2019-02-23 4:27 Dan Carpenter
2019-02-23 5:30 ` [PATCH] ila: Fix uninitialised return value in ila_xlat_nl_cmd_flush Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2019-02-23 4:27 UTC (permalink / raw)
To: kbuild, Herbert Xu; +Cc: kbuild-all, linux-wireless, Johannes Berg
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
head: db0342b20f32f584aedff27c9c09e0a4bbe5beff
commit: 6c4128f658571b2dc7e01058ad09a8e947bc0159 [25/27] rhashtable: Remove obsolete rhashtable_walk_init function
smatch warnings:
net/ipv6/ila/ila_xlat.c:420 ila_xlat_nl_cmd_flush() error: uninitialized symbol 'ret'.
# https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/commit/?id=6c4128f658571b2dc7e01058ad09a8e947bc0159
git remote add mac80211-next https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
git remote update mac80211-next
git checkout 6c4128f658571b2dc7e01058ad09a8e947bc0159
vim +/ret +420 net/ipv6/ila/ila_xlat.c
b6e71bde Tom Herbert 2018-06-27 378
b6e71bde Tom Herbert 2018-06-27 379 int ila_xlat_nl_cmd_flush(struct sk_buff *skb, struct genl_info *info)
b6e71bde Tom Herbert 2018-06-27 380 {
b6e71bde Tom Herbert 2018-06-27 381 struct net *net = genl_info_net(info);
b6e71bde Tom Herbert 2018-06-27 382 struct ila_net *ilan = net_generic(net, ila_net_id);
b6e71bde Tom Herbert 2018-06-27 383 struct rhashtable_iter iter;
b6e71bde Tom Herbert 2018-06-27 384 struct ila_map *ila;
b6e71bde Tom Herbert 2018-06-27 385 spinlock_t *lock;
b6e71bde Tom Herbert 2018-06-27 386 int ret;
b6e71bde Tom Herbert 2018-06-27 387
6c4128f6 Herbert Xu 2019-02-14 388 rhashtable_walk_enter(&ilan->xlat.rhash_table, &iter);
b6e71bde Tom Herbert 2018-06-27 389 rhashtable_walk_start(&iter);
b6e71bde Tom Herbert 2018-06-27 390
b6e71bde Tom Herbert 2018-06-27 391 for (;;) {
b6e71bde Tom Herbert 2018-06-27 392 ila = rhashtable_walk_next(&iter);
b6e71bde Tom Herbert 2018-06-27 393
b6e71bde Tom Herbert 2018-06-27 394 if (IS_ERR(ila)) {
b6e71bde Tom Herbert 2018-06-27 395 if (PTR_ERR(ila) == -EAGAIN)
b6e71bde Tom Herbert 2018-06-27 396 continue;
b6e71bde Tom Herbert 2018-06-27 397 ret = PTR_ERR(ila);
b6e71bde Tom Herbert 2018-06-27 398 goto done;
b6e71bde Tom Herbert 2018-06-27 399 } else if (!ila) {
b6e71bde Tom Herbert 2018-06-27 400 break;
Set "ret" on this error path?
b6e71bde Tom Herbert 2018-06-27 401 }
b6e71bde Tom Herbert 2018-06-27 402
b6e71bde Tom Herbert 2018-06-27 403 lock = lock_from_ila_map(ilan, ila);
b6e71bde Tom Herbert 2018-06-27 404
b6e71bde Tom Herbert 2018-06-27 405 spin_lock(lock);
b6e71bde Tom Herbert 2018-06-27 406
b6e71bde Tom Herbert 2018-06-27 407 ret = rhashtable_remove_fast(&ilan->xlat.rhash_table,
b6e71bde Tom Herbert 2018-06-27 408 &ila->node, rht_params);
b6e71bde Tom Herbert 2018-06-27 409 if (!ret)
b6e71bde Tom Herbert 2018-06-27 410 ila_free_node(ila);
b6e71bde Tom Herbert 2018-06-27 411
b6e71bde Tom Herbert 2018-06-27 412 spin_unlock(lock);
b6e71bde Tom Herbert 2018-06-27 413
b6e71bde Tom Herbert 2018-06-27 414 if (ret)
b6e71bde Tom Herbert 2018-06-27 415 break;
b6e71bde Tom Herbert 2018-06-27 416 }
b6e71bde Tom Herbert 2018-06-27 417
b6e71bde Tom Herbert 2018-06-27 418 done:
b6e71bde Tom Herbert 2018-06-27 419 rhashtable_walk_stop(&iter);
b6e71bde Tom Herbert 2018-06-27 @420 return ret;
b6e71bde Tom Herbert 2018-06-27 421 }
b6e71bde Tom Herbert 2018-06-27 422
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ila: Fix uninitialised return value in ila_xlat_nl_cmd_flush
2019-02-23 4:27 [mac80211-next:master 25/27] net/ipv6/ila/ila_xlat.c:420 ila_xlat_nl_cmd_flush() error: uninitialized symbol 'ret' Dan Carpenter
@ 2019-02-23 5:30 ` Herbert Xu
2019-02-25 5:55 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2019-02-23 5:30 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kbuild, kbuild-all, linux-wireless, Johannes Berg, netdev
On Sat, Feb 23, 2019 at 07:27:47AM +0300, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
> head: db0342b20f32f584aedff27c9c09e0a4bbe5beff
> commit: 6c4128f658571b2dc7e01058ad09a8e947bc0159 [25/27] rhashtable: Remove obsolete rhashtable_walk_init function
>
> smatch warnings:
> net/ipv6/ila/ila_xlat.c:420 ila_xlat_nl_cmd_flush() error: uninitialized symbol 'ret'.
Thanks for catching this.
---8<---
This patch fixes an uninitialised return value error in
ila_xlat_nl_cmd_flush.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 6c4128f65857 ("rhashtable: Remove obsolete...")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/net/ipv6/ila/ila_xlat.c b/net/ipv6/ila/ila_xlat.c
index ae6cd4cef8db..79d2e43c05c5 100644
--- a/net/ipv6/ila/ila_xlat.c
+++ b/net/ipv6/ila/ila_xlat.c
@@ -383,7 +383,7 @@ int ila_xlat_nl_cmd_flush(struct sk_buff *skb, struct genl_info *info)
struct rhashtable_iter iter;
struct ila_map *ila;
spinlock_t *lock;
- int ret;
+ int ret = 0;
rhashtable_walk_enter(&ilan->xlat.rhash_table, &iter);
rhashtable_walk_start(&iter);
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-25 5:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-23 4:27 [mac80211-next:master 25/27] net/ipv6/ila/ila_xlat.c:420 ila_xlat_nl_cmd_flush() error: uninitialized symbol 'ret' Dan Carpenter
2019-02-23 5:30 ` [PATCH] ila: Fix uninitialised return value in ila_xlat_nl_cmd_flush Herbert Xu
2019-02-25 5:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox