Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes.berg@intel.com>,
	Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 10/10] mac80211: extend __rate_control_send_low warning
Date: Wed, 29 May 2019 15:25:37 +0300	[thread overview]
Message-ID: <20190529122537.8564-11-luca@coelho.fi> (raw)
In-Reply-To: <20190529122537.8564-1-luca@coelho.fi>

From: Johannes Berg <johannes.berg@intel.com>

This appears to happen occasionally, and if it does we
really want even more information than we have now.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 net/mac80211/rate.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c
index 5d94576dd683..d298bb222491 100644
--- a/net/mac80211/rate.c
+++ b/net/mac80211/rate.c
@@ -358,8 +358,10 @@ static void __rate_control_send_low(struct ieee80211_hw *hw,
 		break;
 	}
 	WARN_ONCE(i == sband->n_bitrates,
-		  "no supported rates (0x%x) in rate_mask 0x%x with flags 0x%x\n",
+		  "no supported rates for sta %pM (0x%x, band %d) in rate_mask 0x%x with flags 0x%x\n",
+		  sta ? sta->addr : NULL,
 		  sta ? sta->supp_rates[sband->band] : -1,
+		  sband->band,
 		  rate_mask, rate_flags);
 
 	info->control.rates[0].count =
-- 
2.20.1


      parent reply	other threads:[~2019-05-29 12:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 12:25 [PATCH 00/10] cfg80211/mac80211 patches from our internal tree 2019-05-29 Luca Coelho
2019-05-29 12:25 ` [PATCH 01/10] cfg80211: report measurement start TSF correctly Luca Coelho
2019-05-29 12:25 ` [PATCH 02/10] cfg80211: use BIT_ULL in cfg80211_parse_mbssid_data() Luca Coelho
2019-05-29 16:28   ` Kalle Valo
2019-05-29 12:25 ` [PATCH 03/10] mac80211: do not start any work during reconfigure flow Luca Coelho
2019-05-29 12:25 ` [PATCH 04/10] cfg80211: util: fix bit count off by one Luca Coelho
2019-05-29 12:25 ` [PATCH 05/10] cfg80211: Add a function to iterate all BSS entries Luca Coelho
2019-05-29 12:25 ` [PATCH 06/10] ieee80211: Add a missing extended capability flag definition Luca Coelho
2019-05-29 12:25 ` [PATCH 07/10] mac80211: call rate_control_send_low() internally Luca Coelho
2019-05-29 12:25 ` [PATCH 08/10] mac80211: use STA info in rate_control_send_low() Luca Coelho
2019-05-29 12:25 ` [PATCH 09/10] mac80211: fill low rate even for HAS_RATE_CONTROL Luca Coelho
2019-05-29 12:25 ` Luca Coelho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529122537.8564-11-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox