From: Luca Coelho <luca@coelho.fi>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
Luca Coelho <luciano.coelho@intel.com>,
Dan Carpented <dan.carpenter@oracle.com>
Subject: [PATCH 02/10] cfg80211: use BIT_ULL in cfg80211_parse_mbssid_data()
Date: Wed, 29 May 2019 15:25:29 +0300 [thread overview]
Message-ID: <20190529122537.8564-3-luca@coelho.fi> (raw)
In-Reply-To: <20190529122537.8564-1-luca@coelho.fi>
From: Luca Coelho <luciano.coelho@intel.com>
The seen_indices variable is u64 and in other parts of the code we
assume mbssid_index_ie[2] can be up to 45, so we should use the 64-bit
versions of BIT, namely, BIT_ULL().
Reported-by: Dan Carpented <dan.carpenter@oracle.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
net/wireless/scan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index f347387f195a..2ea268ef1c43 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -1602,12 +1602,12 @@ static void cfg80211_parse_mbssid_data(struct wiphy *wiphy,
continue;
}
- if (seen_indices & BIT(mbssid_index_ie[2]))
+ if (seen_indices & BIT_ULL(mbssid_index_ie[2]))
/* We don't support legacy split of a profile */
net_dbg_ratelimited("Partial info for BSSID index %d\n",
mbssid_index_ie[2]);
- seen_indices |= BIT(mbssid_index_ie[2]);
+ seen_indices |= BIT_ULL(mbssid_index_ie[2]);
non_tx_data->bssid_index = mbssid_index_ie[2];
non_tx_data->max_bssid_indicator = elem->data[0];
--
2.20.1
next prev parent reply other threads:[~2019-05-29 12:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 12:25 [PATCH 00/10] cfg80211/mac80211 patches from our internal tree 2019-05-29 Luca Coelho
2019-05-29 12:25 ` [PATCH 01/10] cfg80211: report measurement start TSF correctly Luca Coelho
2019-05-29 12:25 ` Luca Coelho [this message]
2019-05-29 16:28 ` [PATCH 02/10] cfg80211: use BIT_ULL in cfg80211_parse_mbssid_data() Kalle Valo
2019-05-29 12:25 ` [PATCH 03/10] mac80211: do not start any work during reconfigure flow Luca Coelho
2019-05-29 12:25 ` [PATCH 04/10] cfg80211: util: fix bit count off by one Luca Coelho
2019-05-29 12:25 ` [PATCH 05/10] cfg80211: Add a function to iterate all BSS entries Luca Coelho
2019-05-29 12:25 ` [PATCH 06/10] ieee80211: Add a missing extended capability flag definition Luca Coelho
2019-05-29 12:25 ` [PATCH 07/10] mac80211: call rate_control_send_low() internally Luca Coelho
2019-05-29 12:25 ` [PATCH 08/10] mac80211: use STA info in rate_control_send_low() Luca Coelho
2019-05-29 12:25 ` [PATCH 09/10] mac80211: fill low rate even for HAS_RATE_CONTROL Luca Coelho
2019-05-29 12:25 ` [PATCH 10/10] mac80211: extend __rate_control_send_low warning Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529122537.8564-3-luca@coelho.fi \
--to=luca@coelho.fi \
--cc=dan.carpenter@oracle.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox