From: Jiunn Chang <c0d1n61at3@gmail.com>
To: skhan@linuxfoundation.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
johannes@sipsolutions.net
Subject: [Linux-kernel-mentees][PATCH v3] nl80211: Fix undefined behavior in bit shift
Date: Thu, 27 Jun 2019 00:04:26 -0500 [thread overview]
Message-ID: <20190627050426.17925-3-c0d1n61at3@gmail.com> (raw)
In-Reply-To: <20190627032532.18374-4-c0d1n61at3@gmail.com>
Shifting signed 32-bit value by 31 bits is undefined. Changing most
significant bit to unsigned.
Signed-off-by: Jiunn Chang <c0d1n61at3@gmail.com>
---
Changes included in v3:
- remove change log from patch description
Changes included in v2:
- use subsystem specific subject lines
- CC required mailing lists
include/uapi/linux/nl80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index 6f09d1500960..fa7ebbc6ff27 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -5314,7 +5314,7 @@ enum nl80211_feature_flags {
NL80211_FEATURE_TDLS_CHANNEL_SWITCH = 1 << 28,
NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR = 1 << 29,
NL80211_FEATURE_SCHED_SCAN_RANDOM_MAC_ADDR = 1 << 30,
- NL80211_FEATURE_ND_RANDOM_MAC_ADDR = 1 << 31,
+ NL80211_FEATURE_ND_RANDOM_MAC_ADDR = 1U << 31,
};
/**
--
2.22.0
prev parent reply other threads:[~2019-06-27 5:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190627010137.5612-4-c0d1n61at3@gmail.com>
2019-06-27 3:25 ` [Linux-kernel-mentees][PATCH v2] nl80211: Fix undefined behavior in bit shift Jiunn Chang
2019-06-27 3:34 ` Shuah Khan
2019-06-28 13:57 ` Johannes Berg
2019-06-28 15:04 ` Shuah Khan
2019-06-28 15:17 ` Johannes Berg
2019-06-28 15:27 ` Shuah Khan
2019-07-04 18:34 ` Jiunn Chang
2019-07-04 20:20 ` Johannes Berg
2019-06-27 5:04 ` Jiunn Chang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627050426.17925-3-c0d1n61at3@gmail.com \
--to=c0d1n61at3@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox