From: Dan Carpenter <dan.carpenter@oracle.com>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: vt6656: fix sign of rx_dbm to bb_pre_ed_rssi.
Date: Mon, 3 Feb 2020 12:42:22 +0300 [thread overview]
Message-ID: <20200203094222.GM1778@kadam> (raw)
In-Reply-To: <9b3b92d6-3672-00be-d0b5-ccd222236ba9@gmail.com>
On Sun, Feb 02, 2020 at 12:27:25PM +0000, Malcolm Priestley wrote:
> bb_pre_ed_rssi is an u8 rx_dm always returns negative signed
> values add minus operator to always yield positive.
>
> fixes issue where rx sensitivity is always set to maximum because
> the unsigned numbers were always greater then 100.
>
> Cc: stable <stable@vger.kernel.org>
Can you add a Fixes tag for stable kernels?
Fixes: 63b9907f58f1 ("staging: vt6656: mac80211 conversion: create rx function.")
Otherwise we don't backport it far enough and then it becomes an
actively exploited Android vulnerability and Google writes an article
about it. Then everyone gets annoyed with us and shakes their head
because OpenBSD never has Android vulnerabilities etc...
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
> drivers/staging/vt6656/dpc.c | 2 +-
It appears that the vt6655 driver has the same issue.
regards,
dan carpenter
next prev parent reply other threads:[~2020-02-03 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 12:27 [PATCH 1/2] staging: vt6656: fix sign of rx_dbm to bb_pre_ed_rssi Malcolm Priestley
2020-02-03 9:42 ` Dan Carpenter [this message]
2020-02-04 19:34 ` [PATCH v2 " Malcolm Priestley
2020-02-04 19:50 ` [PATCH " Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203094222.GM1778@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox