From: Malcolm Priestley <tvboxspy@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: vt6656: fix sign of rx_dbm to bb_pre_ed_rssi.
Date: Tue, 4 Feb 2020 19:50:18 +0000 [thread overview]
Message-ID: <bd20e945-f393-1080-502a-4a92d621cea3@gmail.com> (raw)
In-Reply-To: <20200203094222.GM1778@kadam>
On 03/02/2020 09:42, Dan Carpenter wrote:
> On Sun, Feb 02, 2020 at 12:27:25PM +0000, Malcolm Priestley wrote:
>> bb_pre_ed_rssi is an u8 rx_dm always returns negative signed
>> values add minus operator to always yield positive.
>>
>> fixes issue where rx sensitivity is always set to maximum because
>> the unsigned numbers were always greater then 100.
>>
>> Cc: stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
>> ---
...
>> drivers/staging/vt6656/dpc.c | 2 +-
>
> It appears that the vt6655 driver has the same issue.
In the vt6655 it is not used.
Regards
Malcolm
prev parent reply other threads:[~2020-02-04 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 12:27 [PATCH 1/2] staging: vt6656: fix sign of rx_dbm to bb_pre_ed_rssi Malcolm Priestley
2020-02-03 9:42 ` Dan Carpenter
2020-02-04 19:34 ` [PATCH v2 " Malcolm Priestley
2020-02-04 19:50 ` Malcolm Priestley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd20e945-f393-1080-502a-4a92d621cea3@gmail.com \
--to=tvboxspy@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox