Linux wireless drivers development
 help / color / mirror / Atom feed
From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] cfg80211: skip strict validation for UDPATE_OWE command
Date: Thu, 13 Feb 2020 11:21:28 +0000	[thread overview]
Message-ID: <20200213112123.elwoei3nnk5mzkht@bars> (raw)
In-Reply-To: <47ba092892a3762f42cac6f69a80622829e84827.camel@sipsolutions.net>

> On Thu, 2020-02-13 at 11:13 +0000, Sergey Matyukevich wrote:
> > On Thu, Feb 13, 2020 at 10:12:47AM +0100, Johannes Berg wrote:
> > > [External Email]: This email arrived from an external source - Please exercise caution when opening any attachments or clicking on links.
> > > 
> > > On Thu, 2020-02-13 at 09:07 +0000, Sergey Matyukevich wrote:
> > > > Do not perform strict validation of UPDATE_OWE command.
> > > > Otherwise, kernel rejects command executed by hostapd.
> > > 
> > > Can't we fix hostapd? I mean, it's a relatively new command, so why
> > > shouldn't we validate it strictly?
> > 
> > That is why this patch is RFC: see cover email :)
> 
> Ah, was on the phone and hadn't read that yet ...
> 
> > Sure, I can fix hostapd instead. Could you point me at some good
> > starting point to look at ? Are there any user-space tools that
> > started to use strict validation ?
> 
> It's not really opt-in or not, it's entirely a kernel choice.

I mean, I don't know what userspace is supposed to do in the case,
when kernel is doing strict validation. So I was asking about any
pointers to docs or userspace tools that already do netlink
machinery appropriately.

> > P.S.
> > If you are ok with the second patch, then could you just take it
> > from this series ? Or should I resubmit ?
> 
> I can just take it.

Ok

Regards,
Sergey

  reply	other threads:[~2020-02-13 11:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  9:07 [RFC PATCH 0/2] cfg80211: minor updates for WPA3 OWE support Sergey Matyukevich
2020-02-13  9:07 ` [RFC PATCH 1/2] cfg80211: skip strict validation for UDPATE_OWE command Sergey Matyukevich
2020-02-13  9:12   ` Johannes Berg
2020-02-13 11:13     ` Sergey Matyukevich
2020-02-13 11:16       ` Johannes Berg
2020-02-13 11:21         ` Sergey Matyukevich [this message]
2020-02-13 11:26           ` Johannes Berg
2020-02-13 11:43             ` Sergey Matyukevich
2020-02-13 12:10               ` Johannes Berg
2020-02-13  9:07 ` [RFC PATCH 2/2] ieee80211: add WPA3 OWE AKM suite selector Sergey Matyukevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213112123.elwoei3nnk5mzkht@bars \
    --to=sergey.matyukevich.os@quantenna.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox