From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] cfg80211: skip strict validation for UDPATE_OWE command
Date: Thu, 13 Feb 2020 11:43:33 +0000 [thread overview]
Message-ID: <20200213114327.434cnjstf235av4y@bars> (raw)
In-Reply-To: <98f7590498a7173e933f70c85208735a13f51792.camel@sipsolutions.net>
> On Thu, 2020-02-13 at 11:21 +0000, Sergey Matyukevich wrote:
> > >
> > > > Sure, I can fix hostapd instead. Could you point me at some good
> > > > starting point to look at ? Are there any user-space tools that
> > > > started to use strict validation ?
> > >
> > > It's not really opt-in or not, it's entirely a kernel choice.
> >
> > I mean, I don't know what userspace is supposed to do in the case,
> > when kernel is doing strict validation. So I was asking about any
> > pointers to docs or userspace tools that already do netlink
> > machinery appropriately.
>
> Userspace is just supposed to create well-formed messages :-)
>
> But ... it really is a kernel bug. The nl80211_policy is missing an
> entry for NL80211_ATTR_STATUS_CODE, so for *strict* commands, it's
> assumed to not be supported. Need to add something like
>
> [NL80211_ATTR_STATUS_CODE] = { .type = NLA_U16, },
>
> to the nl80211_policy, or perhaps with a range indicating that 0 isn't
> valid or something.
Great. Thanks for explanation. Would you mind if I send a fix ?
Or now you have your own plans for this ?
Regards,
Sergey
next prev parent reply other threads:[~2020-02-13 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 9:07 [RFC PATCH 0/2] cfg80211: minor updates for WPA3 OWE support Sergey Matyukevich
2020-02-13 9:07 ` [RFC PATCH 1/2] cfg80211: skip strict validation for UDPATE_OWE command Sergey Matyukevich
2020-02-13 9:12 ` Johannes Berg
2020-02-13 11:13 ` Sergey Matyukevich
2020-02-13 11:16 ` Johannes Berg
2020-02-13 11:21 ` Sergey Matyukevich
2020-02-13 11:26 ` Johannes Berg
2020-02-13 11:43 ` Sergey Matyukevich [this message]
2020-02-13 12:10 ` Johannes Berg
2020-02-13 9:07 ` [RFC PATCH 2/2] ieee80211: add WPA3 OWE AKM suite selector Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213114327.434cnjstf235av4y@bars \
--to=sergey.matyukevich.os@quantenna.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox