From: "Pali Rohár" <pali@kernel.org>
To: Ajay.Kathat@microchip.com
Cc: linux-wireless@vger.kernel.org, Claudiu.Beznea@microchip.com,
Sripad.Balwadgi@microchip.com, ulf.hansson@linaro.org
Subject: Re: [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file
Date: Mon, 20 Jul 2020 09:31:45 +0200 [thread overview]
Message-ID: <20200720073145.3poujatb562cyoig@pali> (raw)
In-Reply-To: <20200717051134.19160-1-ajay.kathat@microchip.com>
On Friday 17 July 2020 05:11:38 Ajay.Kathat@microchip.com wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
>
> Moved macros used for Vendor/Device ID from wilc1000 driver to common
> header file and changed macro name for consistency with other macros.
>
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Acked-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/net/wireless/microchip/wilc1000/sdio.c | 6 ++----
> include/linux/mmc/sdio_ids.h | 3 +++
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
> index 36eb589263bf..3ece7b0b0392 100644
> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
> @@ -6,6 +6,7 @@
>
> #include <linux/clk.h>
> #include <linux/mmc/sdio_func.h>
> +#include <linux/mmc/sdio_ids.h>
> #include <linux/mmc/host.h>
> #include <linux/mmc/sdio.h>
> #include <linux/of_irq.h>
> @@ -15,11 +16,8 @@
>
> #define SDIO_MODALIAS "wilc1000_sdio"
>
> -#define SDIO_VENDOR_ID_WILC 0x0296
> -#define SDIO_DEVICE_ID_WILC 0x5347
> -
> static const struct sdio_device_id wilc_sdio_ids[] = {
> - { SDIO_DEVICE(SDIO_VENDOR_ID_WILC, SDIO_DEVICE_ID_WILC) },
> + { SDIO_DEVICE(SDIO_VENDOR_ID_MICROCHIP_WILC, SDIO_DEVICE_ID_MICROCHIP_WILC1000) },
> { },
> };
>
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index 15ed8ce9d394..519820d18e62 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -105,6 +105,9 @@
> #define SDIO_DEVICE_ID_MEDIATEK_MT7663 0x7663
> #define SDIO_DEVICE_ID_MEDIATEK_MT7668 0x7668
>
> +#define SDIO_VENDOR_ID_MICROCHIP_WILC 0x0296
> +#define SDIO_DEVICE_ID_MICROCHIP_WILC1000 0x5347
> +
> #define SDIO_VENDOR_ID_SIANO 0x039a
> #define SDIO_DEVICE_ID_SIANO_NOVA_B0 0x0201
> #define SDIO_DEVICE_ID_SIANO_NICE 0x0202
> --
> 2.24.0
next prev parent reply other threads:[~2020-07-20 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 5:11 [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file Ajay.Kathat
2020-07-18 9:28 ` Ulf Hansson
2020-07-20 9:49 ` Kalle Valo
2020-07-20 7:31 ` Pali Rohár [this message]
2020-08-02 15:12 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720073145.3poujatb562cyoig@pali \
--to=pali@kernel.org \
--cc=Ajay.Kathat@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Sripad.Balwadgi@microchip.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox