* [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file
@ 2020-07-17 5:11 Ajay.Kathat
2020-07-18 9:28 ` Ulf Hansson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ajay.Kathat @ 2020-07-17 5:11 UTC (permalink / raw)
To: linux-wireless
Cc: Claudiu.Beznea, Sripad.Balwadgi, ulf.hansson, pali, Ajay.Kathat
From: Ajay Singh <ajay.kathat@microchip.com>
Moved macros used for Vendor/Device ID from wilc1000 driver to common
header file and changed macro name for consistency with other macros.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
drivers/net/wireless/microchip/wilc1000/sdio.c | 6 ++----
include/linux/mmc/sdio_ids.h | 3 +++
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
index 36eb589263bf..3ece7b0b0392 100644
--- a/drivers/net/wireless/microchip/wilc1000/sdio.c
+++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
@@ -6,6 +6,7 @@
#include <linux/clk.h>
#include <linux/mmc/sdio_func.h>
+#include <linux/mmc/sdio_ids.h>
#include <linux/mmc/host.h>
#include <linux/mmc/sdio.h>
#include <linux/of_irq.h>
@@ -15,11 +16,8 @@
#define SDIO_MODALIAS "wilc1000_sdio"
-#define SDIO_VENDOR_ID_WILC 0x0296
-#define SDIO_DEVICE_ID_WILC 0x5347
-
static const struct sdio_device_id wilc_sdio_ids[] = {
- { SDIO_DEVICE(SDIO_VENDOR_ID_WILC, SDIO_DEVICE_ID_WILC) },
+ { SDIO_DEVICE(SDIO_VENDOR_ID_MICROCHIP_WILC, SDIO_DEVICE_ID_MICROCHIP_WILC1000) },
{ },
};
diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
index 15ed8ce9d394..519820d18e62 100644
--- a/include/linux/mmc/sdio_ids.h
+++ b/include/linux/mmc/sdio_ids.h
@@ -105,6 +105,9 @@
#define SDIO_DEVICE_ID_MEDIATEK_MT7663 0x7663
#define SDIO_DEVICE_ID_MEDIATEK_MT7668 0x7668
+#define SDIO_VENDOR_ID_MICROCHIP_WILC 0x0296
+#define SDIO_DEVICE_ID_MICROCHIP_WILC1000 0x5347
+
#define SDIO_VENDOR_ID_SIANO 0x039a
#define SDIO_DEVICE_ID_SIANO_NOVA_B0 0x0201
#define SDIO_DEVICE_ID_SIANO_NICE 0x0202
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file
2020-07-17 5:11 [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file Ajay.Kathat
@ 2020-07-18 9:28 ` Ulf Hansson
2020-07-20 9:49 ` Kalle Valo
2020-07-20 7:31 ` Pali Rohár
2020-08-02 15:12 ` Kalle Valo
2 siblings, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2020-07-18 9:28 UTC (permalink / raw)
To: Ajay.Kathat
Cc: linux-wireless, Claudiu.Beznea, Sripad.Balwadgi, Pali Rohár
On Fri, 17 Jul 2020 at 07:11, <Ajay.Kathat@microchip.com> wrote:
>
> From: Ajay Singh <ajay.kathat@microchip.com>
>
> Moved macros used for Vendor/Device ID from wilc1000 driver to common
> header file and changed macro name for consistency with other macros.
>
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/net/wireless/microchip/wilc1000/sdio.c | 6 ++----
> include/linux/mmc/sdio_ids.h | 3 +++
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
> index 36eb589263bf..3ece7b0b0392 100644
> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
> @@ -6,6 +6,7 @@
>
> #include <linux/clk.h>
> #include <linux/mmc/sdio_func.h>
> +#include <linux/mmc/sdio_ids.h>
> #include <linux/mmc/host.h>
> #include <linux/mmc/sdio.h>
> #include <linux/of_irq.h>
> @@ -15,11 +16,8 @@
>
> #define SDIO_MODALIAS "wilc1000_sdio"
>
> -#define SDIO_VENDOR_ID_WILC 0x0296
> -#define SDIO_DEVICE_ID_WILC 0x5347
> -
> static const struct sdio_device_id wilc_sdio_ids[] = {
> - { SDIO_DEVICE(SDIO_VENDOR_ID_WILC, SDIO_DEVICE_ID_WILC) },
> + { SDIO_DEVICE(SDIO_VENDOR_ID_MICROCHIP_WILC, SDIO_DEVICE_ID_MICROCHIP_WILC1000) },
> { },
> };
>
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index 15ed8ce9d394..519820d18e62 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -105,6 +105,9 @@
> #define SDIO_DEVICE_ID_MEDIATEK_MT7663 0x7663
> #define SDIO_DEVICE_ID_MEDIATEK_MT7668 0x7668
>
> +#define SDIO_VENDOR_ID_MICROCHIP_WILC 0x0296
> +#define SDIO_DEVICE_ID_MICROCHIP_WILC1000 0x5347
> +
> #define SDIO_VENDOR_ID_SIANO 0x039a
> #define SDIO_DEVICE_ID_SIANO_NOVA_B0 0x0201
> #define SDIO_DEVICE_ID_SIANO_NICE 0x0202
> --
> 2.24.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file
2020-07-18 9:28 ` Ulf Hansson
@ 2020-07-20 9:49 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2020-07-20 9:49 UTC (permalink / raw)
To: Ulf Hansson
Cc: Ajay.Kathat, linux-wireless, Claudiu.Beznea, Sripad.Balwadgi,
Pali Rohár
Ulf Hansson <ulf.hansson@linaro.org> writes:
> On Fri, 17 Jul 2020 at 07:11, <Ajay.Kathat@microchip.com> wrote:
>>
>> From: Ajay Singh <ajay.kathat@microchip.com>
>>
>> Moved macros used for Vendor/Device ID from wilc1000 driver to common
>> header file and changed macro name for consistency with other macros.
>>
>> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Just so that I have understood correctly, so the plan is to take this
via wireless-drivers-next?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file
2020-07-17 5:11 [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file Ajay.Kathat
2020-07-18 9:28 ` Ulf Hansson
@ 2020-07-20 7:31 ` Pali Rohár
2020-08-02 15:12 ` Kalle Valo
2 siblings, 0 replies; 5+ messages in thread
From: Pali Rohár @ 2020-07-20 7:31 UTC (permalink / raw)
To: Ajay.Kathat; +Cc: linux-wireless, Claudiu.Beznea, Sripad.Balwadgi, ulf.hansson
On Friday 17 July 2020 05:11:38 Ajay.Kathat@microchip.com wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
>
> Moved macros used for Vendor/Device ID from wilc1000 driver to common
> header file and changed macro name for consistency with other macros.
>
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Acked-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/net/wireless/microchip/wilc1000/sdio.c | 6 ++----
> include/linux/mmc/sdio_ids.h | 3 +++
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
> index 36eb589263bf..3ece7b0b0392 100644
> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
> @@ -6,6 +6,7 @@
>
> #include <linux/clk.h>
> #include <linux/mmc/sdio_func.h>
> +#include <linux/mmc/sdio_ids.h>
> #include <linux/mmc/host.h>
> #include <linux/mmc/sdio.h>
> #include <linux/of_irq.h>
> @@ -15,11 +16,8 @@
>
> #define SDIO_MODALIAS "wilc1000_sdio"
>
> -#define SDIO_VENDOR_ID_WILC 0x0296
> -#define SDIO_DEVICE_ID_WILC 0x5347
> -
> static const struct sdio_device_id wilc_sdio_ids[] = {
> - { SDIO_DEVICE(SDIO_VENDOR_ID_WILC, SDIO_DEVICE_ID_WILC) },
> + { SDIO_DEVICE(SDIO_VENDOR_ID_MICROCHIP_WILC, SDIO_DEVICE_ID_MICROCHIP_WILC1000) },
> { },
> };
>
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index 15ed8ce9d394..519820d18e62 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -105,6 +105,9 @@
> #define SDIO_DEVICE_ID_MEDIATEK_MT7663 0x7663
> #define SDIO_DEVICE_ID_MEDIATEK_MT7668 0x7668
>
> +#define SDIO_VENDOR_ID_MICROCHIP_WILC 0x0296
> +#define SDIO_DEVICE_ID_MICROCHIP_WILC1000 0x5347
> +
> #define SDIO_VENDOR_ID_SIANO 0x039a
> #define SDIO_DEVICE_ID_SIANO_NOVA_B0 0x0201
> #define SDIO_DEVICE_ID_SIANO_NICE 0x0202
> --
> 2.24.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file
2020-07-17 5:11 [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file Ajay.Kathat
2020-07-18 9:28 ` Ulf Hansson
2020-07-20 7:31 ` Pali Rohár
@ 2020-08-02 15:12 ` Kalle Valo
2 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2020-08-02 15:12 UTC (permalink / raw)
To: Ajay.Kathat
Cc: linux-wireless, Claudiu.Beznea, Sripad.Balwadgi, ulf.hansson,
pali, Ajay.Kathat
<Ajay.Kathat@microchip.com> wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
>
> Moved macros used for Vendor/Device ID from wilc1000 driver to common
> header file and changed macro name for consistency with other macros.
>
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
> Acked-by: Pali Rohár <pali@kernel.org>
Patch applied to wireless-drivers-next.git, thanks.
c83e2a6e2fbb wilc1000: Move wilc1000 SDIO ID's from driver source to common header file
--
https://patchwork.kernel.org/patch/11668967/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-02 15:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-17 5:11 [PATCH] wilc1000: Move wilc1000 SDIO ID's from driver source to common header file Ajay.Kathat
2020-07-18 9:28 ` Ulf Hansson
2020-07-20 9:49 ` Kalle Valo
2020-07-20 7:31 ` Pali Rohár
2020-08-02 15:12 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox