From: Felix Fietkau <nbd@nbd.name>
To: linux-wireless@vger.kernel.org
Subject: [PATCH 7/8] mt76: mt7915: fix processing txfree events
Date: Sun, 27 Sep 2020 19:18:51 +0200 [thread overview]
Message-ID: <20200927171852.48669-7-nbd@nbd.name> (raw)
In-Reply-To: <20200927171852.48669-1-nbd@nbd.name>
In the MT7915 info, the fields for the WLAN index / queue overlap with the
token id, and the MT_TX_FREE_PAIR bit indicates, which one is present.
If MT_TX_FREE_PAIR is set, skip processing the token index, since the data
will not be valid.
This fixes accidentally freeing tokens which are still in use by the
hardware with a wrong station pointer.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
index 44a5b4f8e43c..3456d9532f29 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
@@ -972,6 +972,7 @@ void mt7915_mac_tx_free(struct mt7915_dev *dev, struct sk_buff *skb)
if (list_empty(&msta->poll_list))
list_add_tail(&msta->poll_list, &dev->sta_poll_list);
spin_unlock_bh(&dev->sta_poll_lock);
+ continue;
}
msdu = FIELD_GET(MT_TX_FREE_MSDU_ID, info);
--
2.28.0
next prev parent reply other threads:[~2020-09-27 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 17:18 [PATCH 1/8] mt76: mt7915: add 802.11 encap offload support Felix Fietkau
2020-09-27 17:18 ` [PATCH 2/8] mt76: mt7915: add encap offload for 4-address mode stations Felix Fietkau
2020-09-27 17:18 ` [PATCH 3/8] mt76: use ieee80211_rx_list to pass frames to the network stack as a batch Felix Fietkau
2020-09-27 17:18 ` [PATCH 4/8] mt76: mt7615: add debugfs knob for setting extended local mac addresses Felix Fietkau
2020-09-27 17:18 ` [PATCH 5/8] mt76: do not set NEEDS_UNIQUE_STA_ADDR for 7615 and 7915 Felix Fietkau
2020-09-27 17:18 ` [PATCH 6/8] mt76: mt7915: support 32 station interfaces Felix Fietkau
2020-09-27 17:18 ` Felix Fietkau [this message]
2020-09-27 17:18 ` [PATCH 8/8] mt76: mt7915: use napi_consume_skb to bulk-free tx skbs Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927171852.48669-7-nbd@nbd.name \
--to=nbd@nbd.name \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox