[PATCH] ath6kl: wmi: fix an error code in ath6kl_wmi_sync_point()

[PATCH] ath6kl: wmi: fix an error code in ath6kl_wmi_sync_point()

[Dan Carpenter]

This error path is unlikely because of it checked for NULL and
returned -ENOMEM earlier in the function.  But it should return
an error code here as well if we ever do hit it because of a
race condition or something.

Fixes: bdcd81707973 ("Add ath6kl cleaned up driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/wireless/ath/ath6kl/wmi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c
index b137e7f34397..bd1ef6334997 100644
--- a/drivers/net/wireless/ath/ath6kl/wmi.c
+++ b/drivers/net/wireless/ath/ath6kl/wmi.c
@@ -2504,8 +2504,10 @@ static int ath6kl_wmi_sync_point(struct wmi *wmi, u8 if_idx)
 		goto free_data_skb;
 
 	for (index = 0; index < num_pri_streams; index++) {
-		if (WARN_ON(!data_sync_bufs[index].skb))
+		if (WARN_ON(!data_sync_bufs[index].skb)) {
+			ret = -ENOMEM;
 			goto free_data_skb;
+		}
 
 		ep_id = ath6kl_ac2_endpoint_id(wmi->parent_dev,
 					       data_sync_bufs[index].
-- 
2.20.1

Re: [PATCH] ath6kl: wmi: fix an error code in ath6kl_wmi_sync_point()

[Kalle Valo]

Dan Carpenter <dan.carpenter@oracle.com> wrote:

> This error path is unlikely because of it checked for NULL and
> returned -ENOMEM earlier in the function.  But it should return
> an error code here as well if we ever do hit it because of a
> race condition or something.
> 
> Fixes: bdcd81707973 ("Add ath6kl cleaned up driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

fd6729ec534c ath6kl: wmi: fix an error code in ath6kl_wmi_sync_point()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210813113438.GB30697@kili/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches