From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kalle Valo <kvalo@kernel.org>,
Linux Wireless <linux-wireless@vger.kernel.org>,
Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>,
Gregory Greenman <gregory.greenman@intel.com>,
Linux Regressions <regressions@lists.linux.dev>,
Johannes Berg <johannes@sipsolutions.net>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: [PATCH] wifi: iwlwifi: fix system commands group ordering
Date: Sun, 12 Nov 2023 11:59:43 +0200 [thread overview]
Message-ID: <20231112095943.19353-1-emmanuel.grumbach@intel.com> (raw)
From: Miri Korenblit <miriam.rachel.korenblit@intel.com>
The commands should be sorted inside the group definition.
Fix the ordering so we won't get following warning:
WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg))
Fixes: b6e3d1ba4fcf ("wifi: iwlwifi: mvm: implement new firmware API for statistics")
Change-Id: I0112bd7da4559a8e69e84cd8f55ba8e6fe8252cb
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
index fef86a8b4163..1627b2f819db 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
@@ -550,9 +550,9 @@ static const struct iwl_hcmd_names iwl_mvm_system_names[] = {
HCMD_NAME(RFI_CONFIG_CMD),
HCMD_NAME(RFI_GET_FREQ_TABLE_CMD),
HCMD_NAME(SYSTEM_FEATURES_CONTROL_CMD),
- HCMD_NAME(RFI_DEACTIVATE_NOTIF),
HCMD_NAME(SYSTEM_STATISTICS_CMD),
HCMD_NAME(SYSTEM_STATISTICS_END_NOTIF),
+ HCMD_NAME(RFI_DEACTIVATE_NOTIF),
};
/* Please keep this array *SORTED* by hex value.
--
2.41.0
next reply other threads:[~2023-11-12 9:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 9:59 Emmanuel Grumbach [this message]
2023-11-12 10:05 ` [PATCH v2] wifi: iwlwifi: fix system commands group ordering Emmanuel Grumbach
2023-11-12 10:09 ` [PATCH v3] " Emmanuel Grumbach
2023-11-12 14:08 ` Bagas Sanjaya
2023-11-12 14:36 ` [PATCH v4] " Emmanuel Grumbach
2023-11-12 18:54 ` Kalle Valo
2023-11-12 19:39 ` Linus Torvalds
2023-11-12 19:53 ` Emmanuel Grumbach
2023-11-12 20:01 ` Emmanuel Grumbach
2023-11-13 16:10 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231112095943.19353-1-emmanuel.grumbach@intel.com \
--to=emmanuel.grumbach@intel.com \
--cc=bagasdotme@gmail.com \
--cc=gregory.greenman@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=pagadala.yesu.anjaneyulu@intel.com \
--cc=regressions@lists.linux.dev \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox