From: Kalle Valo <kvalo@kernel.org>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Linux Wireless" <linux-wireless@vger.kernel.org>,
pagadala.yesu.anjaneyulu@intel.com, gregory.greenman@intel.com,
"Linux Regressions" <regressions@lists.linux.dev>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Miri Korenblit" <miriam.rachel.korenblit@intel.com>,
"Niklāvs Koļesņikovs" <pinkflames.linux@gmail.com>,
"Damian Tometzki" <damian@riscv-rocks.de>
Subject: Re: [PATCH v4] wifi: iwlwifi: fix system commands group ordering
Date: Sun, 12 Nov 2023 20:54:27 +0200 [thread overview]
Message-ID: <875y26ajks.fsf@kernel.org> (raw)
In-Reply-To: <20231112143620.36619-1-emmanuel.grumbach@intel.com> (Emmanuel Grumbach's message of "Sun, 12 Nov 2023 16:36:20 +0200")
Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:
> From: Miri Korenblit <miriam.rachel.korenblit@intel.com>
>
> The commands should be sorted inside the group definition.
> Fix the ordering so we won't get following warning:
> WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg))
>
> Link: https://lore.kernel.org/regressions/2fa930bb-54dd-4942-a88d-05a47c8e9731@gmail.com/
> Link: https://lore.kernel.org/linux-wireless/CAHk-=wix6kqQ5vHZXjOPpZBfM7mMm9bBZxi2Jh7XnaKCqVf94w@mail.gmail.com/
> Fixes: b6e3d1ba4fcf ("wifi: iwlwifi: mvm: implement new firmware API for statistics")
> Tested-by: Niklāvs Koļesņikovs <pinkflames.linux@gmail.com>
> Tested-by: Damian Tometzki <damian@riscv-rocks.de>
> Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Linus, I suspect it will take a while before we make a new wireless pull
request (there's currently just one commit in the wireless tree). So if
you want to take this directly to your tree please go ahead, otherwise
you get it via the normal route in a week or two. Just let us know what
you prefer.
Acked-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-11-12 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 9:59 [PATCH] wifi: iwlwifi: fix system commands group ordering Emmanuel Grumbach
2023-11-12 10:05 ` [PATCH v2] " Emmanuel Grumbach
2023-11-12 10:09 ` [PATCH v3] " Emmanuel Grumbach
2023-11-12 14:08 ` Bagas Sanjaya
2023-11-12 14:36 ` [PATCH v4] " Emmanuel Grumbach
2023-11-12 18:54 ` Kalle Valo [this message]
2023-11-12 19:39 ` Linus Torvalds
2023-11-12 19:53 ` Emmanuel Grumbach
2023-11-12 20:01 ` Emmanuel Grumbach
2023-11-13 16:10 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y26ajks.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=damian@riscv-rocks.de \
--cc=emmanuel.grumbach@intel.com \
--cc=gregory.greenman@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=pagadala.yesu.anjaneyulu@intel.com \
--cc=pinkflames.linux@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox