Re: [PATCH v2 6/6] wifi: rtw89: 8852bt: add 8852BE-VT to Makefile and Kconfig

[kernel test robot <lkp@intel.com>]

Hi Ping-Ke,

kernel test robot noticed the following build warnings:

[auto build test WARNING on wireless-next/main]
[also build test WARNING on linus/master next-20240719]
[cannot apply to wireless/main v6.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ping-Ke-Shih/wifi-rtw89-8852bt-add-set_channel_rf/20240719-161236
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20240719062414.21953-7-pkshih%40realtek.com
patch subject: [PATCH v2 6/6] wifi: rtw89: 8852bt: add 8852BE-VT to Makefile and Kconfig
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240720/202407200741.dMG9uvHU-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240720/202407200741.dMG9uvHU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407200741.dMG9uvHU-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: warning: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses]
    1827 |                     kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
         |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
   drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: note: place parentheses around the '&' expression to silence this warning
    1827 |                     kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
         |                                                            ^
         |                           (                               )
   drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: note: place parentheses around the '?:' expression to evaluate it first
    1827 |                     kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
         |                                                            ^                     
         |                                                (                                 )
   1 warning generated.


vim +1827 drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c

f77c5179bc9f6f Ping-Ke Shih 2024-06-27  1807  
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1808  static void _dpk_onoff(struct rtw89_dev *rtwdev, enum rtw89_rf_path path, bool off)
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1809  {
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1810  	struct rtw89_dpk_info *dpk = &rtwdev->dpk;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1811  	u8 val, kidx = dpk->cur_idx[path];
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1812  	bool off_reverse;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1813  
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1814  	val = dpk->is_dpk_enable && !off && dpk->bp[path][kidx].path_ok;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1815  
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1816  	if (off)
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1817  		off_reverse = false;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1818  	else
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1819  		off_reverse = true;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1820  
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1821  	val = dpk->is_dpk_enable & off_reverse & dpk->bp[path][kidx].path_ok;
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1822  
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1823  	rtw89_phy_write32_mask(rtwdev, R_DPD_CH0A + (path << 8) + (kidx << 2),
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1824  			       BIT(24), val);
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1825  
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1826  	rtw89_debug(rtwdev, RTW89_DBG_RFK, "[DPK] S%d[%d] DPK %s !!!\n", path,
5b8c61b82eec9e Ping-Ke Shih 2024-06-21 @1827  		    kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1828  }
5b8c61b82eec9e Ping-Ke Shih 2024-06-21  1829  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki