From: Ping-Ke Shih <pkshih@realtek.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"lkp@intel.com" <lkp@intel.com>
Cc: "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>
Subject: Re: [PATCH v2 6/6] wifi: rtw89: 8852bt: add 8852BE-VT to Makefile and Kconfig
Date: Sat, 20 Jul 2024 02:05:37 +0000 [thread overview]
Message-ID: <e53f0d0a67442642be823081ca6cab49ff122cc4.camel@realtek.com> (raw)
In-Reply-To: <202407200741.dMG9uvHU-lkp@intel.com>
On Sat, 2024-07-20 at 08:09 +0800, kernel test robot wrote:
>
> > > drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: warning: operator '?:' has lower
> > > precedence than '&'; '&' will be evaluated first [-Wbitwise-conditional-parentheses]
> 1827 | kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
> drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: note: place parentheses around the
> '&' expression to silence this warning
> 1827 | kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
> | ^
> | ( )
> drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c:1827:46: note: place parentheses around the
> '?:' expression to evaluate it first
> 1827 | kidx, dpk->is_dpk_enable & off_reverse ? "enable" : "disable");
> | ^
> | ( )
> 1 warning generated.
In v3, I will correct this by 'str_enable_disable(dpk->is_dpk_enable & off_reverse)'
with a new patch.
prev parent reply other threads:[~2024-07-20 2:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 6:24 [PATCH v2 0/6] wifi: rtw89: 8852bt: enable 8852BE-VT Ping-Ke Shih
2024-07-19 6:24 ` [PATCH v2 1/6] wifi: rtw89: 8852bt: add set_channel_rf Ping-Ke Shih
2024-07-19 6:24 ` [PATCH v2 2/6] wifi: rtw89: 8852bt: add chip_info of RTL8852BT Ping-Ke Shih
2024-07-19 6:24 ` [PATCH v2 3/6] wifi: rtw89: 8852bt: add chip_ops " Ping-Ke Shih
2024-07-19 6:24 ` [PATCH v2 4/6] wifi: rtw89: 8852bt: declare firmware features " Ping-Ke Shih
2024-07-19 6:24 ` [PATCH v2 5/6] wifi: rtw89: 8852bte: add PCI entry of 8852BE-VT Ping-Ke Shih
2024-07-19 6:24 ` [PATCH v2 6/6] wifi: rtw89: 8852bt: add 8852BE-VT to Makefile and Kconfig Ping-Ke Shih
2024-07-20 0:09 ` kernel test robot
2024-07-20 2:05 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e53f0d0a67442642be823081ca6cab49ff122cc4.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox