* [PATCH] wifi: mt76: mt7996: remove code guarded by nonexistent config option
@ 2026-06-10 4:10 Ethan Nelson-Moore
2026-06-10 14:35 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-10 4:10 UTC (permalink / raw)
To: linux-wireless
Cc: Ethan Nelson-Moore, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, Rex Lu
A small piece of code in mt7996.h depends on CONFIG_MTK_DEBUG, which
has never been defined in the kernel. Remove this dead code.
Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h b/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h
index bdcf72457954..39c525a40412 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h
@@ -921,10 +921,6 @@ int mt7996_mmio_wed_init(struct mt7996_dev *dev, void *pdev_ptr,
bool hif2, int *irq);
u32 mt7996_wed_init_buf(void *ptr, dma_addr_t phys, int token_id);
-#ifdef CONFIG_MTK_DEBUG
-int mt7996_mtk_init_debugfs(struct mt7996_phy *phy, struct dentry *dir);
-#endif
-
int mt7996_dma_rro_init(struct mt7996_dev *dev);
void mt7996_dma_rro_start(struct mt7996_dev *dev);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi: mt76: mt7996: remove code guarded by nonexistent config option
2026-06-10 4:10 [PATCH] wifi: mt76: mt7996: remove code guarded by nonexistent config option Ethan Nelson-Moore
@ 2026-06-10 14:35 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2026-06-10 14:35 UTC (permalink / raw)
To: Ethan Nelson-Moore, linux-wireless
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, AngeloGioacchino Del Regno, Rex Lu
On 10/06/2026 06:10, Ethan Nelson-Moore wrote:
> A small piece of code in mt7996.h depends on CONFIG_MTK_DEBUG, which
> has never been defined in the kernel. Remove this dead code.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h b/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h
> index bdcf72457954..39c525a40412 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mt7996.h
> @@ -921,10 +921,6 @@ int mt7996_mmio_wed_init(struct mt7996_dev *dev, void *pdev_ptr,
> bool hif2, int *irq);
> u32 mt7996_wed_init_buf(void *ptr, dma_addr_t phys, int token_id);
>
> -#ifdef CONFIG_MTK_DEBUG
> -int mt7996_mtk_init_debugfs(struct mt7996_phy *phy, struct dentry *dir);
> -#endif
> -
> int mt7996_dma_rro_init(struct mt7996_dev *dev);
> void mt7996_dma_rro_start(struct mt7996_dev *dev);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-10 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 4:10 [PATCH] wifi: mt76: mt7996: remove code guarded by nonexistent config option Ethan Nelson-Moore
2026-06-10 14:35 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox