* [PATCH rtw-next 1/8] wifi: rtw89: pack I/O during bb_sethw to reduce API execution time
2026-07-12 3:44 [PATCH rtw-next 0/8] wifi: rtw89: add RF diagnosis and update random patches Ping-Ke Shih
@ 2026-07-12 3:44 ` Ping-Ke Shih
2026-07-12 3:45 ` [PATCH rtw-next 2/8] wifi: rtw89: mac: abstract register definition of firmware boot debug Ping-Ke Shih
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Ping-Ke Shih @ 2026-07-12 3:44 UTC (permalink / raw)
To: linux-wireless; +Cc: echuang, kevin_yang
From: Eric Huang <echuang@realtek.com>
Wrap rtw89_chip_bb_sethw() with rtw89_io_pack/unpack so all register
writes during baseband hardware initialization are batched into a single
bus transaction. This reduces API execution time from ~11000 us to
~4000 us on affected platforms.
Signed-off-by: Eric Huang <echuang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/core.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 174349c6bc58..0f6d4ad66fe2 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -7810,8 +7810,12 @@ static inline void rtw89_chip_bb_sethw(struct rtw89_dev *rtwdev)
{
const struct rtw89_chip_info *chip = rtwdev->chip;
+ rtw89_io_pack(rtwdev);
+
if (chip->ops->bb_sethw)
chip->ops->bb_sethw(rtwdev);
+
+ rtw89_io_unpack(rtwdev);
}
static inline void rtw89_chip_rfk_init(struct rtw89_dev *rtwdev)
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH rtw-next 2/8] wifi: rtw89: mac: abstract register definition of firmware boot debug
2026-07-12 3:44 [PATCH rtw-next 0/8] wifi: rtw89: add RF diagnosis and update random patches Ping-Ke Shih
2026-07-12 3:44 ` [PATCH rtw-next 1/8] wifi: rtw89: pack I/O during bb_sethw to reduce API execution time Ping-Ke Shih
@ 2026-07-12 3:45 ` Ping-Ke Shih
2026-07-12 3:45 ` [PATCH rtw-next 3/8] wifi: rtw89: 8922d: add TX time limit for 2GHz band Ping-Ke Shih
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Ping-Ke Shih @ 2026-07-12 3:45 UTC (permalink / raw)
To: linux-wireless; +Cc: echuang, kevin_yang
The registers of firmware boot debug are different between WiFi 6 and 7
chips. Add field to abstract it accordingly.
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/fw.c | 5 +++--
drivers/net/wireless/realtek/rtw89/mac.c | 1 +
drivers/net/wireless/realtek/rtw89/mac.h | 1 +
drivers/net/wireless/realtek/rtw89/mac_be.c | 1 +
4 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 0e7168605850..01770a6a1f6f 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -1939,13 +1939,14 @@ static void rtw89_fw_prog_cnt_dump(struct rtw89_dev *rtwdev)
static void rtw89_fw_dl_fail_dump(struct rtw89_dev *rtwdev)
{
+ const struct rtw89_mac_gen_def *mac = rtwdev->chip->mac_def;
u32 val32;
val32 = rtw89_read32(rtwdev, R_AX_WCPU_FW_CTRL);
rtw89_err(rtwdev, "[ERR]fwdl 0x1E0 = 0x%x\n", val32);
- val32 = rtw89_read32(rtwdev, R_AX_BOOT_DBG);
- rtw89_err(rtwdev, "[ERR]fwdl 0x83F0 = 0x%x\n", val32);
+ val32 = rtw89_read32(rtwdev, mac->boot_dbg);
+ rtw89_err(rtwdev, "[ERR]fwdl 0x%x = 0x%x\n", mac->boot_dbg, val32);
rtw89_fw_prog_cnt_dump(rtwdev);
}
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index 6e3da5e4a1b3..b58d9439ee6d 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -7442,6 +7442,7 @@ const struct rtw89_mac_gen_def rtw89_mac_gen_ax = {
.agg_len_ht = R_AX_AGG_LEN_HT_0,
.ps_status = R_AX_PPWRBIT_SETTING,
.mu_gid = &rtw89_mac_mu_gid_addr_ax,
+ .boot_dbg = R_AX_BOOT_DBG,
.muedca_ctrl = {
.addr = R_AX_MUEDCA_EN,
diff --git a/drivers/net/wireless/realtek/rtw89/mac.h b/drivers/net/wireless/realtek/rtw89/mac.h
index a5f1694af91a..c05f5ee0d2fd 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.h
+++ b/drivers/net/wireless/realtek/rtw89/mac.h
@@ -1067,6 +1067,7 @@ struct rtw89_mac_gen_def {
u32 agg_len_ht;
u32 ps_status;
const struct rtw89_mac_mu_gid_addr *mu_gid;
+ u32 boot_dbg;
struct rtw89_reg_def muedca_ctrl;
struct rtw89_reg_def bfee_ctrl;
diff --git a/drivers/net/wireless/realtek/rtw89/mac_be.c b/drivers/net/wireless/realtek/rtw89/mac_be.c
index 4bdf20b7ba6d..46aea7f6a4a1 100644
--- a/drivers/net/wireless/realtek/rtw89/mac_be.c
+++ b/drivers/net/wireless/realtek/rtw89/mac_be.c
@@ -3287,6 +3287,7 @@ const struct rtw89_mac_gen_def rtw89_mac_gen_be = {
.agg_len_ht = R_BE_AGG_LEN_HT_0,
.ps_status = R_BE_WMTX_POWER_BE_BIT_CTL,
.mu_gid = &rtw89_mac_mu_gid_addr_be,
+ .boot_dbg = R_BE_BOOT_DBG,
.muedca_ctrl = {
.addr = R_BE_MUEDCA_EN,
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH rtw-next 3/8] wifi: rtw89: 8922d: add TX time limit for 2GHz band
2026-07-12 3:44 [PATCH rtw-next 0/8] wifi: rtw89: add RF diagnosis and update random patches Ping-Ke Shih
2026-07-12 3:44 ` [PATCH rtw-next 1/8] wifi: rtw89: pack I/O during bb_sethw to reduce API execution time Ping-Ke Shih
2026-07-12 3:45 ` [PATCH rtw-next 2/8] wifi: rtw89: mac: abstract register definition of firmware boot debug Ping-Ke Shih
@ 2026-07-12 3:45 ` Ping-Ke Shih
2026-07-12 3:45 ` [PATCH rtw-next 4/8] wifi: rtw89: introduce helper to get tx shape index Ping-Ke Shih
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Ping-Ke Shih @ 2026-07-12 3:45 UTC (permalink / raw)
To: linux-wireless; +Cc: echuang, kevin_yang
Fix 2.4GHz specific L-SIG length TX issue, causing interoperability problem
with certain APs. Limit the A-MPDU duration to be workaround.
For 8922DE, the MAC limit is 164 ticks, and BB limit is 4608 us. The
conversion is 32.768us / tick. Since smaller limit should be adopted,
BB limit is filled into newly added field.
The units of register and CCTL table are tick and us/512 respectively.
Convert to target unit when filling values.
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/core.h | 1 +
drivers/net/wireless/realtek/rtw89/mac.c | 20 +++++++++++++++++--
drivers/net/wireless/realtek/rtw89/rtw8851b.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852a.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852b.c | 1 +
.../net/wireless/realtek/rtw89/rtw8852bt.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852c.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8922a.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8922d.c | 9 +++++++++
9 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 0f6d4ad66fe2..b7536288c084 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -5012,6 +5012,7 @@ struct rtw89_chip_info {
const struct wiphy_wowlan_support *wowlan_stub;
const struct rtw89_xtal_info *xtal_info;
unsigned long default_quirks; /* bitmap of rtw89_quirks */
+ u16 txtime_limit_2ghz;
};
struct rtw89_chip_variant {
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index b58d9439ee6d..a63f34440554 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -7047,11 +7047,23 @@ __rtw89_mac_set_tx_time(struct rtw89_dev *rtwdev, struct rtw89_sta_link *rtwsta_
{
#define MAC_AX_DFLT_TX_TIME 5280
const struct rtw89_mac_gen_def *mac = rtwdev->chip->mac_def;
+ const struct rtw89_chip_info *chip = rtwdev->chip;
u8 mac_idx = rtwsta_link->rtwvif_link->mac_idx;
u32 max_tx_time = tx_time == 0 ? MAC_AX_DFLT_TX_TIME : tx_time;
+ struct rtw89_entity_conf conf;
+ const struct rtw89_chan *chan;
u32 reg;
int ret = 0;
+ if (chip->txtime_limit_2ghz) {
+ rtw89_entity_get_conf(rtwdev, &conf);
+ chan = conf.chans[mac_idx];
+
+ if (chan->band_type == RTW89_BAND_2G)
+ max_tx_time = min_t(u32, max_tx_time,
+ chip->txtime_limit_2ghz);
+ }
+
if (rtwsta_link->cctl_tx_time) {
rtwsta_link->ampdu_max_time = (max_tx_time - 512) >> 9;
ret = rtw89_chip_h2c_txtime_cmac_tbl(rtwdev, rtwsta_link);
@@ -7062,9 +7074,13 @@ __rtw89_mac_set_tx_time(struct rtw89_dev *rtwdev, struct rtw89_sta_link *rtwsta_
return ret;
}
+ if (chip->chip_gen == RTW89_CHIP_AX)
+ max_tx_time >>= 5;
+ else
+ max_tx_time = max_tx_time * 1000 >> 15;
+
reg = rtw89_mac_reg_by_idx(rtwdev, mac->agg_limit.addr, mac_idx);
- rtw89_write32_mask(rtwdev, reg, mac->agg_limit.mask,
- max_tx_time >> 5);
+ rtw89_write32_mask(rtwdev, reg, mac->agg_limit.mask, max_tx_time);
}
return ret;
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8851b.c b/drivers/net/wireless/realtek/rtw89/rtw8851b.c
index 50480f72c96d..8dd909fc4754 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8851b.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8851b.c
@@ -2779,6 +2779,7 @@ const struct rtw89_chip_info rtw8851b_chip_info = {
#endif
.xtal_info = &rtw8851b_xtal_info,
.default_quirks = 0,
+ .txtime_limit_2ghz = 0,
};
EXPORT_SYMBOL(rtw8851b_chip_info);
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
index 0c7794742650..66e8035703a6 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
@@ -2517,6 +2517,7 @@ const struct rtw89_chip_info rtw8852a_chip_info = {
#endif
.xtal_info = &rtw8852a_xtal_info,
.default_quirks = 0,
+ .txtime_limit_2ghz = 0,
};
EXPORT_SYMBOL(rtw8852a_chip_info);
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852b.c b/drivers/net/wireless/realtek/rtw89/rtw8852b.c
index 5904127cc836..19f35b87d42e 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852b.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852b.c
@@ -1115,6 +1115,7 @@ const struct rtw89_chip_info rtw8852b_chip_info = {
#endif
.xtal_info = NULL,
.default_quirks = 0,
+ .txtime_limit_2ghz = 0,
};
EXPORT_SYMBOL(rtw8852b_chip_info);
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852bt.c b/drivers/net/wireless/realtek/rtw89/rtw8852bt.c
index e68f73827fa5..3da95beddc1f 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852bt.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852bt.c
@@ -951,6 +951,7 @@ const struct rtw89_chip_info rtw8852bt_chip_info = {
#endif
.xtal_info = NULL,
.default_quirks = 0,
+ .txtime_limit_2ghz = 0,
};
EXPORT_SYMBOL(rtw8852bt_chip_info);
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c.c b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
index 968666280c89..54425d707bc6 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852c.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
@@ -3320,6 +3320,7 @@ const struct rtw89_chip_info rtw8852c_chip_info = {
#endif
.xtal_info = NULL,
.default_quirks = 0,
+ .txtime_limit_2ghz = 0,
};
EXPORT_SYMBOL(rtw8852c_chip_info);
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8922a.c b/drivers/net/wireless/realtek/rtw89/rtw8922a.c
index fe87b4929ddc..900aa20cf6ac 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8922a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8922a.c
@@ -3302,6 +3302,7 @@ const struct rtw89_chip_info rtw8922a_chip_info = {
#endif
.xtal_info = NULL,
.default_quirks = 0,
+ .txtime_limit_2ghz = 0,
};
EXPORT_SYMBOL(rtw8922a_chip_info);
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8922d.c b/drivers/net/wireless/realtek/rtw89/rtw8922d.c
index 768434db14c6..27e148b4213a 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8922d.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8922d.c
@@ -1173,8 +1173,10 @@ static void rtw8922d_set_channel_mac(struct rtw89_dev *rtwdev,
u32 sub_carr = rtw89_mac_reg_by_idx(rtwdev, R_BE_TX_SUB_BAND_VALUE, mac_idx);
u32 chk_rate = rtw89_mac_reg_by_idx(rtwdev, R_BE_TXRATE_CHK, mac_idx);
u32 rf_mod = rtw89_mac_reg_by_idx(rtwdev, R_BE_WMAC_RFMOD, mac_idx);
+ const struct rtw89_chip_info *chip = rtwdev->chip;
u8 txsb20 = 0, txsb40 = 0, txsb80 = 0;
u8 rf_mod_val, chk_rate_mask, sifs;
+ u16 tx_time = AMPDU_MAX_TIME_V1;
u32 txsb;
u32 reg;
@@ -1255,6 +1257,12 @@ static void rtw8922d_set_channel_mac(struct rtw89_dev *rtwdev,
reg = rtw89_mac_reg_by_idx(rtwdev, R_BE_MUEDCA_EN, mac_idx);
rtw89_write32_mask(rtwdev, reg, B_BE_SIFS_MACTXEN_TB_T1_DOT05US_MASK, sifs);
+
+ if (chan->band_type == RTW89_BAND_2G && chip->txtime_limit_2ghz)
+ tx_time = min_t(u32, tx_time, chip->txtime_limit_2ghz * 1000 >> 15);
+
+ reg = rtw89_mac_reg_by_idx(rtwdev, R_BE_AMPDU_AGG_LIMIT, mac_idx);
+ rtw89_write32_mask(rtwdev, reg, B_BE_AMPDU_MAX_TIME_MASK, tx_time);
}
static const u32 rtw8922d_sco_barker_threshold[14] = {
@@ -3591,6 +3599,7 @@ const struct rtw89_chip_info rtw8922d_chip_info = {
#endif
.xtal_info = NULL,
.default_quirks = BIT(RTW89_QUIRK_THERMAL_PROT_120C),
+ .txtime_limit_2ghz = 4608,
};
EXPORT_SYMBOL(rtw8922d_chip_info);
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH rtw-next 4/8] wifi: rtw89: introduce helper to get tx shape index
2026-07-12 3:44 [PATCH rtw-next 0/8] wifi: rtw89: add RF diagnosis and update random patches Ping-Ke Shih
` (2 preceding siblings ...)
2026-07-12 3:45 ` [PATCH rtw-next 3/8] wifi: rtw89: 8922d: add TX time limit for 2GHz band Ping-Ke Shih
@ 2026-07-12 3:45 ` Ping-Ke Shih
2026-07-12 3:45 ` [PATCH rtw-next 5/8] wifi: rtw89: add tx shape v0 to keep built-in arrays compatible during transitions Ping-Ke Shih
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Ping-Ke Shih @ 2026-07-12 3:45 UTC (permalink / raw)
To: linux-wireless; +Cc: echuang, kevin_yang
From: Zong-Zhe Yang <kevin_yang@realtek.com>
TX shape has a set of parameters inside RFE (RF Front End) parameters.
It also depends on regulation and even will depend on regulatory 6 GHz
power type afterwards. Introduce a helper to encapsulate the access to
TX shape index.
Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/core.h | 13 +++++++++++++
drivers/net/wireless/realtek/rtw89/rtw8851b.c | 6 ++----
.../net/wireless/realtek/rtw89/rtw8852b_common.c | 6 ++----
drivers/net/wireless/realtek/rtw89/rtw8852c.c | 6 ++----
drivers/net/wireless/realtek/rtw89/rtw8922a.c | 9 ++-------
drivers/net/wireless/realtek/rtw89/rtw8922d.c | 9 ++-------
6 files changed, 23 insertions(+), 26 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index b7536288c084..1e323007421c 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -8042,6 +8042,19 @@ static inline u8 rtw89_regd_get(struct rtw89_dev *rtwdev, u8 band)
return txpwr_regd;
}
+static inline u8 rtw89_get_tx_shape_idx(struct rtw89_dev *rtwdev, u8 band,
+ enum rtw89_rate_section rs)
+{
+ const struct rtw89_rfe_parms *rfe_parms = rtwdev->rfe_parms;
+ const struct rtw89_tx_shape *tx_shape = &rfe_parms->tx_shape;
+ u8 regd = rtw89_regd_get(rtwdev, band);
+
+ if (unlikely(rs >= RTW89_RS_TX_SHAPE_NUM))
+ rs = RTW89_RS_OFDM;
+
+ return (*tx_shape->lmt)[band][rs][regd];
+}
+
static inline void rtw89_ctrl_btg_bt_rx(struct rtw89_dev *rtwdev, bool en,
enum rtw89_phy_idx phy_idx)
{
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8851b.c b/drivers/net/wireless/realtek/rtw89/rtw8851b.c
index 8dd909fc4754..38592504b4d0 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8851b.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8851b.c
@@ -1918,11 +1918,9 @@ static void rtw8851b_set_tx_shape(struct rtw89_dev *rtwdev,
const struct rtw89_chan *chan,
enum rtw89_phy_idx phy_idx)
{
- const struct rtw89_rfe_parms *rfe_parms = rtwdev->rfe_parms;
u8 band = chan->band_type;
- u8 regd = rtw89_regd_get(rtwdev, band);
- u8 tx_shape_cck = (*rfe_parms->tx_shape.lmt)[band][RTW89_RS_CCK][regd];
- u8 tx_shape_ofdm = (*rfe_parms->tx_shape.lmt)[band][RTW89_RS_OFDM][regd];
+ u8 tx_shape_cck = rtw89_get_tx_shape_idx(rtwdev, band, RTW89_RS_CCK);
+ u8 tx_shape_ofdm = rtw89_get_tx_shape_idx(rtwdev, band, RTW89_RS_OFDM);
if (band == RTW89_BAND_2G)
rtw8851b_bb_set_tx_shape_dfir(rtwdev, chan, tx_shape_cck, phy_idx);
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c b/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c
index 7d409a64869f..7c68260dce70 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c
@@ -1321,11 +1321,9 @@ static void rtw8852bx_set_tx_shape(struct rtw89_dev *rtwdev,
const struct rtw89_chan *chan,
enum rtw89_phy_idx phy_idx)
{
- const struct rtw89_rfe_parms *rfe_parms = rtwdev->rfe_parms;
u8 band = chan->band_type;
- u8 regd = rtw89_regd_get(rtwdev, band);
- u8 tx_shape_cck = (*rfe_parms->tx_shape.lmt)[band][RTW89_RS_CCK][regd];
- u8 tx_shape_ofdm = (*rfe_parms->tx_shape.lmt)[band][RTW89_RS_OFDM][regd];
+ u8 tx_shape_cck = rtw89_get_tx_shape_idx(rtwdev, band, RTW89_RS_CCK);
+ u8 tx_shape_ofdm = rtw89_get_tx_shape_idx(rtwdev, band, RTW89_RS_OFDM);
if (band == RTW89_BAND_2G)
rtw8852bx_bb_set_tx_shape_dfir(rtwdev, chan, tx_shape_cck, phy_idx);
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c.c b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
index 54425d707bc6..c7d64fe9c2bc 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852c.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
@@ -2193,11 +2193,9 @@ static void rtw8852c_set_tx_shape(struct rtw89_dev *rtwdev,
const struct rtw89_chan *chan,
enum rtw89_phy_idx phy_idx)
{
- const struct rtw89_rfe_parms *rfe_parms = rtwdev->rfe_parms;
u8 band = chan->band_type;
- u8 regd = rtw89_regd_get(rtwdev, band);
- u8 tx_shape_cck = (*rfe_parms->tx_shape.lmt)[band][RTW89_RS_CCK][regd];
- u8 tx_shape_ofdm = (*rfe_parms->tx_shape.lmt)[band][RTW89_RS_OFDM][regd];
+ u8 tx_shape_cck = rtw89_get_tx_shape_idx(rtwdev, band, RTW89_RS_CCK);
+ u8 tx_shape_ofdm = rtw89_get_tx_shape_idx(rtwdev, band, RTW89_RS_OFDM);
if (band == RTW89_BAND_2G)
rtw8852c_bb_set_tx_shape_dfir(rtwdev, chan, tx_shape_cck, phy_idx);
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8922a.c b/drivers/net/wireless/realtek/rtw89/rtw8922a.c
index 900aa20cf6ac..86a756f51026 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8922a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8922a.c
@@ -2502,15 +2502,10 @@ static void rtw8922a_set_tx_shape(struct rtw89_dev *rtwdev,
const struct rtw89_chan *chan,
enum rtw89_phy_idx phy_idx)
{
- const struct rtw89_rfe_parms *rfe_parms = rtwdev->rfe_parms;
- const struct rtw89_tx_shape *tx_shape = &rfe_parms->tx_shape;
+ u8 band = chan->band_type;
u8 tx_shape_idx;
- u8 band, regd;
-
- band = chan->band_type;
- regd = rtw89_regd_get(rtwdev, band);
- tx_shape_idx = (*tx_shape->lmt)[band][RTW89_RS_OFDM][regd];
+ tx_shape_idx = rtw89_get_tx_shape_idx(rtwdev, band, RTW89_RS_OFDM);
if (tx_shape_idx == 0)
rtw8922a_bb_tx_triangular(rtwdev, false, phy_idx);
else
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8922d.c b/drivers/net/wireless/realtek/rtw89/rtw8922d.c
index 27e148b4213a..462165bc2485 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8922d.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8922d.c
@@ -2854,16 +2854,11 @@ static void rtw8922d_set_tx_shape(struct rtw89_dev *rtwdev,
enum rtw89_phy_idx phy_idx)
{
const struct rtw89_bb_wrap_data *d = rtwdev->phy_info.bb_wrap_data;
- const struct rtw89_rfe_parms *rfe_parms = rtwdev->rfe_parms;
- const struct rtw89_tx_shape *tx_shape = &rfe_parms->tx_shape;
+ u8 band = chan->band_type;
u8 tx_shape_idx;
- u8 band, regd;
const u16 *th;
- band = chan->band_type;
- regd = rtw89_regd_get(rtwdev, band);
- tx_shape_idx = (*tx_shape->lmt)[band][RTW89_RS_OFDM][regd];
-
+ tx_shape_idx = rtw89_get_tx_shape_idx(rtwdev, band, RTW89_RS_OFDM);
if (tx_shape_idx == 0)
goto disable;
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH rtw-next 5/8] wifi: rtw89: add tx shape v0 to keep built-in arrays compatible during transitions
2026-07-12 3:44 [PATCH rtw-next 0/8] wifi: rtw89: add RF diagnosis and update random patches Ping-Ke Shih
` (3 preceding siblings ...)
2026-07-12 3:45 ` [PATCH rtw-next 4/8] wifi: rtw89: introduce helper to get tx shape index Ping-Ke Shih
@ 2026-07-12 3:45 ` Ping-Ke Shih
2026-07-12 3:45 ` [PATCH rtw-next 6/8] wifi: rtw89: extend tx shape format for regulatory 6 GHz power type Ping-Ke Shih
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Ping-Ke Shih @ 2026-07-12 3:45 UTC (permalink / raw)
To: linux-wireless; +Cc: echuang, kevin_yang
From: Zong-Zhe Yang <kevin_yang@realtek.com>
TX shape parameters can come from (old way) built-in arrays or (new way)
FW elements. The built-in arrays will no longer be updated, but will be
retained during a certain transition period. However, the format of newer
TX shape parameters are going to be expanded. It will only be applied to
FW elements. To keep built-in arrays compatible during transition period,
add tx shape v0 for old format.
The v0 fields can be removed along with built-in arrays once transition
period ends.
Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/core.h | 9 +++++++++
drivers/net/wireless/realtek/rtw89/rtw8851b_table.c | 8 ++++----
drivers/net/wireless/realtek/rtw89/rtw8852b_table.c | 4 ++--
drivers/net/wireless/realtek/rtw89/rtw8852c_table.c | 4 ++--
4 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 1e323007421c..94ba7e368880 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -4518,6 +4518,9 @@ struct rtw89_txpwr_rule_6ghz {
struct rtw89_tx_shape {
const u8 (*lmt)[RTW89_BAND_NUM][RTW89_RS_TX_SHAPE_NUM][RTW89_REGD_NUM];
const u8 (*lmt_ru)[RTW89_BAND_NUM][RTW89_REGD_NUM];
+
+ const u8 (*lmt_v0)[RTW89_BAND_NUM][RTW89_RS_TX_SHAPE_NUM][RTW89_REGD_NUM];
+ const u8 (*lmt_ru_v0)[RTW89_BAND_NUM][RTW89_REGD_NUM];
};
struct rtw89_rfe_parms {
@@ -8052,7 +8055,13 @@ static inline u8 rtw89_get_tx_shape_idx(struct rtw89_dev *rtwdev, u8 band,
if (unlikely(rs >= RTW89_RS_TX_SHAPE_NUM))
rs = RTW89_RS_OFDM;
+ if (!tx_shape->lmt)
+ goto v0;
+
return (*tx_shape->lmt)[band][rs][regd];
+
+v0:
+ return (*tx_shape->lmt_v0)[band][rs][regd];
}
static inline void rtw89_ctrl_btg_bt_rx(struct rtw89_dev *rtwdev, bool en,
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8851b_table.c b/drivers/net/wireless/realtek/rtw89/rtw8851b_table.c
index b8105f6e94f1..f875beaec555 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8851b_table.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8851b_table.c
@@ -14887,8 +14887,8 @@ const struct rtw89_rfe_parms rtw89_8851b_dflt_parms = {
.lmt_ru = &rtw89_8851b_txpwr_lmt_ru_5g,
},
.tx_shape = {
- .lmt = &rtw89_8851b_tx_shape_lmt,
- .lmt_ru = &rtw89_8851b_tx_shape_lmt_ru,
+ .lmt_v0 = &rtw89_8851b_tx_shape_lmt,
+ .lmt_ru_v0 = &rtw89_8851b_tx_shape_lmt_ru,
},
};
@@ -14903,8 +14903,8 @@ static const struct rtw89_rfe_parms rtw89_8851b_rfe_parms_type2 = {
.lmt_ru = &rtw89_8851b_txpwr_lmt_ru_5g_type2,
},
.tx_shape = {
- .lmt = &rtw89_8851b_tx_shape_lmt,
- .lmt_ru = &rtw89_8851b_tx_shape_lmt_ru,
+ .lmt_v0 = &rtw89_8851b_tx_shape_lmt,
+ .lmt_ru_v0 = &rtw89_8851b_tx_shape_lmt_ru,
},
};
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852b_table.c b/drivers/net/wireless/realtek/rtw89/rtw8852b_table.c
index 96b18e9095b3..1485a8fc4bde 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852b_table.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852b_table.c
@@ -22922,7 +22922,7 @@ const struct rtw89_rfe_parms rtw89_8852b_dflt_parms = {
.lmt_ru = &rtw89_8852b_txpwr_lmt_ru_5g,
},
.tx_shape = {
- .lmt = &rtw89_8852b_tx_shape_lmt,
- .lmt_ru = &rtw89_8852b_tx_shape_lmt_ru,
+ .lmt_v0 = &rtw89_8852b_tx_shape_lmt,
+ .lmt_ru_v0 = &rtw89_8852b_tx_shape_lmt_ru,
},
};
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c_table.c b/drivers/net/wireless/realtek/rtw89/rtw8852c_table.c
index b4cf497e8524..c5ede63e7e23 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852c_table.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852c_table.c
@@ -57154,7 +57154,7 @@ const struct rtw89_rfe_parms rtw89_8852c_dflt_parms = {
.lmt_ru = &rtw89_8852c_txpwr_lmt_ru_6g,
},
.tx_shape = {
- .lmt = &rtw89_8852c_tx_shape_lmt,
- .lmt_ru = &rtw89_8852c_tx_shape_lmt_ru,
+ .lmt_v0 = &rtw89_8852c_tx_shape_lmt,
+ .lmt_ru_v0 = &rtw89_8852c_tx_shape_lmt_ru,
},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH rtw-next 6/8] wifi: rtw89: extend tx shape format for regulatory 6 GHz power type
2026-07-12 3:44 [PATCH rtw-next 0/8] wifi: rtw89: add RF diagnosis and update random patches Ping-Ke Shih
` (4 preceding siblings ...)
2026-07-12 3:45 ` [PATCH rtw-next 5/8] wifi: rtw89: add tx shape v0 to keep built-in arrays compatible during transitions Ping-Ke Shih
@ 2026-07-12 3:45 ` Ping-Ke Shih
2026-07-12 3:45 ` [PATCH rtw-next 7/8] wifi: rtw89: fw: do bb_preinit before downloading firmware Ping-Ke Shih
2026-07-12 3:45 ` [PATCH rtw-next 8/8] wifi: rtw89: debug: add diagnosis for RF Ping-Ke Shih
7 siblings, 0 replies; 9+ messages in thread
From: Ping-Ke Shih @ 2026-07-12 3:45 UTC (permalink / raw)
To: linux-wireless; +Cc: echuang, kevin_yang
From: Zong-Zhe Yang <kevin_yang@realtek.com>
Even under the same regulation, TX shape may need different settings for
different 6 GHz power types. So, add one more dimension for that. Because
TX shape parameters are not quite large, the 2/5/6 GHz sections are not
divided into different structures. So, the 2/5 GHz sections will also get
the new dimension. To 2/5 GHz sections, fill the TX shape settings with
RTW89_REG_6GHZ_POWER_DFLT (0) field.
Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/core.h | 17 ++++++++++++-----
drivers/net/wireless/realtek/rtw89/fw.c | 16 ++++++++++++++--
drivers/net/wireless/realtek/rtw89/fw.h | 2 ++
3 files changed, 28 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 94ba7e368880..4ba6452a7123 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -4516,8 +4516,9 @@ struct rtw89_txpwr_rule_6ghz {
};
struct rtw89_tx_shape {
- const u8 (*lmt)[RTW89_BAND_NUM][RTW89_RS_TX_SHAPE_NUM][RTW89_REGD_NUM];
- const u8 (*lmt_ru)[RTW89_BAND_NUM][RTW89_REGD_NUM];
+ const u8 (*lmt)[RTW89_BAND_NUM][RTW89_RS_TX_SHAPE_NUM][RTW89_REGD_NUM]
+ [NUM_OF_RTW89_REG_6GHZ_POWER];
+ const u8 (*lmt_ru)[RTW89_BAND_NUM][RTW89_REGD_NUM][NUM_OF_RTW89_REG_6GHZ_POWER];
const u8 (*lmt_v0)[RTW89_BAND_NUM][RTW89_RS_TX_SHAPE_NUM][RTW89_REGD_NUM];
const u8 (*lmt_ru_v0)[RTW89_BAND_NUM][RTW89_REGD_NUM];
@@ -4614,12 +4615,13 @@ struct rtw89_txpwr_lmt_ru_6ghz_data {
struct rtw89_tx_shape_lmt_data {
struct rtw89_txpwr_conf conf;
- u8 v[RTW89_BAND_NUM][RTW89_RS_TX_SHAPE_NUM][RTW89_REGD_NUM];
+ u8 v[RTW89_BAND_NUM][RTW89_RS_TX_SHAPE_NUM][RTW89_REGD_NUM]
+ [NUM_OF_RTW89_REG_6GHZ_POWER];
};
struct rtw89_tx_shape_lmt_ru_data {
struct rtw89_txpwr_conf conf;
- u8 v[RTW89_BAND_NUM][RTW89_REGD_NUM];
+ u8 v[RTW89_BAND_NUM][RTW89_REGD_NUM][NUM_OF_RTW89_REG_6GHZ_POWER];
};
struct rtw89_rfe_data {
@@ -8048,8 +8050,10 @@ static inline u8 rtw89_regd_get(struct rtw89_dev *rtwdev, u8 band)
static inline u8 rtw89_get_tx_shape_idx(struct rtw89_dev *rtwdev, u8 band,
enum rtw89_rate_section rs)
{
+ struct rtw89_regulatory_info *regulatory = &rtwdev->regulatory;
const struct rtw89_rfe_parms *rfe_parms = rtwdev->rfe_parms;
const struct rtw89_tx_shape *tx_shape = &rfe_parms->tx_shape;
+ u8 reg6_pwr = regulatory->reg_6ghz_power;
u8 regd = rtw89_regd_get(rtwdev, band);
if (unlikely(rs >= RTW89_RS_TX_SHAPE_NUM))
@@ -8058,7 +8062,10 @@ static inline u8 rtw89_get_tx_shape_idx(struct rtw89_dev *rtwdev, u8 band,
if (!tx_shape->lmt)
goto v0;
- return (*tx_shape->lmt)[band][rs][regd];
+ if (band != RTW89_BAND_6G)
+ reg6_pwr = RTW89_REG_6GHZ_POWER_DFLT;
+
+ return (*tx_shape->lmt)[band][rs][regd][reg6_pwr];
v0:
return (*tx_shape->lmt_v0)[band][rs][regd];
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 01770a6a1f6f..95acf7caf08e 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -11626,6 +11626,12 @@ fw_tx_shape_lmt_entry_valid(const struct rtw89_fw_tx_shape_lmt_entry *e,
if (e->regd >= RTW89_REGD_NUM)
return false;
+ /* ensure compatibility work with 2/5 GHz */
+ static_assert(RTW89_REG_6GHZ_POWER_DFLT == 0);
+
+ if (e->reg6_pwr >= NUM_OF_RTW89_REG_6GHZ_POWER)
+ return false;
+
return true;
}
@@ -11640,7 +11646,7 @@ void rtw89_fw_load_tx_shape_lmt(struct rtw89_tx_shape_lmt_data *data)
if (!fw_tx_shape_lmt_entry_valid(&entry, cursor, conf))
continue;
- data->v[entry.band][entry.tx_shape_rs][entry.regd] = entry.v;
+ data->v[entry.band][entry.tx_shape_rs][entry.regd][entry.reg6_pwr] = entry.v;
}
}
@@ -11657,6 +11663,12 @@ fw_tx_shape_lmt_ru_entry_valid(const struct rtw89_fw_tx_shape_lmt_ru_entry *e,
if (e->regd >= RTW89_REGD_NUM)
return false;
+ /* ensure compatibility work with 2/5 GHz */
+ static_assert(RTW89_REG_6GHZ_POWER_DFLT == 0);
+
+ if (e->reg6_pwr >= NUM_OF_RTW89_REG_6GHZ_POWER)
+ return false;
+
return true;
}
@@ -11671,7 +11683,7 @@ void rtw89_fw_load_tx_shape_lmt_ru(struct rtw89_tx_shape_lmt_ru_data *data)
if (!fw_tx_shape_lmt_ru_entry_valid(&entry, cursor, conf))
continue;
- data->v[entry.band][entry.regd] = entry.v;
+ data->v[entry.band][entry.regd][entry.reg6_pwr] = entry.v;
}
}
diff --git a/drivers/net/wireless/realtek/rtw89/fw.h b/drivers/net/wireless/realtek/rtw89/fw.h
index af126d15a1fb..5efa75f8c392 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.h
+++ b/drivers/net/wireless/realtek/rtw89/fw.h
@@ -5834,6 +5834,7 @@ struct rtw89_fw_tx_shape_lmt_entry {
u8 tx_shape_rs;
u8 regd;
u8 v;
+ u8 reg6_pwr;
} __packed;
/* must consider compatibility; don't insert new in the mid */
@@ -5841,6 +5842,7 @@ struct rtw89_fw_tx_shape_lmt_ru_entry {
u8 band;
u8 regd;
u8 v;
+ u8 reg6_pwr;
} __packed;
const struct rtw89_rfe_parms *
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH rtw-next 7/8] wifi: rtw89: fw: do bb_preinit before downloading firmware
2026-07-12 3:44 [PATCH rtw-next 0/8] wifi: rtw89: add RF diagnosis and update random patches Ping-Ke Shih
` (5 preceding siblings ...)
2026-07-12 3:45 ` [PATCH rtw-next 6/8] wifi: rtw89: extend tx shape format for regulatory 6 GHz power type Ping-Ke Shih
@ 2026-07-12 3:45 ` Ping-Ke Shih
2026-07-12 3:45 ` [PATCH rtw-next 8/8] wifi: rtw89: debug: add diagnosis for RF Ping-Ke Shih
7 siblings, 0 replies; 9+ messages in thread
From: Ping-Ke Shih @ 2026-07-12 3:45 UTC (permalink / raw)
To: linux-wireless; +Cc: echuang, kevin_yang
The firmware access BB registers while initialization, so driver should
do bb_preinit before downloading firmware. Otherwise, it might get BB IO
stuck and throw error.
rtw89_8922de 0000:04:00.0: loaded firmware rtw89/rtw8922d_fw.bin
rtw89_8922de 0000:04:00.0: Firmware version 0.35.111.7 (51c56e7b), cmd version 1, type 14
rtw89_8922de 0000:04:00.0: Firmware version 0.35.111.7 (51c56e7b), cmd version 1, type 15
rtw89_8922de 0000:04:00.0: fw unexpected status 6
rtw89_8922de 0000:04:00.0: download firmware fail
rtw89_8922de 0000:04:00.0: [ERR]fwdl 0x1E0 = 0x8000012
rtw89_8922de 0000:04:00.0: [ERR]fwdl 0x78F0 = 0x290900
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]fw PC = 0x201445f2
rtw89_8922de 0000:04:00.0: [ERR]H2C path ready
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/core.c | 12 +++++++++++-
drivers/net/wireless/realtek/rtw89/mac.c | 7 ++++---
drivers/net/wireless/realtek/rtw89/mac.h | 3 ++-
3 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
index 0343cd1a0ee1..3950792651c1 100644
--- a/drivers/net/wireless/realtek/rtw89/core.c
+++ b/drivers/net/wireless/realtek/rtw89/core.c
@@ -7197,9 +7197,19 @@ int rtw89_core_mlsr_switch(struct rtw89_dev *rtwdev, struct rtw89_vif *rtwvif,
static int rtw89_chip_efuse_info_setup(struct rtw89_dev *rtwdev)
{
const struct rtw89_mac_gen_def *mac = rtwdev->chip->mac_def;
+ const struct rtw89_chip_info *chip = rtwdev->chip;
+ bool bb_preinit = false;
int ret;
- ret = rtw89_mac_partial_init(rtwdev, false);
+ /*
+ * Normally in probe stage, we don't need to do BB pre-initialization.
+ * However, RTL8922D firmware can access BB registers at firmware
+ * initial state, so initialize it to avoid BB IO stuck in firmware.
+ */
+ if (chip->chip_id == RTL8922D)
+ bb_preinit = true;
+
+ ret = rtw89_mac_partial_init(rtwdev, false, bb_preinit);
if (ret)
return ret;
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index a63f34440554..accc5cdfaa3d 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -4308,13 +4308,14 @@ int rtw89_mac_disable_bb_rf(struct rtw89_dev *rtwdev)
}
EXPORT_SYMBOL(rtw89_mac_disable_bb_rf);
-int rtw89_mac_partial_init(struct rtw89_dev *rtwdev, bool include_bb)
+int rtw89_mac_partial_init(struct rtw89_dev *rtwdev, bool include_bb,
+ bool bb_preinit)
{
int ret;
rtw89_mac_ctrl_hci_dma_trx(rtwdev, true);
- if (include_bb) {
+ if (include_bb || bb_preinit) {
/* Only call BB preinit including configuration of BB MCU for
* the chips which need to download BB MCU firmware. Otherwise,
* calling preinit later to prevent touching registers affecting
@@ -4367,7 +4368,7 @@ int rtw89_mac_init(struct rtw89_dev *rtwdev)
bool include_bb = !!chip->bbmcu_nr;
int ret;
- ret = rtw89_mac_partial_init(rtwdev, include_bb);
+ ret = rtw89_mac_partial_init(rtwdev, include_bb, include_bb);
if (ret)
goto fail;
diff --git a/drivers/net/wireless/realtek/rtw89/mac.h b/drivers/net/wireless/realtek/rtw89/mac.h
index c05f5ee0d2fd..493d2b9626a6 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.h
+++ b/drivers/net/wireless/realtek/rtw89/mac.h
@@ -1302,7 +1302,8 @@ rtw89_write32_port_set(struct rtw89_dev *rtwdev, struct rtw89_vif_link *rtwvif_l
int rtw89_mac_pwr_on(struct rtw89_dev *rtwdev);
void rtw89_mac_pwr_off(struct rtw89_dev *rtwdev);
-int rtw89_mac_partial_init(struct rtw89_dev *rtwdev, bool include_bb);
+int rtw89_mac_partial_init(struct rtw89_dev *rtwdev, bool include_bb,
+ bool bb_preinit);
int rtw89_mac_preinit(struct rtw89_dev *rtwdev);
int rtw89_mac_init(struct rtw89_dev *rtwdev);
int rtw89_mac_dle_init(struct rtw89_dev *rtwdev, enum rtw89_qta_mode mode,
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH rtw-next 8/8] wifi: rtw89: debug: add diagnosis for RF
2026-07-12 3:44 [PATCH rtw-next 0/8] wifi: rtw89: add RF diagnosis and update random patches Ping-Ke Shih
` (6 preceding siblings ...)
2026-07-12 3:45 ` [PATCH rtw-next 7/8] wifi: rtw89: fw: do bb_preinit before downloading firmware Ping-Ke Shih
@ 2026-07-12 3:45 ` Ping-Ke Shih
7 siblings, 0 replies; 9+ messages in thread
From: Ping-Ke Shih @ 2026-07-12 3:45 UTC (permalink / raw)
To: linux-wireless; +Cc: echuang, kevin_yang
From: Zong-Zhe Yang <kevin_yang@realtek.com>
Add debugfs diag_rf and show RFK (RF calibration) diagnosis things for
now. Record channel related info before triggering RFK, and then record
state of each kind of RFK from C2H event report. Besides, in track work,
monitor TSSI status too. Both support history up to 10, and show records
via debugfs.
The following is an example of output.
RFK (next index: 2)
PHY-X = 0 0 0 0 0 0 0 0 0 0
S0-CH = 0012a 0012a 00000 00000 00000 00000 00000 00000 00000 00000
S0-CV = 0032c 0032c 00000 00000 00000 00000 00000 00000 00000 00000
S0-C5 = 10000 10000 00000 00000 00000 00000 00000 00000 00000 00000
S1-CH = 0012a 0012a 00000 00000 00000 00000 00000 00000 00000 00000
S1-CV = 0032d 0032d 00000 00000 00000 00000 00000 00000 00000 00000
S1-C5 = 00000 00000 00000 00000 00000 00000 00000 00000 00000 00000
PRE_NTFY = 0 0 0 0 0 0 0 0 0 0
TSSI = 1 1 0 0 0 0 0 0 0 0
IQK = 1 1 0 0 0 0 0 0 0 0
DPK = 1 1 0 0 0 0 0 0 0 0
TXGAPK = 1 1 0 0 0 0 0 0 0 0
DACK = 0 0 0 0 0 0 0 0 0 0
RX_DCK = 1 1 0 0 0 0 0 0 0 0
TX_IQK = 1 1 0 0 0 0 0 0 0 0
CIM3k = 1 1 0 0 0 0 0 0 0 0
TSSI-track (next index: 6)
S0 = 00e 00e 00c 00d 00d 00e 00d 00d 00d 00e
S1 = 00a 00b 009 00a 00a 00a 009 009 009 00a
Debugfs diag_rf can also be used to manually trigger RFK when written by 1.
Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/core.c | 71 ++++++++++++-
drivers/net/wireless/realtek/rtw89/core.h | 32 ++++++
drivers/net/wireless/realtek/rtw89/debug.c | 115 +++++++++++++++++++++
drivers/net/wireless/realtek/rtw89/phy.c | 62 +++++++++--
drivers/net/wireless/realtek/rtw89/phy.h | 3 +
drivers/net/wireless/realtek/rtw89/reg.h | 1 +
6 files changed, 272 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
index 3950792651c1..5c58ce311c1b 100644
--- a/drivers/net/wireless/realtek/rtw89/core.c
+++ b/drivers/net/wireless/realtek/rtw89/core.c
@@ -486,6 +486,37 @@ void rtw89_core_set_chip_txpwr(struct rtw89_dev *rtwdev)
__rtw89_core_set_chip_txpwr(rtwdev, conf.chans[1], RTW89_PHY_1);
}
+static void rtw89_core_rfk_record(struct rtw89_dev *rtwdev,
+ struct rtw89_vif_link *rtwvif_link,
+ bool start)
+{
+ struct rtw89_rfk_wait_info *info = &rtwdev->rfk_wait;
+ struct rtw89_rfk_record *record = &info->records[info->record_idx];
+ const struct rtw89_chip_info *chip = rtwdev->chip;
+ u8 path_num = min(chip->rf_path_num, RTW89_RFK_RECORD_PATH_NR);
+ int path;
+
+ if (!start)
+ goto end;
+
+ info->record_ptr = record;
+ record->phy_idx = rtwvif_link->phy_idx;
+
+ for (path = 0; path < path_num; path++) {
+ record->ch[path] = rtw89_read_rf(rtwdev, path, RR_CFGCH,
+ RR_CFGCH_BAND0 | RR_CFGCH_CH);
+ record->cv[path] = rtw89_read_rf(rtwdev, path, RR_VCO,
+ RR_VCO_SEL | RR_VCO_STS);
+ record->c5[path] = rtw89_read_rf(rtwdev, path, RR_SYNFB, RFREG_MASK);
+ }
+
+ return;
+
+end:
+ info->record_idx = (info->record_idx + 1) % RTW89_RFK_RECORD_HISTORY_NR;
+ info->record_ptr = NULL;
+}
+
void rtw89_chip_rfk_channel(struct rtw89_dev *rtwdev,
struct rtw89_vif_link *rtwvif_link)
{
@@ -503,9 +534,14 @@ void rtw89_chip_rfk_channel(struct rtw89_dev *rtwdev,
rtw89_set_channel(rtwdev);
}
- if (chip->ops->rfk_channel)
+ if (chip->ops->rfk_channel) {
+ rtw89_core_rfk_record(rtwdev, rtwvif_link, true);
+
chip->ops->rfk_channel(rtwdev, rtwvif_link);
+ rtw89_core_rfk_record(rtwdev, rtwvif_link, false);
+ }
+
if (prehdl_link) {
rtw89_entity_force_hw(rtwdev, RTW89_PHY_NUM);
rtw89_set_channel(rtwdev);
@@ -5274,6 +5310,37 @@ static void rtw89_enter_lps_track(struct rtw89_dev *rtwdev,
}
}
+static void rtw89_core_rfk_tssi_record(struct rtw89_dev *rtwdev)
+{
+ const struct rtw89_chip_info *chip = rtwdev->chip;
+ u8 path_num = min(chip->rf_path_num, RTW89_RFK_RECORD_PATH_NR);
+ struct rtw89_rfk_wait_info *info = &rtwdev->rfk_wait;
+ int i = info->record_tssi_idx;
+ u32 base;
+ u32 mask;
+ int path;
+
+ if (chip->chip_gen == RTW89_CHIP_AX)
+ return;
+
+ info->record_tssi_idx = (info->record_tssi_idx + 1) %
+ RTW89_RFK_RECORD_HISTORY_NR;
+
+ if (chip->chip_id == RTL8922A) {
+ base = 0x2ee10;
+ mask = 0x7fc00;
+ } else {
+ base = 0x2f918;
+ mask = 0x000001ff;
+ }
+
+ for (path = 0; path < path_num; path++) {
+ u32 addr = base + 0x100 * path;
+
+ info->tssi_code[i][path] = rtw89_read32_mask(rtwdev, addr, mask);
+ }
+}
+
static void rtw89_core_rfk_track(struct rtw89_dev *rtwdev)
{
enum rtw89_entity_mode mode;
@@ -5283,6 +5350,8 @@ static void rtw89_core_rfk_track(struct rtw89_dev *rtwdev)
return;
rtw89_chip_rfk_track(rtwdev);
+
+ rtw89_core_rfk_tssi_record(rtwdev);
}
void rtw89_core_update_p2p_ps(struct rtw89_dev *rtwdev,
diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 4ba6452a7123..6fec9ce59f7a 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -5728,11 +5728,43 @@ enum rtw89_rfk_report_state {
RTW89_RFK_STATE_H2C_CMD_ERR = 0x4,
};
+enum rtw89_rfk_report_types {
+ RTW89_RFK_REPORT_PRE_NTFY,
+ RTW89_RFK_REPORT_TSSI,
+ RTW89_RFK_REPORT_IQK,
+ RTW89_RFK_REPORT_DPK,
+ RTW89_RFK_REPORT_TXGAPK,
+ RTW89_RFK_REPORT_DACK,
+ RTW89_RFK_REPORT_RX_DCK,
+ RTW89_RFK_REPORT_TX_IQK,
+ RTW89_RFK_REPORT_CIM3k,
+
+ NUM_OF_RTW89_RFK_REPORT_TYPES,
+};
+
+#define RTW89_RFK_RECORD_PATH_NR 2
+#define RTW89_RFK_RECORD_HISTORY_NR 10
+
+struct rtw89_rfk_record {
+ u32 ch[RTW89_RFK_RECORD_PATH_NR];
+ u32 cv[RTW89_RFK_RECORD_PATH_NR];
+ u32 c5[RTW89_RFK_RECORD_PATH_NR];
+ enum rtw89_phy_idx phy_idx;
+ enum rtw89_rfk_report_state states[NUM_OF_RTW89_RFK_REPORT_TYPES];
+};
+
struct rtw89_rfk_wait_info {
struct completion completion;
ktime_t start_time;
enum rtw89_rfk_report_state state;
u8 version;
+
+ int record_idx;
+ struct rtw89_rfk_record *record_ptr;
+ struct rtw89_rfk_record records[RTW89_RFK_RECORD_HISTORY_NR];
+
+ int record_tssi_idx;
+ u32 tssi_code[RTW89_RFK_RECORD_HISTORY_NR][RTW89_RFK_RECORD_PATH_NR];
};
#define RTW89_DACK_PATH_NR 2
diff --git a/drivers/net/wireless/realtek/rtw89/debug.c b/drivers/net/wireless/realtek/rtw89/debug.c
index e42dc5707576..ccfd69271f90 100644
--- a/drivers/net/wireless/realtek/rtw89/debug.c
+++ b/drivers/net/wireless/realtek/rtw89/debug.c
@@ -93,6 +93,7 @@ struct rtw89_debugfs {
struct rtw89_debugfs_priv beacon_info;
struct rtw89_debugfs_priv diag_mac;
struct rtw89_debugfs_priv diag_bb;
+ struct rtw89_debugfs_priv diag_rf;
struct rtw89_debugfs_priv monitor_opts;
};
@@ -5397,6 +5398,118 @@ rtw89_debug_priv_diag_bb_get(struct rtw89_dev *rtwdev,
return p - buf;
}
+static ssize_t
+rtw89_debug_priv_diag_rf_get(struct rtw89_dev *rtwdev,
+ struct rtw89_debugfs_priv *debugfs_priv,
+ char *buf, size_t bufsz)
+{
+ struct rtw89_rfk_wait_info *info = &rtwdev->rfk_wait;
+ char *p = buf, *end = buf + bufsz;
+ int i, j;
+
+ p += scnprintf(p, end - p, "RFK (next index: %d)\n", info->record_idx);
+
+ p += scnprintf(p, end - p, " PHY-X =");
+ for (i = 0; i < RTW89_RFK_RECORD_HISTORY_NR; i++) {
+ struct rtw89_rfk_record *record = &info->records[i];
+
+ p += scnprintf(p, end - p, " %4d ", record->phy_idx);
+ }
+ p += scnprintf(p, end - p, "\n");
+
+ for (j = 0; j < RTW89_RFK_RECORD_PATH_NR; j++) {
+ p += scnprintf(p, end - p, " S%d-CH =", j);
+ for (i = 0; i < RTW89_RFK_RECORD_HISTORY_NR; i++) {
+ struct rtw89_rfk_record *record = &info->records[i];
+
+ p += scnprintf(p, end - p, " %05x", record->ch[j]);
+ }
+ p += scnprintf(p, end - p, "\n");
+
+ p += scnprintf(p, end - p, " S%d-CV =", j);
+ for (i = 0; i < RTW89_RFK_RECORD_HISTORY_NR; i++) {
+ struct rtw89_rfk_record *record = &info->records[i];
+
+ p += scnprintf(p, end - p, " %05x", record->cv[j]);
+ }
+ p += scnprintf(p, end - p, "\n");
+
+ p += scnprintf(p, end - p, " S%d-C5 =", j);
+ for (i = 0; i < RTW89_RFK_RECORD_HISTORY_NR; i++) {
+ struct rtw89_rfk_record *record = &info->records[i];
+
+ p += scnprintf(p, end - p, " %05x", record->c5[j]);
+ }
+ p += scnprintf(p, end - p, "\n");
+ }
+
+ for (j = 0; j < NUM_OF_RTW89_RFK_REPORT_TYPES; j++) {
+ p += scnprintf(p, end - p, " %-8s =", rtw89_rfk_report_names[j]);
+ for (i = 0; i < RTW89_RFK_RECORD_HISTORY_NR; i++) {
+ struct rtw89_rfk_record *record = &info->records[i];
+
+ p += scnprintf(p, end - p, " %4d ", record->states[j]);
+ }
+ p += scnprintf(p, end - p, "\n");
+ }
+
+ p += scnprintf(p, end - p, "TSSI-track (next index: %d)\n", info->record_tssi_idx);
+
+ for (j = 0; j < RTW89_RFK_RECORD_PATH_NR; j++) {
+ p += scnprintf(p, end - p, " S%d =", j);
+ for (i = 0; i < RTW89_RFK_RECORD_HISTORY_NR; i++)
+ p += scnprintf(p, end - p, " %03x", info->tssi_code[i][j]);
+ p += scnprintf(p, end - p, "\n");
+ }
+
+ return p - buf;
+}
+
+static void rtw89_dbg_diag_rf_set_rfk(struct rtw89_dev *rtwdev)
+{
+ struct rtw89_entity_mgnt *mgnt = &rtwdev->hal.entity_mgnt;
+ struct rtw89_vif_link *rtwvif_link;
+ struct rtw89_vif *rtwvif;
+ unsigned int link_id;
+
+ list_for_each_entry(rtwvif, &mgnt->active_list, mgnt_entry)
+ rtw89_vif_for_each_link(rtwvif, rtwvif_link, link_id)
+ rtw89_chip_rfk_channel(rtwdev, rtwvif_link);
+}
+
+enum rtw89_dbg_diag_rf_type {
+ RTW89_DBG_DIAG_RF_RSVD = 0,
+ RTW89_DBG_DIAG_RF_RFK = 1,
+};
+
+static ssize_t
+rtw89_debug_priv_diag_rf_set(struct rtw89_dev *rtwdev,
+ struct rtw89_debugfs_priv *debugfs_priv,
+ const char *buf, size_t count)
+{
+ u8 type;
+ int ret;
+
+ ret = kstrtou8(buf, 0, &type);
+ if (ret)
+ return -EINVAL;
+
+ if (rtwdev->scanning)
+ rtw89_hw_scan_abort(rtwdev, rtwdev->scan_info.scanning_vif);
+
+ rtw89_leave_ps_mode(rtwdev);
+
+ switch (type) {
+ case RTW89_DBG_DIAG_RF_RFK:
+ rtw89_dbg_diag_rf_set_rfk(rtwdev);
+ break;
+ default:
+ return -EOPNOTSUPP;
+ }
+
+ return count;
+}
+
static ssize_t
rtw89_debug_priv_monitor_opts_get(struct rtw89_dev *rtwdev,
struct rtw89_debugfs_priv *debugfs_priv,
@@ -5509,6 +5622,7 @@ static const struct rtw89_debugfs rtw89_debugfs_templ = {
.beacon_info = rtw89_debug_priv_get(beacon_info),
.diag_mac = rtw89_debug_priv_get(diag_mac, RSIZE_16K, RLOCK),
.diag_bb = rtw89_debug_priv_get(diag_bb, RSIZE_8K, RLOCK),
+ .diag_rf = rtw89_debug_priv_set_and_get(diag_rf, RWLOCK),
.monitor_opts = rtw89_debug_priv_set_and_get(monitor_opts, RWLOCK),
};
@@ -5566,6 +5680,7 @@ void rtw89_debugfs_add_sec2(struct rtw89_dev *rtwdev, struct dentry *debugfs_top
rtw89_debugfs_add_r(beacon_info);
rtw89_debugfs_add_r(diag_mac);
rtw89_debugfs_add_r(diag_bb);
+ rtw89_debugfs_add_rw(diag_rf);
rtw89_debugfs_add_rw(monitor_opts);
}
diff --git a/drivers/net/wireless/realtek/rtw89/phy.c b/drivers/net/wireless/realtek/rtw89/phy.c
index 30d5741da87e..c78107e92206 100644
--- a/drivers/net/wireless/realtek/rtw89/phy.c
+++ b/drivers/net/wireless/realtek/rtw89/phy.c
@@ -3968,6 +3968,23 @@ void (* const rtw89_phy_c2h_rfk_log_handler[])(struct rtw89_dev *rtwdev,
[RTW89_PHY_C2H_RFK_LOG_FUNC_CIM3K] = rtw89_phy_c2h_rfk_log_cim3k,
};
+#define NAME_RTW89_RFK_REPORT(type) \
+ [RTW89_RFK_REPORT_ ## type] = #type
+
+const char * const rtw89_rfk_report_names[] = {
+ NAME_RTW89_RFK_REPORT(PRE_NTFY),
+ NAME_RTW89_RFK_REPORT(TSSI),
+ NAME_RTW89_RFK_REPORT(IQK),
+ NAME_RTW89_RFK_REPORT(DPK),
+ NAME_RTW89_RFK_REPORT(TXGAPK),
+ NAME_RTW89_RFK_REPORT(DACK),
+ NAME_RTW89_RFK_REPORT(RX_DCK),
+ NAME_RTW89_RFK_REPORT(TX_IQK),
+ NAME_RTW89_RFK_REPORT(CIM3k),
+};
+
+static_assert(ARRAY_SIZE(rtw89_rfk_report_names) == NUM_OF_RTW89_RFK_REPORT_TYPES);
+
static
void rtw89_phy_rfk_report_prep(struct rtw89_dev *rtwdev)
{
@@ -3979,8 +3996,8 @@ void rtw89_phy_rfk_report_prep(struct rtw89_dev *rtwdev)
}
static
-int rtw89_phy_rfk_report_wait(struct rtw89_dev *rtwdev, const char *rfk_name,
- unsigned int ms)
+int ____rtw89_phy_rfk_report_wait(struct rtw89_dev *rtwdev, const char *rfk_name,
+ unsigned int ms)
{
struct rtw89_rfk_wait_info *wait = &rtwdev->rfk_wait;
unsigned long time_left;
@@ -4017,6 +4034,29 @@ int rtw89_phy_rfk_report_wait(struct rtw89_dev *rtwdev, const char *rfk_name,
return 0;
}
+static
+int __rtw89_phy_rfk_report_wait(struct rtw89_dev *rtwdev,
+ enum rtw89_rfk_report_types rfk_type,
+ enum rtw89_phy_idx phy_idx,
+ const struct rtw89_chan *chan,
+ unsigned int ms)
+{
+ const char *rfk_name = rtw89_rfk_report_names[rfk_type];
+ struct rtw89_rfk_wait_info *wait = &rtwdev->rfk_wait;
+ struct rtw89_rfk_record *record = wait->record_ptr;
+ int ret;
+
+ ret = ____rtw89_phy_rfk_report_wait(rtwdev, rfk_name, ms);
+
+ if (record)
+ record->states[rfk_type] = wait->state;
+
+ return ret;
+}
+
+#define rtw89_phy_rfk_report_wait(rtwdev, type, phy_idx, chan, ms) \
+ __rtw89_phy_rfk_report_wait(rtwdev, RTW89_RFK_REPORT_ ## type, phy_idx, chan, ms)
+
static void
rtw89_phy_c2h_rfk_report_state(struct rtw89_dev *rtwdev, struct sk_buff *c2h, u32 len)
{
@@ -4122,7 +4162,7 @@ int rtw89_phy_rfk_pre_ntfy_and_wait(struct rtw89_dev *rtwdev,
if (RTW89_CHK_FW_FEATURE_GROUP(WITH_RFK_PRE_NOTIFY, &rtwdev->fw)) {
rtw89_phy_rfk_report_prep(rtwdev);
rtw89_fw_h2c_rf_pre_ntfy(rtwdev, phy_idx);
- ret = rtw89_phy_rfk_report_wait(rtwdev, "PRE_NTFY", ms);
+ ret = rtw89_phy_rfk_report_wait(rtwdev, PRE_NTFY, phy_idx, NULL, ms);
if (ret)
return ret;
}
@@ -4152,7 +4192,7 @@ int rtw89_phy_rfk_tssi_and_wait(struct rtw89_dev *rtwdev,
if (ret)
return ret;
- return rtw89_phy_rfk_report_wait(rtwdev, "TSSI", ms);
+ return rtw89_phy_rfk_report_wait(rtwdev, TSSI, phy_idx, chan, ms);
}
EXPORT_SYMBOL(rtw89_phy_rfk_tssi_and_wait);
@@ -4169,7 +4209,7 @@ int rtw89_phy_rfk_iqk_and_wait(struct rtw89_dev *rtwdev,
if (ret)
return ret;
- return rtw89_phy_rfk_report_wait(rtwdev, "IQK", ms);
+ return rtw89_phy_rfk_report_wait(rtwdev, IQK, phy_idx, chan, ms);
}
EXPORT_SYMBOL(rtw89_phy_rfk_iqk_and_wait);
@@ -4186,7 +4226,7 @@ int rtw89_phy_rfk_dpk_and_wait(struct rtw89_dev *rtwdev,
if (ret)
return ret;
- return rtw89_phy_rfk_report_wait(rtwdev, "DPK", ms);
+ return rtw89_phy_rfk_report_wait(rtwdev, DPK, phy_idx, chan, ms);
}
EXPORT_SYMBOL(rtw89_phy_rfk_dpk_and_wait);
@@ -4203,7 +4243,7 @@ int rtw89_phy_rfk_txgapk_and_wait(struct rtw89_dev *rtwdev,
if (ret)
return ret;
- return rtw89_phy_rfk_report_wait(rtwdev, "TXGAPK", ms);
+ return rtw89_phy_rfk_report_wait(rtwdev, TXGAPK, phy_idx, chan, ms);
}
EXPORT_SYMBOL(rtw89_phy_rfk_txgapk_and_wait);
@@ -4220,7 +4260,7 @@ int rtw89_phy_rfk_dack_and_wait(struct rtw89_dev *rtwdev,
if (ret)
return ret;
- return rtw89_phy_rfk_report_wait(rtwdev, "DACK", ms);
+ return rtw89_phy_rfk_report_wait(rtwdev, DACK, phy_idx, chan, ms);
}
EXPORT_SYMBOL(rtw89_phy_rfk_dack_and_wait);
@@ -4237,7 +4277,7 @@ int rtw89_phy_rfk_rxdck_and_wait(struct rtw89_dev *rtwdev,
if (ret)
return ret;
- return rtw89_phy_rfk_report_wait(rtwdev, "RX_DCK", ms);
+ return rtw89_phy_rfk_report_wait(rtwdev, RX_DCK, phy_idx, chan, ms);
}
EXPORT_SYMBOL(rtw89_phy_rfk_rxdck_and_wait);
@@ -4254,7 +4294,7 @@ int rtw89_phy_rfk_txiqk_and_wait(struct rtw89_dev *rtwdev,
if (ret)
return ret;
- return rtw89_phy_rfk_report_wait(rtwdev, "TX_IQK", ms);
+ return rtw89_phy_rfk_report_wait(rtwdev, TX_IQK, phy_idx, chan, ms);
}
EXPORT_SYMBOL(rtw89_phy_rfk_txiqk_and_wait);
@@ -4271,7 +4311,7 @@ int rtw89_phy_rfk_cim3k_and_wait(struct rtw89_dev *rtwdev,
if (ret)
return ret;
- return rtw89_phy_rfk_report_wait(rtwdev, "CIM3k", ms);
+ return rtw89_phy_rfk_report_wait(rtwdev, CIM3k, phy_idx, chan, ms);
}
EXPORT_SYMBOL(rtw89_phy_rfk_cim3k_and_wait);
diff --git a/drivers/net/wireless/realtek/rtw89/phy.h b/drivers/net/wireless/realtek/rtw89/phy.h
index b0c82bac72f0..0963cdfb1594 100644
--- a/drivers/net/wireless/realtek/rtw89/phy.h
+++ b/drivers/net/wireless/realtek/rtw89/phy.h
@@ -1150,6 +1150,9 @@ void rtw89_phy_rate_pattern_vif(struct rtw89_dev *rtwdev,
bool rtw89_phy_c2h_chk_atomic(struct rtw89_dev *rtwdev, u8 class, u8 func);
void rtw89_phy_c2h_handle(struct rtw89_dev *rtwdev, struct sk_buff *skb,
u32 len, u8 class, u8 func);
+
+extern const char * const rtw89_rfk_report_names[];
+
int rtw89_phy_rfk_pre_ntfy_and_wait(struct rtw89_dev *rtwdev,
enum rtw89_phy_idx phy_idx,
unsigned int ms);
diff --git a/drivers/net/wireless/realtek/rtw89/reg.h b/drivers/net/wireless/realtek/rtw89/reg.h
index 4d2117de798b..3bf2865b81ab 100644
--- a/drivers/net/wireless/realtek/rtw89/reg.h
+++ b/drivers/net/wireless/realtek/rtw89/reg.h
@@ -8763,6 +8763,7 @@
#define RR_VCO 0xb2
#define RR_VCO_VAL GENMASK(18, 14)
#define RR_VCO_SEL GENMASK(9, 8)
+#define RR_VCO_STS GENMASK(7, 0)
#define RR_VCI 0xb3
#define RR_VCI_ON BIT(7)
#define RR_LPF 0xb7
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread