From: sunliming
To: miriam.rachel.korenblit@intel.com, emmanuel.grumbach@intel.com,
johannes.berg@intel.com, itamar.shalev@intel.com,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: sunliming <sunliming@kylinos.cn>,
kernel test robot <lkp@intel.com>,
Dan Carpenter <error27@gmail.com>
Subject: [PATCH] wifi: iwlwifi: pcie: add NULL check for trans->dbg.dest_tlv in dump_monitor
Date: Thu, 6 Aug 2026 13:42:08 +0800 [thread overview]
Message-ID: <20260806054209.457073-1-sunliming> (raw)
From: sunliming <sunliming@kylinos.cn>
Fix below smatch warnings:
drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c:3527 iwl_trans_pcie_dump_monitor()
error: we previously assumed 'trans->dbg.dest_tlv' could be null
Fixes: c8a00a6e89ff ("wifi: iwlwifi: pcie: move generation specific
files to a folder")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c
index 28b276c65952..9cea0fe9e578 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c
@@ -3516,7 +3516,8 @@ iwl_trans_pcie_dump_monitor(struct iwl_trans *trans,
iwl_trans_pcie_read_mem(trans, base, fw_mon_data->data,
monitor_len / sizeof(u32));
- } else if (trans->dbg.dest_tlv->monitor_mode == MARBH_MODE) {
+ } else if (trans->dbg.dest_tlv &&
+ (trans->dbg.dest_tlv->monitor_mode == MARBH_MODE)) {
monitor_len =
iwl_trans_pci_dump_marbh_monitor(trans,
fw_mon_data,
--
2.43.0
reply other threads:[~2026-08-06 5:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806054209.457073-1-sunliming \
--to=miriam.rachel.korenblit@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=error27@gmail.com \
--cc=itamar.shalev@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sunliming@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox