* [PATCH] wifi: iwlwifi: pcie: add NULL check for trans->dbg.dest_tlv in dump_monitor
@ 2026-08-06 5:42 sunliming
0 siblings, 0 replies; only message in thread
From: sunliming @ 2026-08-06 5:42 UTC (permalink / raw)
To: miriam.rachel.korenblit, emmanuel.grumbach, johannes.berg,
itamar.shalev, linux-wireless, linux-kernel
Cc: sunliming, kernel test robot, Dan Carpenter
From: sunliming <sunliming@kylinos.cn>
Fix below smatch warnings:
drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c:3527 iwl_trans_pcie_dump_monitor()
error: we previously assumed 'trans->dbg.dest_tlv' could be null
Fixes: c8a00a6e89ff ("wifi: iwlwifi: pcie: move generation specific
files to a folder")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c
index 28b276c65952..9cea0fe9e578 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/gen1_2/trans.c
@@ -3516,7 +3516,8 @@ iwl_trans_pcie_dump_monitor(struct iwl_trans *trans,
iwl_trans_pcie_read_mem(trans, base, fw_mon_data->data,
monitor_len / sizeof(u32));
- } else if (trans->dbg.dest_tlv->monitor_mode == MARBH_MODE) {
+ } else if (trans->dbg.dest_tlv &&
+ (trans->dbg.dest_tlv->monitor_mode == MARBH_MODE)) {
monitor_len =
iwl_trans_pci_dump_marbh_monitor(trans,
fw_mon_data,
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-06 5:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 5:42 [PATCH] wifi: iwlwifi: pcie: add NULL check for trans->dbg.dest_tlv in dump_monitor sunliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox