Re: [PATCH 7.2 0862/1815] wifi: mt76: mt7921: validate CLC firmware records

Re: [PATCH 7.2 0862/1815] wifi: mt76: mt7921: validate CLC firmware records

[Junjie Cao]

On Sat, 12 Sep 2026 08:43:32 +0200, Greg Kroah-Hartman wrote:
> 7.2-stable review patch.  If anyone has any objections, please let me know.
[...]
> [ Upstream commit 9417c5818a0146980c2608fda94c908e604eb033 ]

Please drop this from 7.2, 6.18, 6.12, 6.6 and 6.1 for now.

On its own it breaks probe on MT7922 with linux-firmware 20260810:
the CLC blob in WIFI_RAM_CODE_MT7922_1.bin carries a record with idx
3, these trees size phy->clc[] at 3 or 2, and the new bounds check
fails mt7921_run_firmware() with -EINVAL. Mainline is fine because
e9f3f1cc133f, also in v7.3-rc1, grew the array to 4. Mikhail Gavrilov
hit it with this commit on a v7.2 tree:
https://lore.kernel.org/all/20260816132325.23007-1-mikhail.v.gavrilov@gmail.com/

The check is still wanted here, today that record is indexed past the
array (UBSAN, https://bugzilla.redhat.com/show_bug.cgi?id=2515420),
but only with the follow-up that skips unknown records. That is on
linux-wireless with Tested-by and Reviewed-by, not applied yet:
https://lore.kernel.org/linux-wireless/20260816174841.1918-1-acharyalaxman8848@gmail.com/

Once it lands the two can go together.

Re: [PATCH 7.2 0862/1815] wifi: mt76: mt7921: validate CLC firmware records

[Sasha Levin]

> Please drop this from 7.2, 6.18, 6.12, 6.6 and 6.1 for now.

Dropped from the 7.2, 6.18, 6.12, 6.6, and 6.1 queues.

-- 
Thanks,
Sasha

Re: [PATCH 7.2 0862/1815] wifi: mt76: mt7921: validate CLC firmware records

[Junjie Cao]

On Sat, 12 Sep 2026 17:00:19 -0400, Sasha Levin wrote:
> Dropped from the 7.2, 6.18, 6.12, 6.6, and 6.1 queues.

The follow-up is in mainline as of v7.3-rc3:

  1a296bfd3e77 ("wifi: mt76: mt7921: skip unknown CLC firmware records")

Please queue it with 9417c5818a01 for 7.2, 6.18, 6.12, 6.6 and 6.1.
Your dropped backports of 9417c5818a01 plus 1a296bfd3e775e on top
apply on 7.2.5, 6.18.51, 6.12.109, 6.6.156 and 6.1.187.

Re: [PATCH 7.2 0862/1815] wifi: mt76: mt7921: validate CLC firmware records

[Sasha Levin]

> Please queue it with 9417c5818a01 for 7.2, 6.18, 6.12, 6.6 and 6.1.

Queued both for 7.2, 6.18, 6.12, 6.6 and 6.1, thanks.

-- 
Thanks,
Sasha