From: Ping-Ke Shih <pkshih@realtek.com>
To: <linux-wireless@vger.kernel.org>
Cc: <lkp@intel.com>, <wenjie.tsai@realtek.com>
Subject: [PATCH rtw-next] wifi: rtw89: correct dependency of the multicolor LED
Date: Fri, 18 Sep 2026 10:11:13 +0800 [thread overview]
Message-ID: <20260918021113.25481-1-pkshih@realtek.com> (raw)
The rtw89 depends on multicolor LED module, but for the case multicolor
LED is module and rtw89 is built-in driver, like
CONFIG_LEDS_CLASS_MULTICOLOR=m
CONFIG_RTW89=y
CONFIG_RTW89_LEDS_MC=y
The linker reports error:
ld.lld: error: undefined symbol: led_classdev_multicolor_register_ext
Avoid this case, and summerize the supported combination as below
CONFIG_LEDS_CLASS_MULTICOLOR y m m
CONFIG_RTW89 y/m m y
support O O X
Fixes: 721d90c8509a ("wifi: rtw89: add multicolor LED support for RTL8852CU valve board")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202609172315.ZYoKvKBS-lkp@intel.com/
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/Kconfig b/drivers/net/wireless/realtek/rtw89/Kconfig
index 7c678dd1f6b3..9c6c16af7f35 100644
--- a/drivers/net/wireless/realtek/rtw89/Kconfig
+++ b/drivers/net/wireless/realtek/rtw89/Kconfig
@@ -215,7 +215,7 @@ config RTW89_LEDS
config RTW89_LEDS_MC
bool
depends on RTW89_LEDS
- depends on LEDS_CLASS_MULTICOLOR
+ depends on LEDS_CLASS_MULTICOLOR=y || LEDS_CLASS_MULTICOLOR=RTW89_CORE
imply LEDS_TRIGGER_TIMER
default y
base-commit: 73e3b1c94c7d5b4a113e7cbb42665dc2fe3b9d78
--
2.25.1
next reply other threads:[~2026-09-18 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 2:11 Ping-Ke Shih [this message]
2026-09-23 2:16 ` [PATCH rtw-next] wifi: rtw89: correct dependency of the multicolor LED Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918021113.25481-1-pkshih@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=wenjie.tsai@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox