* [PATCH rtw-next] wifi: rtw89: correct dependency of the multicolor LED
@ 2026-09-18 2:11 Ping-Ke Shih
2026-09-23 2:16 ` Ping-Ke Shih
0 siblings, 1 reply; 2+ messages in thread
From: Ping-Ke Shih @ 2026-09-18 2:11 UTC (permalink / raw)
To: linux-wireless; +Cc: lkp, wenjie.tsai
The rtw89 depends on multicolor LED module, but for the case multicolor
LED is module and rtw89 is built-in driver, like
CONFIG_LEDS_CLASS_MULTICOLOR=m
CONFIG_RTW89=y
CONFIG_RTW89_LEDS_MC=y
The linker reports error:
ld.lld: error: undefined symbol: led_classdev_multicolor_register_ext
Avoid this case, and summerize the supported combination as below
CONFIG_LEDS_CLASS_MULTICOLOR y m m
CONFIG_RTW89 y/m m y
support O O X
Fixes: 721d90c8509a ("wifi: rtw89: add multicolor LED support for RTL8852CU valve board")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202609172315.ZYoKvKBS-lkp@intel.com/
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/Kconfig b/drivers/net/wireless/realtek/rtw89/Kconfig
index 7c678dd1f6b3..9c6c16af7f35 100644
--- a/drivers/net/wireless/realtek/rtw89/Kconfig
+++ b/drivers/net/wireless/realtek/rtw89/Kconfig
@@ -215,7 +215,7 @@ config RTW89_LEDS
config RTW89_LEDS_MC
bool
depends on RTW89_LEDS
- depends on LEDS_CLASS_MULTICOLOR
+ depends on LEDS_CLASS_MULTICOLOR=y || LEDS_CLASS_MULTICOLOR=RTW89_CORE
imply LEDS_TRIGGER_TIMER
default y
base-commit: 73e3b1c94c7d5b4a113e7cbb42665dc2fe3b9d78
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rtw-next] wifi: rtw89: correct dependency of the multicolor LED
2026-09-18 2:11 [PATCH rtw-next] wifi: rtw89: correct dependency of the multicolor LED Ping-Ke Shih
@ 2026-09-23 2:16 ` Ping-Ke Shih
0 siblings, 0 replies; 2+ messages in thread
From: Ping-Ke Shih @ 2026-09-23 2:16 UTC (permalink / raw)
To: Ping-Ke Shih, linux-wireless; +Cc: lkp, wenjie.tsai
Ping-Ke Shih <pkshih@realtek.com> wrote:
> The rtw89 depends on multicolor LED module, but for the case multicolor
> LED is module and rtw89 is built-in driver, like
>
> CONFIG_LEDS_CLASS_MULTICOLOR=m
> CONFIG_RTW89=y
> CONFIG_RTW89_LEDS_MC=y
>
> The linker reports error:
>
> ld.lld: error: undefined symbol: led_classdev_multicolor_register_ext
>
> Avoid this case, and summerize the supported combination as below
>
> CONFIG_LEDS_CLASS_MULTICOLOR y m m
> CONFIG_RTW89 y/m m y
> support O O X
>
> Fixes: 721d90c8509a ("wifi: rtw89: add multicolor LED support for RTL8852CU valve board")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202609172315.ZYoKvKBS-lkp@intel.com/
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
398660e43ed9 wifi: rtw89: correct dependency of the multicolor LED
---
https://github.com/pkshih/rtw.git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-23 2:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-18 2:11 [PATCH rtw-next] wifi: rtw89: correct dependency of the multicolor LED Ping-Ke Shih
2026-09-23 2:16 ` Ping-Ke Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox