Linux wireless drivers development
 help / color / mirror / Atom feed
From: Josef Schlehofer <pepe.schlehofer@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	linux-wireless@vger.kernel.org,
	Josef Schlehofer <pepe.schlehofer@gmail.com>,
	stable@vger.kernel.org
Subject: [PATCH rtw-next] wifi: rtw88: extend the TX report timeout to RTL8822BU
Date: Mon, 21 Sep 2026 18:53:43 +0200	[thread overview]
Message-ID: <20260921165343.8131-1-pepe.schlehofer@gmail.com> (raw)

The firmware of RTL8822BU does not always report the TX status of a frame
within RTW_TX_PROBE_TIMEOUT (500 ms). The purge timer then drops the
tracking skbs and the driver warns

    rtw_8822bu 3-1:1.0: failed to get tx report from firmware

every one to three seconds on an access point serving clients that use
power save.

The dropped skbs never reach ieee80211_tx_status_irqsafe(), so mac80211
never learns the ACK status of the frames it asked to track. hostapd uses
that status to tell whether a polled station is still there, so it can
treat a responsive station as inactive and eventually disconnect it.

Commit c80788f7c5ae ("wifi: rtw88: increase TX report timeout to fix race
condition") raised the timeout to 2500 ms for RTL8723DU, where the
firmware stays off-channel during background scans for longer than the
original 500 ms. RTL8822BU needs the same treatment. A similar change was
proposed for RTL8822BU in May 2026 but was never resubmitted, see the Link
below.

Tested on a TP-Link Archer T4U v3 (RTL8812BU, handled by rtw_8822bu) as a
2.4 GHz AP with six associated clients: the warning appeared about once
every 2.3 seconds before the change and not once in 67 minutes with it.

Fixes: a82dfd33d123 ("wifi: rtw88: Add common USB chip support")
Cc: stable@vger.kernel.org
Link: https://lists.openwall.net/linux-kernel/2026/05/31/713
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
---
 drivers/net/wireless/realtek/rtw88/tx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/tx.c b/drivers/net/wireless/realtek/rtw88/tx.c
index 4e110a457..55d7923e1 100644
--- a/drivers/net/wireless/realtek/rtw88/tx.c
+++ b/drivers/net/wireless/realtek/rtw88/tx.c
@@ -208,7 +208,8 @@ void rtw_tx_report_enqueue(struct rtw_dev *rtwdev, struct sk_buff *skb, u8 sn)
 	__skb_queue_tail(&tx_report->queue, skb);
 	spin_unlock_irqrestore(&tx_report->q_lock, flags);
 
-	if ((rtwdev->chip->id == RTW_CHIP_TYPE_8723D &&
+	if (((rtwdev->chip->id == RTW_CHIP_TYPE_8723D ||
+	      rtwdev->chip->id == RTW_CHIP_TYPE_8822B) &&
 	     rtwdev->hci.type == RTW_HCI_TYPE_USB) ||
 	    rtw_is_8723bs(rtwdev))
 		timeout = msecs_to_jiffies(2500);

base-commit: 73e3b1c94c7d5b4a113e7cbb42665dc2fe3b9d78
-- 
2.54.0 (Apple Git-157)


             reply	other threads:[~2026-09-21 16:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 16:53 Josef Schlehofer [this message]
2026-09-22  2:03 ` [PATCH rtw-next] wifi: rtw88: extend the TX report timeout to RTL8822BU Ping-Ke Shih
2026-09-23 15:03   ` Bitterblue Smith
2026-09-24  0:49     ` Ping-Ke Shih
2026-09-27  4:38       ` Josef Schlehofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921165343.8131-1-pepe.schlehofer@gmail.com \
    --to=pepe.schlehofer@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox