From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
Josef Schlehofer <pepe.schlehofer@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH rtw-next] wifi: rtw88: extend the TX report timeout to RTL8822BU
Date: Wed, 23 Sep 2026 18:03:13 +0300 [thread overview]
Message-ID: <96f122e7-2004-43d6-917d-a07027f568a4@gmail.com> (raw)
In-Reply-To: <4c000f11b23c4920b052e8513ad28345@realtek.com>
On 22/09/2026 05:03, Ping-Ke Shih wrote:
> Josef Schlehofer <pepe.schlehofer@gmail.com> wrote:
>> diff --git a/drivers/net/wireless/realtek/rtw88/tx.c b/drivers/net/wireless/realtek/rtw88/tx.c
>> index 4e110a457..55d7923e1 100644
>> --- a/drivers/net/wireless/realtek/rtw88/tx.c
>> +++ b/drivers/net/wireless/realtek/rtw88/tx.c
>> @@ -208,7 +208,8 @@ void rtw_tx_report_enqueue(struct rtw_dev *rtwdev, struct sk_buff *skb, u8 sn)
>> __skb_queue_tail(&tx_report->queue, skb);
>> spin_unlock_irqrestore(&tx_report->q_lock, flags);
>>
>> - if ((rtwdev->chip->id == RTW_CHIP_TYPE_8723D &&
>> + if (((rtwdev->chip->id == RTW_CHIP_TYPE_8723D ||
>> + rtwdev->chip->id == RTW_CHIP_TYPE_8822B) &&
>> rtwdev->hci.type == RTW_HCI_TYPE_USB) ||
>
> Hi Bitterblue,
>
> It seems like more and more USB chips need this, let's enlarge timeout time
> for all USB devices. Do you have any concern? Need your input.
>
It seems fine to me.
>> rtw_is_8723bs(rtwdev))
>
> Also, considering SDIO chips, should we keep original timeout for PCI only?
>
This too.
>> timeout = msecs_to_jiffies(2500);
>>
>> base-commit: 73e3b1c94c7d5b4a113e7cbb42665dc2fe3b9d78
>> --
>> 2.54.0 (Apple Git-157)
>
next prev parent reply other threads:[~2026-09-23 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 16:53 [PATCH rtw-next] wifi: rtw88: extend the TX report timeout to RTL8822BU Josef Schlehofer
2026-09-22 2:03 ` Ping-Ke Shih
2026-09-23 15:03 ` Bitterblue Smith [this message]
2026-09-24 0:49 ` Ping-Ke Shih
2026-09-27 4:38 ` Josef Schlehofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96f122e7-2004-43d6-917d-a07027f568a4@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pepe.schlehofer@gmail.com \
--cc=pkshih@realtek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox