* [PATCH rtw-next] wifi: rtw89: remove discouraged imply from Kconfig LED
@ 2026-10-02 6:50 Ping-Ke Shih
2026-10-07 3:52 ` Ping-Ke Shih
0 siblings, 1 reply; 2+ messages in thread
From: Ping-Ke Shih @ 2026-10-02 6:50 UTC (permalink / raw)
To: linux-wireless; +Cc: arnd
The 'imply' in Kconfig to weakly and implicitly select dependencies is
discouraged. Remove them to simply logic.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Closes: https://lore.kernel.org/linux-wireless/7cdc36a9-aadd-4636-8a29-847d89638c8d@app.fastmail.com/T/#t
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/Kconfig b/drivers/net/wireless/realtek/rtw89/Kconfig
index 9c6c16af7f35..0899f0c25612 100644
--- a/drivers/net/wireless/realtek/rtw89/Kconfig
+++ b/drivers/net/wireless/realtek/rtw89/Kconfig
@@ -209,14 +209,12 @@ config RTW89_LEDS
bool
depends on RTW89_CORE
depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
- imply MAC80211_LEDS
default y
config RTW89_LEDS_MC
bool
depends on RTW89_LEDS
depends on LEDS_CLASS_MULTICOLOR=y || LEDS_CLASS_MULTICOLOR=RTW89_CORE
- imply LEDS_TRIGGER_TIMER
default y
endif
base-commit: 7cde94dab0e74434ccc0a387d7ad373fb3becda0
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rtw-next] wifi: rtw89: remove discouraged imply from Kconfig LED
2026-10-02 6:50 [PATCH rtw-next] wifi: rtw89: remove discouraged imply from Kconfig LED Ping-Ke Shih
@ 2026-10-07 3:52 ` Ping-Ke Shih
0 siblings, 0 replies; 2+ messages in thread
From: Ping-Ke Shih @ 2026-10-07 3:52 UTC (permalink / raw)
To: Ping-Ke Shih, linux-wireless; +Cc: arnd
Ping-Ke Shih <pkshih@realtek.com> wrote:
> The 'imply' in Kconfig to weakly and implicitly select dependencies is
> discouraged. Remove them to simply logic.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Closes: https://lore.kernel.org/linux-wireless/7cdc36a9-aadd-4636-8a29-847d89638c8d@app.fastmail.com/T/#t
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
5a4847b554e8 wifi: rtw89: remove discouraged imply from Kconfig LED
---
https://github.com/pkshih/rtw.git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-07 3:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-02 6:50 [PATCH rtw-next] wifi: rtw89: remove discouraged imply from Kconfig LED Ping-Ke Shih
2026-10-07 3:52 ` Ping-Ke Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox