* [PATCH rtw-next 0/2] wifi: rtw89: improve latency and tolerance for power-save
@ 2026-11-03 7:52 Ping-Ke Shih
2026-11-03 7:52 ` [PATCH rtw-next 1/2] wifi: rtw89: enable low-latency power-save optimization for RTL8852B/RTL8852BT Ping-Ke Shih
2026-11-03 7:52 ` [PATCH rtw-next 2/2] wifi: rtw89: avoid premature power save entry for buffered traffic Ping-Ke Shih
0 siblings, 2 replies; 3+ messages in thread
From: Ping-Ke Shih @ 2026-11-03 7:52 UTC (permalink / raw)
To: linux-wireless; +Cc: timlee
Improve latency while entering power-save by first patch for verified chips
RTL8852B/RTL8852BT, and second patch is to improve rules for firmware awake
period. Both can improve user experience.
Chin-Yen Lee (2):
wifi: rtw89: enable low-latency power-save optimization for
RTL8852B/RTL8852BT
wifi: rtw89: avoid premature power save entry for buffered traffic
drivers/net/wireless/realtek/rtw89/core.c | 2 +-
drivers/net/wireless/realtek/rtw89/core.h | 1 +
drivers/net/wireless/realtek/rtw89/fw.c | 40 +++++++++++++++++++
drivers/net/wireless/realtek/rtw89/fw.h | 15 +++++++
drivers/net/wireless/realtek/rtw89/ps.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8851b.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852a.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852b.c | 1 +
.../net/wireless/realtek/rtw89/rtw8852bt.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852c.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8922a.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8922d.c | 1 +
12 files changed, 65 insertions(+), 1 deletion(-)
base-commit: dc16902cad9c6b08df9395a510c7be44fbab545d
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH rtw-next 1/2] wifi: rtw89: enable low-latency power-save optimization for RTL8852B/RTL8852BT
2026-11-03 7:52 [PATCH rtw-next 0/2] wifi: rtw89: improve latency and tolerance for power-save Ping-Ke Shih
@ 2026-11-03 7:52 ` Ping-Ke Shih
2026-11-03 7:52 ` [PATCH rtw-next 2/2] wifi: rtw89: avoid premature power save entry for buffered traffic Ping-Ke Shih
1 sibling, 0 replies; 3+ messages in thread
From: Ping-Ke Shih @ 2026-11-03 7:52 UTC (permalink / raw)
To: linux-wireless; +Cc: timlee
From: Chin-Yen Lee <timlee@realtek.com>
The low-latency power-save optimization (LPS) was originally
introduced specifically for RTL8852A to improve interactive
application performance by exiting power-save during packet
bursts.
To extend this feature to RTL8852B and RTL8852BT, introduce
a new flag "support_low_latency_lps" in chip info instead of
hardcoding chip ID checks. Enable this capability for RTL8852A,
RTL8852B, and RTL8852BT while explicitly disabling it for other
supported chips.
Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/core.c | 2 +-
drivers/net/wireless/realtek/rtw89/core.h | 1 +
drivers/net/wireless/realtek/rtw89/rtw8851b.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852a.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852b.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852bt.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8852c.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8922a.c | 1 +
drivers/net/wireless/realtek/rtw89/rtw8922d.c | 1 +
9 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
index 58ee5efc3b5e..bfa31d365bef 100644
--- a/drivers/net/wireless/realtek/rtw89/core.c
+++ b/drivers/net/wireless/realtek/rtw89/core.c
@@ -3006,7 +3006,7 @@ static bool rtw89_core_proto_stats_can_lps(struct rtw89_dev *rtwdev,
struct rtw89_vif *rtwvif,
enum rtw89_tfc_interval interval)
{
- if (rtwdev->chip->chip_id != RTL8852A)
+ if (!rtwdev->chip->support_low_latency_lps)
return true;
if (rtwvif->burst_active)
diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 0d893b992a4a..cce2c2e48080 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -5837,6 +5837,7 @@ struct rtw89_chip_info {
bool support_sar_by_ant;
bool support_noise;
bool support_fw_cmd_ofld;
+ bool support_low_latency_lps;
bool ul_tb_waveform_ctrl;
bool ul_tb_pwr_diff;
bool rx_freq_from_ie;
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8851b.c b/drivers/net/wireless/realtek/rtw89/rtw8851b.c
index 272f4f4e1fb9..a7facfe96884 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8851b.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8851b.c
@@ -2647,6 +2647,7 @@ const struct rtw89_chip_info rtw8851b_chip_info = {
.support_sar_by_ant = false,
.support_noise = false,
.support_fw_cmd_ofld = false,
+ .support_low_latency_lps = false,
.ul_tb_waveform_ctrl = true,
.ul_tb_pwr_diff = false,
.rx_freq_from_ie = true,
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
index 5207df4f9cd5..3b5e3c178440 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
@@ -2418,6 +2418,7 @@ const struct rtw89_chip_info rtw8852a_chip_info = {
.support_sar_by_ant = false,
.support_noise = true,
.support_fw_cmd_ofld = false,
+ .support_low_latency_lps = true,
.ul_tb_waveform_ctrl = false,
.ul_tb_pwr_diff = false,
.rx_freq_from_ie = true,
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852b.c b/drivers/net/wireless/realtek/rtw89/rtw8852b.c
index d19388b86aca..138f499af677 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852b.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852b.c
@@ -1025,6 +1025,7 @@ const struct rtw89_chip_info rtw8852b_chip_info = {
.support_sar_by_ant = true,
.support_noise = false,
.support_fw_cmd_ofld = false,
+ .support_low_latency_lps = true,
.ul_tb_waveform_ctrl = true,
.ul_tb_pwr_diff = false,
.rx_freq_from_ie = true,
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852bt.c b/drivers/net/wireless/realtek/rtw89/rtw8852bt.c
index 23ad02d1fcd4..7306ae7db096 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852bt.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852bt.c
@@ -866,6 +866,7 @@ const struct rtw89_chip_info rtw8852bt_chip_info = {
.support_sar_by_ant = true,
.support_noise = false,
.support_fw_cmd_ofld = false,
+ .support_low_latency_lps = true,
.ul_tb_waveform_ctrl = true,
.ul_tb_pwr_diff = false,
.rx_freq_from_ie = true,
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c.c b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
index e556ba0c14a7..bdcce2e94f99 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852c.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
@@ -3222,6 +3222,7 @@ const struct rtw89_chip_info rtw8852c_chip_info = {
.support_sar_by_ant = true,
.support_noise = false,
.support_fw_cmd_ofld = true,
+ .support_low_latency_lps = false,
.ul_tb_waveform_ctrl = false,
.ul_tb_pwr_diff = true,
.rx_freq_from_ie = false,
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8922a.c b/drivers/net/wireless/realtek/rtw89/rtw8922a.c
index e48300287697..a3b5da979768 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8922a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8922a.c
@@ -3270,6 +3270,7 @@ const struct rtw89_chip_info rtw8922a_chip_info = {
.support_sar_by_ant = true,
.support_noise = false,
.support_fw_cmd_ofld = false,
+ .support_low_latency_lps = false,
.ul_tb_waveform_ctrl = false,
.ul_tb_pwr_diff = false,
.rx_freq_from_ie = false,
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8922d.c b/drivers/net/wireless/realtek/rtw89/rtw8922d.c
index bdf9bcf2cf22..43d9df619260 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8922d.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8922d.c
@@ -3791,6 +3791,7 @@ const struct rtw89_chip_info rtw8922d_chip_info = {
.support_sar_by_ant = true,
.support_noise = false,
.support_fw_cmd_ofld = false,
+ .support_low_latency_lps = false,
.ul_tb_waveform_ctrl = false,
.ul_tb_pwr_diff = false,
.rx_freq_from_ie = false,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH rtw-next 2/2] wifi: rtw89: avoid premature power save entry for buffered traffic
2026-11-03 7:52 [PATCH rtw-next 0/2] wifi: rtw89: improve latency and tolerance for power-save Ping-Ke Shih
2026-11-03 7:52 ` [PATCH rtw-next 1/2] wifi: rtw89: enable low-latency power-save optimization for RTL8852B/RTL8852BT Ping-Ke Shih
@ 2026-11-03 7:52 ` Ping-Ke Shih
1 sibling, 0 replies; 3+ messages in thread
From: Ping-Ke Shih @ 2026-11-03 7:52 UTC (permalink / raw)
To: linux-wireless; +Cc: timlee
From: Chin-Yen Lee <timlee@realtek.com>
Configure two LPS parameters to prevent premature entry into power
save mode and improving the delivery of real-time traffic. Enable
MART_PS_DTIM_RX to transmit a Null Data frame to synchronize the
power save state with the AP after waking up when buffered traffic
is indicated by the beacon TIM. Enable TRX_EXT_MODE to keep the device
awake for the remainder of the current TBTT interval when the AP has
buffered packets.
Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/fw.c | 40 +++++++++++++++++++++++++
drivers/net/wireless/realtek/rtw89/fw.h | 15 ++++++++++
drivers/net/wireless/realtek/rtw89/ps.c | 1 +
3 files changed, 56 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index ea7dba077f5d..5ba265e0eeed 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -3525,6 +3525,46 @@ int rtw89_fw_h2c_lps_parm(struct rtw89_dev *rtwdev,
return ret;
}
+int rtw89_fw_h2c_lps_adv_param(struct rtw89_dev *rtwdev,
+ struct rtw89_vif_link *rtwvif_link)
+{
+ struct rtw89_h2c_lps_adv_parm *h2c;
+ u32 len = sizeof(*h2c);
+ struct sk_buff *skb;
+ int ret;
+
+ skb = rtw89_fw_h2c_alloc_skb_with_hdr(rtwdev, len);
+ if (!skb) {
+ rtw89_err(rtwdev, "failed to alloc skb for h2c lps adv parm\n");
+ return -ENOMEM;
+ }
+ skb_put(skb, len);
+ h2c = (struct rtw89_h2c_lps_adv_parm *)skb->data;
+
+ h2c->w0 = le32_encode_bits(rtwvif_link->mac_id, RTW89_H2C_PS_ADV_PARM_W0_MACID) |
+ le32_encode_bits(1, RTW89_H2C_PS_ADV_PARM_W0_EN_SMART_PS_DTIM_RX) |
+ le32_encode_bits(1, RTW89_H2C_PS_ADV_PARM_W0_EN_TRX_EXT_MODE);
+
+ rtw89_h2c_pkt_set_hdr(rtwdev, skb, FWCMD_TYPE_H2C,
+ H2C_CAT_MAC,
+ H2C_CL_MAC_PS,
+ H2C_FUNC_MAC_PS_ADVANCE_PARM, 0, 1,
+ len);
+
+ ret = rtw89_h2c_tx(rtwdev, skb, false);
+ if (ret) {
+ rtw89_err(rtwdev, "failed to send h2c\n");
+ goto fail;
+ }
+
+ return 0;
+
+fail:
+ dev_kfree_skb_any(skb);
+
+ return ret;
+}
+
int rtw89_fw_h2c_lps_ch_info(struct rtw89_dev *rtwdev, struct rtw89_vif *rtwvif)
{
const struct rtw89_chip_info *chip = rtwdev->chip;
diff --git a/drivers/net/wireless/realtek/rtw89/fw.h b/drivers/net/wireless/realtek/rtw89/fw.h
index e4d3331fc18f..ba4813b9230f 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.h
+++ b/drivers/net/wireless/realtek/rtw89/fw.h
@@ -2338,6 +2338,18 @@ struct rtw89_h2c_wow_payload_cam_update {
__le32 w8;
} __packed;
+struct rtw89_h2c_lps_adv_parm {
+ __le32 w0;
+ __le32 w1;
+} __packed;
+
+#define RTW89_H2C_PS_ADV_PARM_W0_MACID GENMASK(7, 0)
+#define RTW89_H2C_PS_ADV_PARM_W0_TRX_TIMEOUT_TIME_SET GENMASK(9, 8)
+#define RTW89_H2C_PS_ADV_PARM_W0_EN_SMART_PS_DTIM_RX BIT(10)
+#define RTW89_H2C_PS_ADV_PARM_W0_EN_TRX_EXT_MODE BIT(11)
+#define RTW89_H2C_PS_ADV_PARM_W1_TRX_TIMEOUT_TIME_VAL GENMASK(7, 0)
+#define RTW89_H2C_PS_ADV_PARM_W1_EXTNUM GENMASK(15, 8)
+
#define RTW89_H2C_WOW_PLD_CAM_UPD_W0_R_W BIT(0)
#define RTW89_H2C_WOW_PLD_CAM_UPD_W0_IDX GENMASK(7, 1)
#define RTW89_H2C_WOW_PLD_CAM_UPD_WKFM0 GENMASK(31, 0)
@@ -4800,6 +4812,7 @@ enum rtw89_ps_h2c_func {
H2C_FUNC_MAC_LPS_PARM = 0x0,
H2C_FUNC_P2P_ACT = 0x1,
H2C_FUNC_IPS_CFG = 0x3,
+ H2C_FUNC_MAC_PS_ADVANCE_PARM = 0x4,
H2C_FUNC_PS_POWER_LEVEL = 0x7,
H2C_FUNC_TBTT_TUNING = 0xA,
@@ -5636,6 +5649,8 @@ int rtw89_fw_h2c_init_ba_cam_users(struct rtw89_dev *rtwdev, u8 users,
int rtw89_fw_h2c_lps_parm(struct rtw89_dev *rtwdev,
struct rtw89_lps_parm *lps_param);
+int rtw89_fw_h2c_lps_adv_param(struct rtw89_dev *rtwdev,
+ struct rtw89_vif_link *rtwvif_link);
int rtw89_fw_h2c_lps_ch_info(struct rtw89_dev *rtwdev, struct rtw89_vif *rtwvif);
int rtw89_fw_h2c_lps_ml_cmn_info(struct rtw89_dev *rtwdev,
struct rtw89_vif *rtwvif);
diff --git a/drivers/net/wireless/realtek/rtw89/ps.c b/drivers/net/wireless/realtek/rtw89/ps.c
index 3639292eba7a..40bac65dd8ed 100644
--- a/drivers/net/wireless/realtek/rtw89/ps.c
+++ b/drivers/net/wireless/realtek/rtw89/ps.c
@@ -138,6 +138,7 @@ static void __rtw89_enter_lps_link(struct rtw89_dev *rtwdev,
rtw89_btc_ntfy_radio_state(rtwdev, BTC_RFCTRL_FW_CTRL);
rtw89_fw_h2c_lps_parm(rtwdev, &lps_param);
+ rtw89_fw_h2c_lps_adv_param(rtwdev, rtwvif_link);
if (RTW89_CHK_FW_FEATURE(BEACON_TRACKING, &rtwdev->fw))
rtw89_fw_h2c_pwr_lvl(rtwdev, rtwvif_link);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-03 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-03 7:52 [PATCH rtw-next 0/2] wifi: rtw89: improve latency and tolerance for power-save Ping-Ke Shih
2026-11-03 7:52 ` [PATCH rtw-next 1/2] wifi: rtw89: enable low-latency power-save optimization for RTL8852B/RTL8852BT Ping-Ke Shih
2026-11-03 7:52 ` [PATCH rtw-next 2/2] wifi: rtw89: avoid premature power save entry for buffered traffic Ping-Ke Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox