Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH rtw-next v2 0/3] wifi: rtw88: three fixes around the firmware recovery
@ 2026-11-16  7:20 Mehmet Fide
  2026-11-16  7:20 ` [PATCH rtw-next v2 1/3] wifi: rtw88: free the reserved pages of an interface on " Mehmet Fide
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mehmet Fide @ 2026-11-16  7:20 UTC (permalink / raw)
  To: Ping-Ke Shih
  Cc: Luka Gejak, Zong-Zhe Yang, Tzu-En Huang, Yan-Hsuan Chuang,
	Kalle Valo, Stanislaw Gruszka, Brian Norris, linux-wireless,
	linux-kernel, mehmet.fide

From: Mehmet Fide <mehmet.fide@screeningeagle.com>

Three fixes for what a firmware crash test showed on an RTL8822CE.
They do not depend on the channel switch series, but patch 1 and
patch 2 of that series (v11) both change rtw_fw_update_beacon_work():
the one applied second needs both conditions in its test, and I will
rebase it when asked.

Tested on rtw-next on an i.MX8MP board with PROVE_LOCKING,
DEBUG_ATOMIC_SLEEP and kmemleak, with hostapd. The
firmware crashes were triggered from debugfs on the RTL8822CE:

- patch 1: three crashes with an associated station interface lost
  five reserved pages before and none after; six crashes with an AP
  interface lost three before and none after. A test build that queues
  the beacon update work between the reset and the reconfiguration
  warned "Should not have an empty reserved page" with v1 and did not
  with v2
- patch 2: an unbind after the crashes warned "Have pending ack
  frames!" before and did not after. With a test build that drops
  every TX report of the firmware, the unbind of the RTL8822CE warned
  before; after, neither it nor the RTL8822BU did
- patch 3: each of three crashes with an associated station gave the
  "sleeping function called from invalid context" report before and
  none did after; the link was back after every crash

With the three patches, AP, association, power save, firmware crash
and scan tests on the RTL8822CE, RTL8822CU, RTL8822BU and RTL8821CU
(two adapters) on both bands gave no kernel report and no kmemleak
report, also after the rebase.

v2:
- patch 1: the beacon update work does nothing while
  RTW_FLAG_RESTARTING is set (Luka Gejak)
- patches 2 and 3: Reviewed-by Luka Gejak, no change
- rebased on rtw-next

v1: https://lore.kernel.org/linux-wireless/20261111213239.569224-1-mehmet.fide@gmail.com/

Mehmet Fide (3):
  wifi: rtw88: free the reserved pages of an interface on firmware
    recovery
  wifi: rtw88: report the frames purged from the TX report queue
  wifi: rtw88: reset the stations outside of RCU on firmware recovery

 drivers/net/wireless/realtek/rtw88/fw.c   |  6 ++++--
 drivers/net/wireless/realtek/rtw88/main.c |  8 +++-----
 drivers/net/wireless/realtek/rtw88/tx.c   | 20 ++++++++++++++++----
 drivers/net/wireless/realtek/rtw88/tx.h   |  1 +
 4 files changed, 24 insertions(+), 11 deletions(-)


base-commit: 61a5eb87b2d9b4d5e353780b781cf691f39ba9e1
-- 
2.56.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-16  7:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16  7:20 [PATCH rtw-next v2 0/3] wifi: rtw88: three fixes around the firmware recovery Mehmet Fide
2026-11-16  7:20 ` [PATCH rtw-next v2 1/3] wifi: rtw88: free the reserved pages of an interface on " Mehmet Fide
2026-11-16  7:20 ` [PATCH rtw-next v2 2/3] wifi: rtw88: report the frames purged from the TX report queue Mehmet Fide
2026-11-16  7:20 ` [PATCH rtw-next v2 3/3] wifi: rtw88: reset the stations outside of RCU on firmware recovery Mehmet Fide

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox