* [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364
@ 2026-11-04 15:16 Andre Eikmeyer
2026-11-06 12:06 ` Aditya Garg
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andre Eikmeyer @ 2026-11-04 15:16 UTC (permalink / raw)
To: arend.vanspriel
Cc: linux-wireless, brcm80211, brcm80211-dev-list.pdl, linux-kernel,
Andre Eikmeyer, Yossef Osman, Aditya Garg
brcmfmac enables the firmware's ARP and IPv6 ND offload (ndoe) whenever
the interface is up and not promiscuous. On the Apple firmware for the
BCM4364, ndoe makes IPv6 downloads collapse. IPv6 downloads topped out
at 55 Mbit/s on a MacBookPro15,1 with the BCM4364/3 and on the
MacBookPro16,1 with the later revision. The BCM4377 is not affected.
macOS enables ND offload for associated sleep only. A trace under
macOS 26.6.1 on a MacBookPro16,2 shows nd_hostip_clear, ndoe=1 and the
IPv6 addresses before sleep and ndoe cleared again on wake, see the
first report below. Keep them off on the BCM4364.
Closes: https://github.com/t2linux/kernel/issues/34
Closes: https://github.com/t2linux/T2-Debian-and-Ubuntu-Kernel/issues/227
Tested-by: Yossef Osman <Yossef.Osman@proton.me>
Tested-by: Aditya Garg <aditya.garg@linux.dev>
Signed-off-by: Andre Eikmeyer <dev@deq.rocks>
---
The KaiT2en community runs this patch with its kernels, no regression
was reported.
.../net/wireless/broadcom/brcm80211/brcmfmac/core.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
index 92ec269f43b..6eae7135aeb 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
@@ -13,6 +13,7 @@
#include <net/addrconf.h>
#include <net/ieee80211_radiotap.h>
#include <net/ipv6.h>
+#include <brcm_hw_ids.h>
#include <brcmu_utils.h>
#include <brcmu_wifi.h>
@@ -103,6 +104,15 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable)
return;
}
+ /* With ND offload on while awake, the Apple firmware for the BCM4364
+ * makes IPv6 downloads drop to low rates. macOS runs ARP and ND
+ * offload only in sleep, keep both off on this chip.
+ */
+ if (enable && ifp->drvr->bus_if->chip == BRCM_CC_4364_CHIP_ID) {
+ brcmf_dbg(TRACE, "Skip ARP/ND offload enable on BCM4364\n");
+ enable = false;
+ }
+
if (enable)
mode = BRCMF_ARP_OL_AGENT | BRCMF_ARP_OL_PEER_AUTO_REPLY;
else
base-commit: 991a73f4909f1348ffb4b38765cdb522a775e4c2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 2026-11-04 15:16 [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 Andre Eikmeyer @ 2026-11-06 12:06 ` Aditya Garg 2026-11-16 20:37 ` Arend van Spriel 2026-11-18 12:39 ` [PATCH wireless v2] wifi: brcmfmac: keep ARP and ND offload off on Apple BCM4355 and BCM4364 Andre Eikmeyer 2 siblings, 0 replies; 6+ messages in thread From: Aditya Garg @ 2026-11-06 12:06 UTC (permalink / raw) To: Andre Eikmeyer Cc: arend.vanspriel, linux-wireless, brcm80211, brcm80211-dev-list.pdl, linux-kernel, Andre Eikmeyer, Yossef Osman, stable > On 4 Nov 2026, at 8:46 PM, Andre Eikmeyer <dev@deq.rocks> wrote: > > brcmfmac enables the firmware's ARP and IPv6 ND offload (ndoe) whenever > the interface is up and not promiscuous. On the Apple firmware for the > BCM4364, ndoe makes IPv6 downloads collapse. IPv6 downloads topped out > at 55 Mbit/s on a MacBookPro15,1 with the BCM4364/3 and on the > MacBookPro16,1 with the later revision. The BCM4377 is not affected. > > macOS enables ND offload for associated sleep only. A trace under > macOS 26.6.1 on a MacBookPro16,2 shows nd_hostip_clear, ndoe=1 and the > IPv6 addresses before sleep and ndoe cleared again on wake, see the > first report below. Keep them off on the BCM4364. > > Closes: https://github.com/t2linux/kernel/issues/34 > Closes: https://github.com/t2linux/T2-Debian-and-Ubuntu-Kernel/issues/227 > Tested-by: Yossef Osman <Yossef.Osman@proton.me> > Tested-by: Aditya Garg <aditya.garg@linux.dev> > Signed-off-by: Andre Eikmeyer <dev@deq.rocks> The bug is present even in 6.18 LTS Cc: stable@vger.kernel.org > --- > The KaiT2en community runs this patch with its kernels, no regression > was reported. > > .../net/wireless/broadcom/brcm80211/brcmfmac/core.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > index 92ec269f43b..6eae7135aeb 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c > @@ -13,6 +13,7 @@ > #include <net/addrconf.h> > #include <net/ieee80211_radiotap.h> > #include <net/ipv6.h> > +#include <brcm_hw_ids.h> > #include <brcmu_utils.h> > #include <brcmu_wifi.h> > > @@ -103,6 +104,15 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable) > return; > } > > + /* With ND offload on while awake, the Apple firmware for the BCM4364 > + * makes IPv6 downloads drop to low rates. macOS runs ARP and ND > + * offload only in sleep, keep both off on this chip. > + */ > + if (enable && ifp->drvr->bus_if->chip == BRCM_CC_4364_CHIP_ID) { > + brcmf_dbg(TRACE, "Skip ARP/ND offload enable on BCM4364\n"); > + enable = false; > + } > + > if (enable) > mode = BRCMF_ARP_OL_AGENT | BRCMF_ARP_OL_PEER_AUTO_REPLY; > else > > base-commit: 991a73f4909f1348ffb4b38765cdb522a775e4c2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 2026-11-04 15:16 [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 Andre Eikmeyer 2026-11-06 12:06 ` Aditya Garg @ 2026-11-16 20:37 ` Arend van Spriel 2026-11-18 7:08 ` Aditya Garg 2026-11-18 9:42 ` André Eikmeyer 2026-11-18 12:39 ` [PATCH wireless v2] wifi: brcmfmac: keep ARP and ND offload off on Apple BCM4355 and BCM4364 Andre Eikmeyer 2 siblings, 2 replies; 6+ messages in thread From: Arend van Spriel @ 2026-11-16 20:37 UTC (permalink / raw) To: Andre Eikmeyer Cc: linux-wireless, brcm80211, brcm80211-dev-list.pdl, linux-kernel, Yossef Osman, Aditya Garg, Arend van Spriel On Wed, 4 Nov 2026 16:16:20 +0100, Andre Eikmeyer <dev@deq.rocks> wrote: > brcmfmac enables the firmware's ARP and IPv6 ND offload (ndoe) whenever > the interface is up and not promiscuous. On the Apple firmware for the > BCM4364, ndoe makes IPv6 downloads collapse. [...] > --- > .../net/wireless/broadcom/brcm80211/brcmfmac/core.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > @@ -103,6 +104,15 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable) > return; > } > > + /* With ND offload on while awake, the Apple firmware for the BCM4364 > + * makes IPv6 downloads drop to low rates. macOS runs ARP and ND > + * offload only in sleep, keep both off on this chip. > + */ > + if (enable && ifp->drvr->bus_if->chip == BRCM_CC_4364_CHIP_ID) { > + brcmf_dbg(TRACE, "Skip ARP/ND offload enable on BCM4364\n"); > + enable = false; > + } > + > if (enable) > mode = BRCMF_ARP_OL_AGENT | BRCMF_ARP_OL_PEER_AUTO_REPLY; > else A few comments: 1) The measurements only implicate ndoe. Do you have data showing arpoe also needs to be off? Otherwise please limit this to ND offload. 2) The commit message says this is an issue of the Apple firmware, but the check is on the chip ID only. The same chip IDs are also used with other firmware builds and boards (WCC/non-Apple), which would lose the feature needlessly. Please restrict the quirk to the affected platform, e.g. with the Apple board type (settings->board_type) or a per-firmware quirk, or move it to the vendor feat_attach callback instead of a chip check in this helper. The same applies to the other chip ID quirks of this batch (txbf and FWAUTH). 3) This looks like a bug fix. Please add a Fixes: tag and Cc: stable (as Aditya suggested), and mark the target tree in the subject. [...] Regards, Arend ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 2026-11-16 20:37 ` Arend van Spriel @ 2026-11-18 7:08 ` Aditya Garg 2026-11-18 9:42 ` André Eikmeyer 1 sibling, 0 replies; 6+ messages in thread From: Aditya Garg @ 2026-11-18 7:08 UTC (permalink / raw) To: Arend van Spriel, Andre Eikmeyer Cc: linux-wireless, brcm80211, brcm80211-dev-list.pdl, linux-kernel, Yossef Osman On 17/11/26 02:07, Arend van Spriel wrote: > On Wed, 4 Nov 2026 16:16:20 +0100, Andre Eikmeyer <dev@deq.rocks> wrote: >> brcmfmac enables the firmware's ARP and IPv6 ND offload (ndoe) whenever >> the interface is up and not promiscuous. On the Apple firmware for the >> BCM4364, ndoe makes IPv6 downloads collapse. > > [...] > >> --- >> .../net/wireless/broadcom/brcm80211/brcmfmac/core.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > >> @@ -103,6 +104,15 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable) >> return; >> } >> >> + /* With ND offload on while awake, the Apple firmware for the BCM4364 >> + * makes IPv6 downloads drop to low rates. macOS runs ARP and ND >> + * offload only in sleep, keep both off on this chip. >> + */ >> + if (enable && ifp->drvr->bus_if->chip == BRCM_CC_4364_CHIP_ID) { >> + brcmf_dbg(TRACE, "Skip ARP/ND offload enable on BCM4364\n"); >> + enable = false; >> + } >> + >> if (enable) >> mode = BRCMF_ARP_OL_AGENT | BRCMF_ARP_OL_PEER_AUTO_REPLY; >> else > > A few comments: > > 1) The measurements only implicate ndoe. Do you have data showing arpoe > also needs to be off? Otherwise please limit this to ND offload. Limiting this to ND offload works for my MacBook Pro 16,1. We have also got a bug report stating BCM4355 is also affected.> > 2) The commit message says this is an issue of the Apple firmware, but the > check is on the chip ID only. The same chip IDs are also used with other > firmware builds and boards (WCC/non-Apple), which would lose the feature > needlessly. Please restrict the quirk to the affected platform, e.g. with > the Apple board type (settings->board_type) or a per-firmware quirk, or > move it to the vendor feat_attach callback instead of a chip check in > this helper. The same applies to the other chip ID quirks of this batch > (txbf and FWAUTH). > > 3) This looks like a bug fix. Please add a Fixes: tag and Cc: stable (as > Aditya suggested), and mark the target tree in the subject. > > [...] > > Regards, > Arend Arend and Andre, could you see if this works: -->8-- From 4dce3bc04ce25711e03f8430283a87136726e46c Mon Sep 17 00:00:00 2001 From: Aditya Garg <aditya.garg@linux.dev> Date: Wed, 18 Nov 2026 06:05:59 +0000 Subject: [PATCH] wifi: brcmfmac: keep ND offload off on the BCM4355 and BCM4364 while awake brcmfmac enables the firmware's ARP and IPv6 ND offload (ndoe) whenever the interface is up and not promiscuous. On the Apple firmware for the BCM4355 and BCM4364, ndoe makes IPv6 downloads collapse. MacBookPro15,1 with BCM4364/3, IPv6 downloads topped out at 55 Mbit/s. Same behaviour on the MacBookPro16,1 with the later chip revision and MacBookAir8,1 with BCM4355. Also tested on BCM4377 and turned out this chip is not affected. macOS runs these offloads only in sleep. It enables them on suspend and disables them on wake. Keep them off on the BCM4355 and BCM4364. Signed-off-by: Aditya Garg <aditya.garg@linux.dev> Cc: stable@vger.kernel.org --- .../broadcom/brcm80211/brcmfmac/core.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index 92ec269f43b2..d054d33f3456 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -13,6 +13,7 @@ #include <net/addrconf.h> #include <net/ieee80211_radiotap.h> #include <net/ipv6.h> +#include <brcm_hw_ids.h> #include <brcmu_utils.h> #include <brcmu_wifi.h> @@ -97,6 +98,7 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable) { s32 err; u32 mode; + bool nd_enable = enable; if (enable && brcmf_is_apmode_operating(ifp->drvr->wiphy)) { brcmf_dbg(TRACE, "Skip ARP/ND offload enable when soft AP is running\n"); @@ -125,7 +127,21 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable) } } - err = brcmf_fil_iovar_int_set(ifp, "ndoe", enable); + /* With ND offload on while awake, the Apple firmware for the BCM4355 + * and BCM4364 makes IPv6 downloads drop to low rates. macOS runs ND + * offload only in sleep, keep it off on this chip. + */ + if (nd_enable && + (ifp->drvr->bus_if->chip == BRCM_CC_4355_CHIP_ID || + ifp->drvr->bus_if->chip == BRCM_CC_4364_CHIP_ID) && + ifp->drvr->settings->board_type && + !strncmp(ifp->drvr->settings->board_type, "apple,", 6)) { + brcmf_dbg(TRACE, "Skip ND offload enable on BCM%x, board_type=%s\n", + ifp->drvr->bus_if->chip, ifp->drvr->settings->board_type); + nd_enable = false; + } + + err = brcmf_fil_iovar_int_set(ifp, "ndoe", nd_enable); if (err) { brcmf_dbg(TRACE, "failed to configure (%d) ND offload err = %d\n", enable, err); -- 2.56.0 -->8-- Andre needs to sign this off and add his authorship if this is submitted btw. ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 2026-11-16 20:37 ` Arend van Spriel 2026-11-18 7:08 ` Aditya Garg @ 2026-11-18 9:42 ` André Eikmeyer 1 sibling, 0 replies; 6+ messages in thread From: André Eikmeyer @ 2026-11-18 9:42 UTC (permalink / raw) To: Arend van Spriel Cc: linux-wireless, brcm80211, brcm80211-dev-list.pdl, linux-kernel, Yossef Osman, Aditya Garg On Mon, 16 Nov 2026 21:37:17 +0100 Arend van Spriel <arend.vanspriel@broadcom.com> wrote: > 1) The measurements only implicate ndoe. Do you have data showing > arpoe also needs to be off? Otherwise please limit this to ND offload. Well, scratching my head here as well. The throughput drop is ND alone, with only ND offload off the MacBookPro 15,1 reaches the full 120 Mbit/s as well. I keep ARP offload off anyway because that is how macOS runs this firmware. The macOS trace shows arpoe, nd_hostip_clear and ndoe set to 0 together on wake, and both offloads are only enabled on entry to associated sleep. Apple checks emails, Siri and whatnots on sleep.I can't look into the firmware, and with ARP offload on while awake we would run it in a configuration Apple does not use. With both off it has run on the community machines for weeks without problems.We can enable it but may require another few weeks until we can confirm it's stable. > 2) [...] Please restrict the quirk to the affected platform, e.g. with > the Apple board type (settings->board_type) [...] The same applies to > the other chip ID quirks of this batch (txbf and FWAUTH). Will do! > 3) This looks like a bug fix. Please add a Fixes: tag and Cc: stable > (as Aditya suggested), and mark the target tree in the subject. Yes, v2 goes to wireless with both. Andre ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH wireless v2] wifi: brcmfmac: keep ARP and ND offload off on Apple BCM4355 and BCM4364 2026-11-04 15:16 [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 Andre Eikmeyer 2026-11-06 12:06 ` Aditya Garg 2026-11-16 20:37 ` Arend van Spriel @ 2026-11-18 12:39 ` Andre Eikmeyer 2 siblings, 0 replies; 6+ messages in thread From: Andre Eikmeyer @ 2026-11-18 12:39 UTC (permalink / raw) To: arend.vanspriel Cc: linux-wireless, brcm80211, brcm80211-dev-list.pdl, linux-kernel, Andre Eikmeyer, Yossef Osman, Aditya Garg brcmfmac enables the firmware's ARP and IPv6 ND offload (ndoe) whenever the interface is up and not promiscuous. On the Apple firmware for the BCM4355 and BCM4364, ndoe makes downloads collapse. On the BCM4364, IPv6 downloads topped out at 55 Mbit/s on a MacBookPro15,1 with the BCM4364/3 and on the MacBookPro16,1 with the later revision [1][2]. On the BCM4355 of the MacBookAir8,1, downloads fell to about 50 Mbit/s with the offload on and stayed at 300 to 400 Mbit/s with it off, and the firmware logged errors several times a second [3]. The BCM4377 is not affected. macOS enables ARP and ND offload for associated sleep only and clears both on wake. ARP offload brings no benefit while awake, and without WoWL brcmfmac disconnects on suspend on these Macs, so the offloads are never used in sleep either. With ARP offload on, the firmware answers from its own host IP table, and the host does not notice when that table is stale. brcmfmac already turns both offloads off in promiscuous mode and while a soft AP runs. Keep both off on these chips when the board type is an Apple one, which runs the firmware the way macOS does while awake. [1] https://github.com/t2linux/kernel/issues/34 [2] https://github.com/t2linux/T2-Debian-and-Ubuntu-Kernel/issues/227 [3] https://github.com/t2linux/linux-t2-patches/pull/85 Fixes: 52f22fb21764 ("brcmfmac: add neighbor discovery offload ip address table configuration") Cc: stable@vger.kernel.org Closes: https://github.com/t2linux/kernel/issues/34 Closes: https://github.com/t2linux/T2-Debian-and-Ubuntu-Kernel/issues/227 Link: https://github.com/t2linux/linux-t2-patches/pull/85 Tested-by: Yossef Osman <Yossef.Osman@proton.me> Tested-by: Aditya Garg <aditya.garg@linux.dev> Co-developed-by: Aditya Garg <aditya.garg@linux.dev> Signed-off-by: Aditya Garg <aditya.garg@linux.dev> Signed-off-by: Andre Eikmeyer <dev@deq.rocks> --- Changes in v2: - Restrict the quirk to Apple boards with settings->board_type - Add the BCM4355 of the MacBookAir8,1 (Aditya) - Add Fixes and Cc stable, target wireless - Explain why ARP offload stays off as well - v1: https://lore.kernel.org/all/20261104151620.70671-1-dev@deq.rocks/ .../broadcom/brcm80211/brcmfmac/core.c | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index 92ec269f43b2..00d608923380 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -13,6 +13,7 @@ #include <net/addrconf.h> #include <net/ieee80211_radiotap.h> #include <net/ipv6.h> +#include <brcm_hw_ids.h> #include <brcmu_utils.h> #include <brcmu_wifi.h> @@ -93,6 +94,22 @@ struct brcmf_if *brcmf_get_ifp(struct brcmf_pub *drvr, int ifidx) return ifp; } +static bool brcmf_is_apple_nd_offload_broken(struct brcmf_pub *drvr) +{ + const char *board_type = drvr->settings->board_type; + + if (!board_type || !strstarts(board_type, "apple,")) + return false; + + switch (drvr->bus_if->chip) { + case BRCM_CC_4355_CHIP_ID: + case BRCM_CC_4364_CHIP_ID: + return true; + default: + return false; + } +} + void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable) { s32 err; @@ -103,6 +120,16 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable) return; } + /* With ND offload on while awake, the Apple firmware for the BCM4355 + * and BCM4364 makes IPv6 downloads drop to low rates. macOS runs ARP + * and ND offload only in sleep, keep both off on these chips. + */ + if (enable && brcmf_is_apple_nd_offload_broken(ifp->drvr)) { + brcmf_dbg(TRACE, "Skip ARP/ND offload enable on Apple BCM%x\n", + ifp->drvr->bus_if->chip); + enable = false; + } + if (enable) mode = BRCMF_ARP_OL_AGENT | BRCMF_ARP_OL_PEER_AUTO_REPLY; else base-commit: 763b13f622e2758726e8e3ecaef819db8fa0430a -- 2.56.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-18 12:39 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-11-04 15:16 [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364 Andre Eikmeyer 2026-11-06 12:06 ` Aditya Garg 2026-11-16 20:37 ` Arend van Spriel 2026-11-18 7:08 ` Aditya Garg 2026-11-18 9:42 ` André Eikmeyer 2026-11-18 12:39 ` [PATCH wireless v2] wifi: brcmfmac: keep ARP and ND offload off on Apple BCM4355 and BCM4364 Andre Eikmeyer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox