Linux wireless drivers development
 help / color / mirror / Atom feed
From: Sujith Manoharan <sujith@msujith.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Call mgd_prepare_tx before deauthentication
Date: Wed, 17 Sep 2014 10:24:45 +0530	[thread overview]
Message-ID: <21529.5141.845629.86918@gargle.gargle.HOWL> (raw)
In-Reply-To: <1410928422-25587-1-git-send-email-sujith@msujith.org>

Sujith Manoharan wrote:
> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> 
> With drivers that support multi-channel concurrency,
> make sure that the correct context is in use before
> sending a deauth frame. The driver could be in a different
> context, in which case the frame could be dropped.

The behavior appears to have been changed in:

commit 8c7d857c4a4a552d8d3e1b2e24e1864ec2989285
Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Date:   Wed Jul 25 01:42:36 2012 +0300

    mac80211: don't call mgd_prepare_tx when associated


I am not sure how it can be guaranteed that the driver is
on the right context when trying to send a mgmt frame.
ath9k uses mgd_prepare_tx() to switch to the required context,
so I think this call is necessary even if we are associated.

Sujith

  reply	other threads:[~2014-09-17  4:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  4:33 [PATCH] mac80211: Call mgd_prepare_tx before deauthentication Sujith Manoharan
2014-09-17  4:54 ` Sujith Manoharan [this message]
2014-09-17  5:01   ` Grumbach, Emmanuel
2014-09-17  5:44     ` Sujith Manoharan
2014-09-17  5:50       ` Grumbach, Emmanuel
2014-09-17  6:01         ` Sujith Manoharan
2014-09-17  6:04           ` Grumbach, Emmanuel
2014-09-17  6:17             ` Sujith Manoharan
2014-09-17 19:01               ` Emmanuel Grumbach
2014-09-18  3:05                 ` Sujith Manoharan
2014-09-18  4:13                   ` Sujith Manoharan
2014-09-18  5:08                     ` Emmanuel Grumbach
2014-09-18  5:49                       ` Sujith Manoharan
2014-10-09  9:40                         ` Johannes Berg
2014-10-09 10:22                           ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21529.5141.845629.86918@gargle.gargle.HOWL \
    --to=sujith@msujith.org \
    --cc=emmanuel.grumbach@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox