From: Sujith Manoharan <sujith@msujith.org>
To: Emmanuel Grumbach <egrumbach@gmail.com>
Cc: "Grumbach\, Emmanuel" <emmanuel.grumbach@intel.com>,
Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: Call mgd_prepare_tx before deauthentication
Date: Thu, 18 Sep 2014 09:43:45 +0530 [thread overview]
Message-ID: <21530.23545.178915.653622@gargle.gargle.HOWL> (raw)
In-Reply-To: <21530.19430.782437.984290@gargle.gargle.HOWL>
Sujith Manoharan wrote:
> I don't think trying to switch channel contexts in the flush() callback
> is a good idea. We would be changing the meaning of the callback if
> we do that. Moreover flush() is called from many other places too, like the
> PS code.
>
> It seems appropriate to instruct a driver to make the necessary
> preparations before sending a deauth frame. Do you see any problems
> if mgd_prepare_tx() is called before initiating deauth ?
Calling mgd_prepare_tx() in ieee80211_send_deauth_disassoc(), which
was the case originally, is probably more correct, since there are other
situations where this will be a problem.
CSA is one example. The driver can receive a beacon, mac80211 begins to
process the CSA and if multiple contexts are active, initiates a disconnect
operation. But, in the meantime, if the driver has switched to a different
context, things will break.
Sujith
next prev parent reply other threads:[~2014-09-18 4:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 4:33 [PATCH] mac80211: Call mgd_prepare_tx before deauthentication Sujith Manoharan
2014-09-17 4:54 ` Sujith Manoharan
2014-09-17 5:01 ` Grumbach, Emmanuel
2014-09-17 5:44 ` Sujith Manoharan
2014-09-17 5:50 ` Grumbach, Emmanuel
2014-09-17 6:01 ` Sujith Manoharan
2014-09-17 6:04 ` Grumbach, Emmanuel
2014-09-17 6:17 ` Sujith Manoharan
2014-09-17 19:01 ` Emmanuel Grumbach
2014-09-18 3:05 ` Sujith Manoharan
2014-09-18 4:13 ` Sujith Manoharan [this message]
2014-09-18 5:08 ` Emmanuel Grumbach
2014-09-18 5:49 ` Sujith Manoharan
2014-10-09 9:40 ` Johannes Berg
2014-10-09 10:22 ` Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21530.23545.178915.653622@gargle.gargle.HOWL \
--to=sujith@msujith.org \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox