Re: [RFC PATCH wireless-next v3 3/4] wifi: aic: add FullMAC WLAN driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/08/2026 14:11, Yanli Yang wrote:
> +
> +#ifndef CONFIG_PLATFORM_EXTERNAL
> +#ifdef CONFIG_GPIO_WAKEUP
> +static int wakeup_enable;
> +static u32 hostwake_irq_num;
> +#endif
> +#endif
> +

What?

> +/* debug trace */
> +// static struct wakeup_source *ws_rx_sdio;
> +// static struct wakeup_source *ws_sdio_pwrctrl;
> +// static struct wakeup_source *ws_tx_sdio;
> +#ifdef CONFIG_GPIO_WAKEUP
> +// static struct wakeup_source *ws;
> +#endif
> +
> +#ifdef CONFIG_PLATFORM_EXTERNAL

NAK, there is no such CONFIG symbol.

> +
> +#define ENTER() (pr_info("AICWF enter %s\n", __func__))
> +#define LEAVE() (pr_info("AICWF exit %s\n", __func__))


No. You cannot re-implement tracing. Drop this from EVERYWHERE.

> +
> +int regist_wakeup_irq(struct aic_sdio_dev *sdiodev)
> +{
> +	int ret = -EINVAL;
> +	struct device *dev = sdiodev->dev;
> +	struct device_node *node;
> +
> +	ENTER();
> +
> +	node = of_find_compatible_node(NULL, NULL, "aic,wifi-wake-host");

Undocumented ABI. Would not be accepted anyway.



> +	if (!node)
> +		goto err_exit;
> 
This driver does not look like upstream code at all. You should clean it
up before you post next v4.

Best regards,
Krzysztof