Linux wireless drivers development
 help / color / mirror / Atom feed
From: Christian Hewitt <christianshewitt@gmail.com>
To: Yanli Yang <yanli.yang@bedmex.com>
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>,
	Zhirun Liu <zhirunliu@aicsemi.com>,
	Dijia Xu <dijiaxu@aicsemi.com>,
	Chunqiu Liu <chunqiuliu@aicsemi.com>,
	Liheng Wei <liheng.wei@bedmex.com>
Subject: Re: [RFC PATCH wireless-next v4 0/4] wifi: aic: add AIC8800D80 SDIO FullMAC driver
Date: Mon, 31 Aug 2026 11:16:27 +0400	[thread overview]
Message-ID: <E0243DAE-3690-40EF-B38E-BEE2A226BC50@gmail.com> (raw)
In-Reply-To: <cover.1787991457.git.yanli.yang@bedmex.com>

> On 29 Aug 2026, at 12:21 pm, Yanli Yang <yanli.yang@bedmex.com> wrote:
> 
> Johannes,
> 
> This v4 fixes the build failure in v3 against current wireless-next.
> 
> Commit 914781c72813 ("wifi: cfg80211: convert cookie output to input
> parameter") changed the cfg80211 remain_on_channel and mgmt_tx callbacks
> from u64 pointer output parameters to preassigned u64 input parameters.
> The driver now accepts each cookie by value, carries it through the
> remain-on-channel and management-TX state, and reports the same cookie in
> the corresponding cfg80211 completion notification.  The obsolete local
> remain-on-channel cookie counter has been removed.
> 
> This revision also removes two unused global definitions found during the
> rebuild.  The feature scope and the status of the outstanding RFC review
> items are otherwise unchanged from v3.
> 
> Validation performed for v4 against wireless-next at ca800a9302764:
> 
>  - x86-64 GCC build with AIC8800_BSP_SUPPORT=m,
>    AIC8800_WLAN_SUPPORT=m and W=1;
>  - sequential application of all four patches; and
>  - comparison of the applied series with the current AIC source tree.
> 
> No runtime retest was performed for v4.  The AIC8800D80 U02 SDIO hardware
> validation reported with v3 is unchanged.

I picked the four patches in this series into my rockchip-7.2.y kernel
branch [0] and compile failed. Claude Opus suggested fixes [1] which
allowed compile to succeed. Sadly I've no idea if the changes resulted
in a working driver as I've enthusiastically powered up a Radxa Rock4D
board and rediscovered its AIC8800 is connected via USB not SDIO; but I
figured I'd share the finding anyway, in case it's valid.

Keep up the good work, I look forward to USB support in the future!

Christian

[0] https://github.com/chewitt/linux/commits/rockchip-7.2.y
[1] https://github.com/chewitt/linux/commit/9bc092d55a76ec5a647494223147dfc1f1700853



      parent reply	other threads:[~2026-08-31  7:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23  2:13 [RFC PATCH wireless-next v2 0/4] wifi: aic: add AIC8800 SDIO FullMAC driver Yanli Yang
2026-07-23  2:13 ` [RFC PATCH wireless-next v2 1/4] wifi: aic: add SDIO BSP and build configuration Yanli Yang
2026-07-23  2:13 ` [RFC PATCH wireless-next v2 2/4] wifi: aic: add FullMAC firmware and platform interface Yanli Yang
2026-07-23  2:13 ` [RFC PATCH wireless-next v2 3/4] wifi: aic: add FullMAC WLAN driver Yanli Yang
2026-07-23  2:13 ` [RFC PATCH wireless-next v2 4/4] wifi: aic: integrate AIC8800 driver Yanli Yang
2026-07-23  8:42 ` [RFC PATCH wireless-next v2 0/4] wifi: aic: add AIC8800 SDIO FullMAC driver Johannes Berg
2026-07-23  8:48   ` Johannes Berg
2026-08-28 12:11     ` [RFC PATCH wireless-next v3 0/4] wifi: aic: add AIC8800D80 " Yanli Yang
2026-08-28 12:11       ` [RFC PATCH wireless-next v3 1/4] wifi: aic: add SDIO BSP and build configuration Yanli Yang
2026-08-29  8:18         ` Krzysztof Kozlowski
2026-08-28 12:11       ` [RFC PATCH wireless-next v3 2/4] wifi: aic: add FullMAC firmware and platform interface Yanli Yang
2026-08-28 12:11       ` [RFC PATCH wireless-next v3 3/4] wifi: aic: add FullMAC WLAN driver Yanli Yang
2026-08-29  8:21         ` Krzysztof Kozlowski
2026-08-28 12:11       ` [RFC PATCH wireless-next v3 4/4] wifi: aic: integrate AIC8800 driver Yanli Yang
2026-08-29  8:21       ` [RFC PATCH wireless-next v4 0/4] wifi: aic: add AIC8800D80 SDIO FullMAC driver Yanli Yang
2026-08-29  8:21         ` [RFC PATCH wireless-next v4 1/4] wifi: aic: add SDIO BSP and build configuration Yanli Yang
2026-08-29  8:21         ` [RFC PATCH wireless-next v4 2/4] wifi: aic: add FullMAC firmware and platform interface Yanli Yang
2026-08-29  8:21         ` [RFC PATCH wireless-next v4 3/4] wifi: aic: add FullMAC WLAN driver Yanli Yang
2026-08-29  8:21         ` [RFC PATCH wireless-next v4 4/4] wifi: aic: integrate AIC8800 driver Yanli Yang
2026-08-31  7:16         ` Christian Hewitt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E0243DAE-3690-40EF-B38E-BEE2A226BC50@gmail.com \
    --to=christianshewitt@gmail.com \
    --cc=chunqiuliu@aicsemi.com \
    --cc=dijiaxu@aicsemi.com \
    --cc=johannes@sipsolutions.net \
    --cc=liheng.wei@bedmex.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yanli.yang@bedmex.com \
    --cc=zhirunliu@aicsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox