* RE: [PATCH] mwifiex: remove unnecessary call to memset
@ 2017-09-12 1:36 Xinming Hu
0 siblings, 0 replies; 2+ messages in thread
From: Xinming Hu @ 2017-09-12 1:36 UTC (permalink / raw)
To: Himanshu Jha, amitkarwar@gmail.com
Cc: Nishant Sarmukadam, Ganapathi Bhat, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
SGkgSGltYW5zaHUsDQoNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBI
aW1hbnNodSBKaGEgW21haWx0bzpoaW1hbnNodWpoYTE5OTY0MEBnbWFpbC5jb21dDQo+IFNlbnQ6
IDIwMTfE6jnUwjExyNUgMjA6NDYNCj4gVG86IGFtaXRrYXJ3YXJAZ21haWwuY29tDQo+IENjOiBO
aXNoYW50IFNhcm11a2FkYW0gPG5pc2hhbnRzQG1hcnZlbGwuY29tPjsgR2FuYXBhdGhpIEJoYXQN
Cj4gPGdiaGF0QG1hcnZlbGwuY29tPjsgWGlubWluZyBIdSA8aHV4bUBtYXJ2ZWxsLmNvbT47DQo+
IGt2YWxvQGNvZGVhdXJvcmEub3JnOyBsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmc7DQo+
IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmc7IEhpbWFuc2h1IEpoYSA8aGltYW5zaHVqaGExOTk2NDBA
Z21haWwuY29tPg0KPiBTdWJqZWN0OiBbRVhUXSBbUEFUQ0hdIG13aWZpZXg6IHJlbW92ZSB1bm5l
Y2Vzc2FyeSBjYWxsIHRvIG1lbXNldA0KPiANCj4gRXh0ZXJuYWwgRW1haWwNCj4gDQo+IC0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0NCj4gY2FsbCB0byBtZW1zZXQgdG8gYXNzaWduIDAgdmFsdWUgaW1tZWRpYXRlbHkg
YWZ0ZXIgYWxsb2NhdGluZyBtZW1vcnkgd2l0aA0KPiBremFsbG9jIGlzIHVubmVjZXNhYXJ5IGFz
IGt6YWxsb2MgYWxsb2NhdGVzIHRoZSBtZW1vcnkgZmlsbGVkIHdpdGggMCB2YWx1ZS4NCj4gDQoN
Ckxvb2tzIGZpbmQgdG8gbWUsIFRoYW5rcy4NCg0KUmVnYXJkcywNClNpbW9uDQoNCj4gU2VtYW50
aWMgcGF0Y2ggdXNlZCB0byByZXNvbHZlIHRoaXMgaXNzdWU6DQo+IA0KPiBAQA0KPiBleHByZXNz
aW9uIGUsZTI7IGNvbnN0YW50IGM7DQo+IHN0YXRlbWVudCBTOw0KPiBAQA0KPiANCj4gICBlID0g
a3phbGxvYyhlMiwgYyk7DQo+ICAgaWYoZSA9PSBOVUxMKSBTDQo+IC0gbWVtc2V0KGUsIDAsIGUy
KTsNCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEhpbWFuc2h1IEpoYSA8aGltYW5zaHVqaGExOTk2NDBA
Z21haWwuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdpZmll
eC9zY2FuLmMgfCAyIC0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkNCj4gDQo+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC93aXJlbGVzcy9tYXJ2ZWxsL213aWZpZXgvc2Nhbi5j
DQo+IGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvbWFydmVsbC9td2lmaWV4L3NjYW4uYw0KPiBpbmRl
eCBjOWQ0MWVkLi44ODM4Yjg4IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9t
YXJ2ZWxsL213aWZpZXgvc2Nhbi5jDQo+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZl
bGwvbXdpZmlleC9zY2FuLmMNCj4gQEAgLTE5MzYsOCArMTkzNiw2IEBAIG13aWZpZXhfYWN0aXZl
X3NjYW5fcmVxX2Zvcl9wYXNzaXZlX2NoYW4oc3RydWN0DQo+IG13aWZpZXhfcHJpdmF0ZSAqcHJp
dikNCj4gIAlpZiAoIXVzZXJfc2Nhbl9jZmcpDQo+ICAJCXJldHVybiAtRU5PTUVNOw0KPiANCj4g
LQltZW1zZXQodXNlcl9zY2FuX2NmZywgMCwgc2l6ZW9mKCp1c2VyX3NjYW5fY2ZnKSk7DQo+IC0N
Cj4gIAlmb3IgKGlkID0gMDsgaWQgPCBNV0lGSUVYX1VTRVJfU0NBTl9DSEFOX01BWDsgaWQrKykg
ew0KPiAgCQlpZiAoIXByaXYtPmhpZGRlbl9jaGFuW2lkXS5jaGFuX251bWJlcikNCj4gIAkJCWJy
ZWFrOw0KPiAtLQ0KPiAyLjcuNA0KDQo=
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] mwifiex: remove unnecessary call to memset
@ 2017-09-11 12:46 Himanshu Jha
0 siblings, 0 replies; 2+ messages in thread
From: Himanshu Jha @ 2017-09-11 12:46 UTC (permalink / raw)
To: amitkarwar
Cc: nishants, gbhat, huxm, kvalo, linux-wireless, netdev,
Himanshu Jha
call to memset to assign 0 value immediately after allocating
memory with kzalloc is unnecesaary as kzalloc allocates the memory
filled with 0 value.
Semantic patch used to resolve this issue:
@@
expression e,e2; constant c;
statement S;
@@
e = kzalloc(e2, c);
if(e == NULL) S
- memset(e, 0, e2);
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/net/wireless/marvell/mwifiex/scan.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c
index c9d41ed..8838b88 100644
--- a/drivers/net/wireless/marvell/mwifiex/scan.c
+++ b/drivers/net/wireless/marvell/mwifiex/scan.c
@@ -1936,8 +1936,6 @@ mwifiex_active_scan_req_for_passive_chan(struct mwifiex_private *priv)
if (!user_scan_cfg)
return -ENOMEM;
- memset(user_scan_cfg, 0, sizeof(*user_scan_cfg));
-
for (id = 0; id < MWIFIEX_USER_SCAN_CHAN_MAX; id++) {
if (!priv->hidden_chan[id].chan_number)
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-12 1:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-12 1:36 [PATCH] mwifiex: remove unnecessary call to memset Xinming Hu
-- strict thread matches above, loose matches on Subject: below --
2017-09-11 12:46 Himanshu Jha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox