From: Felix Fietkau <nbd@nbd.name>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net, quic_adisi@quicinc.com,
ath12k@lists.infradead.org
Subject: Re: [RFC v2 3/7] wifi: cfg80211: extend interface combination check for multi-radio
Date: Thu, 6 Jun 2024 09:55:38 +0200 [thread overview]
Message-ID: <23a6d1eb-3ce9-400c-aa3d-a7d29c953079@nbd.name> (raw)
In-Reply-To: <8add7134-9929-0288-0770-7778013cc37c@quicinc.com>
On 06.06.24 09:20, Karthikeyan Periyasamy wrote:
>
>
> On 6/6/2024 12:01 AM, Felix Fietkau wrote:
>>
>> /*
>> * This is a bit strange, since the iteration used to rely only on
>> @@ -2384,8 +2383,10 @@ int cfg80211_iter_combinations(struct wiphy *wiphy,
>> * cfg80211 already - the only thing not would appear to be any new
>> * interfaces (while being brought up) and channel/radar data.
>> */
>> - cfg80211_calculate_bi_data(wiphy, params->new_beacon_int,
>> - &beacon_int_gcd, &beacon_int_different);
>> + if (!radio)
>> + cfg80211_calculate_bi_data(wiphy, params->new_beacon_int,
>> + &beacon_int_gcd,
>> + &beacon_int_different);
>>
>
> Why its avoid for radio specific iface combination ?
Because it iterates over all wdevs within cfg80211. I didn't think this
was necessary, given that it already excludes MLO wdevs.
- Felix
next prev parent reply other threads:[~2024-06-06 7:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 18:31 [RFC v2 0/7] cfg80211/mac80211: support defining multiple radios per wiphy Felix Fietkau
2024-06-05 18:31 ` [RFC v2 1/7] wifi: nl80211: split helper function from nl80211_put_iface_combinations Felix Fietkau
2024-06-05 18:31 ` [RFC v2 2/7] wifi: cfg80211: add support for advertising multiple radios belonging to a wiphy Felix Fietkau
2024-06-05 18:31 ` [RFC v2 3/7] wifi: cfg80211: extend interface combination check for multi-radio Felix Fietkau
2024-06-06 7:20 ` Karthikeyan Periyasamy
2024-06-06 7:55 ` Felix Fietkau [this message]
2024-06-06 8:56 ` Karthikeyan Periyasamy
2024-06-06 8:58 ` Felix Fietkau
2024-06-06 9:52 ` Karthikeyan Periyasamy
2024-06-06 9:57 ` Felix Fietkau
2024-06-05 18:31 ` [RFC v2 4/7] wifi: mac80211: add radio index to ieee80211_chanctx_conf Felix Fietkau
2024-06-05 18:31 ` [RFC v2 5/7] wifi: mac80211: extend ifcomb check functions for multi-radio Felix Fietkau
2024-06-05 18:31 ` [RFC v2 6/7] wifi: mac80211: move code in ieee80211_link_reserve_chanctx to a helper Felix Fietkau
2024-06-05 18:31 ` [RFC v2 7/7] wifi: mac80211: add wiphy radio assignment and validation Felix Fietkau
2024-06-06 10:00 ` [RFC v2 0/7] cfg80211/mac80211: support defining multiple radios per wiphy Aditya Kumar Singh
2024-06-06 10:10 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23a6d1eb-3ce9-400c-aa3d-a7d29c953079@nbd.name \
--to=nbd@nbd.name \
--cc=ath12k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_adisi@quicinc.com \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox