Re: [PATCH 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead

[Luka Gejak <luka.gejak@linux.dev>]

Hi Leonard,

On November 15, 2026 3:23:28 PM GMT+01:00, Leonard Lausen
<leonard@lausen.nl> wrote:
>Reduce SDIO request overhead by filtering hardware-handled control
>frames and combining adjacent TX-capacity reads.
>
>RTL8822CS on NanoPi M5, median TCP Mbit/s:
>
>                              Upload   Download
>  Neither patch                170.4      241.2
>  Filtering only               258.2      263.3
>  Combined register reads only 186.5      261.6
>  Both patches                 286.9      273.5
>
>Together the patches improved median upload by 68% and download by 13.4%.
>Upload and download were measured in separate sessions, with four
>20-second upload samples and four 30-second download samples per
>configuration. Testing used a shared Wi-Fi network, so throughput can
>vary.
>
>Runtime baseline: v7.4-rc2 plus the RX-bounds fix accepted in rtw-next
>(83ca360e85280) and the MMC voltage-switch fixes in linux-next

Series targeted for rtw-next should be based on rtw-next, unless there is
a good reason for doing otherwise.

>(67a97316a31a3, a3838c21e28e5). All variants use stock MMC host limits,
>198 MHz SDR104, performance governors and identical CPU placement:
>SDIO IRQ on CPU4, iperf client on CPU6, server on CPU7. Traffic crosses
>Wi-Fi/AP/Ethernet between two endpoints on the board.
>
>All 20 configured rtw88 modules built with W=1. Sanitized function models
>cover credit-read errors, fallback and buffer ownership. Module IDs,
>filter registers, traffic paths and kernel logs were checked. AP/monitor,
>suspend/resume and other-chip hardware remain untested.
>
>AI assistance: Codex inspected sources, developed the changes and
>messages,
>and automated validation. Prompts requested small optimizations measured
>individually and together, with explicit prerequisite and impact checks.
>
>Leonard Lausen (2):
>  wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO
>  wifi: rtw88: sdio: combine free TX page register reads
>
> drivers/net/wireless/realtek/rtw88/reg.h      |  4 ++
> drivers/net/wireless/realtek/rtw88/rtw8822c.c |  9 +++
> drivers/net/wireless/realtek/rtw88/sdio.c     | 58 +++++++++++++++++--
> drivers/net/wireless/realtek/rtw88/sdio.h     |  1 +
> 4 files changed, 68 insertions(+), 4 deletions(-)
>
>base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb

Can you resend this properly, as v2, as resending singular patches is not
encouraged?

For the actual patches:

Read Documentation/process/coding-style.rst and
apply what you learn in there to all patches. Furthermore Assisted-by tag
is deprecated and should be removed, which you would have seen if you had
ran checkpatch on your patches. Address these and other style issues and I
will review v2, as I don't have time right now.

Best regards,
Luka Gejak