Re: [PATCH 3.8] mwifiex: fix typo in PCIe adapter NULL check

["Sergey V." <sftp.mtuci@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On 2013-01-21 at 21:04:10, Bing Zhao <bzhao@marvell.com> wrote:
> From: Avinash Patil <patila@marvell.com>
> 
> Add missing "!" as we are supposed to check "!card->adapter"
> in PCIe suspend handler.
> 
> Cc: "3.2+" <stable@vger.kernel.org>
> Signed-off-by: Avinash Patil <patila@marvell.com>
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
> ---
>  drivers/net/wireless/mwifiex/pcie.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/mwifiex/pcie.c
> b/drivers/net/wireless/mwifiex/pcie.c index 3da89b4..237949c 100644
> --- a/drivers/net/wireless/mwifiex/pcie.c
> +++ b/drivers/net/wireless/mwifiex/pcie.c
> @@ -164,7 +164,7 @@ static int mwifiex_pcie_suspend(struct pci_dev
> *pdev, pm_message_t state)
> 
>  	if (pdev) {
>  		card = (struct pcie_service_card *) 
pci_get_drvdata(pdev);
> -		if (!card || card->adapter) {
> +		if (!card || !card->adapter) {
>  			pr_err("Card or adapter structure is not 
valid\n");
>  			return 0;
>  		}

Looks correct for me.

Reviewed-by: Sergey V. <sftp.mtuci@gmail.com>

Thanks.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]