* [PATCH 3.8] mwifiex: fix typo in PCIe adapter NULL check
@ 2013-01-22 5:04 Bing Zhao
2013-01-22 10:06 ` Sergey V.
0 siblings, 1 reply; 2+ messages in thread
From: Bing Zhao @ 2013-01-22 5:04 UTC (permalink / raw)
To: linux-wireless
Cc: John W. Linville, Avinash Patil, Amitkumar Karwar, Yogesh Powar,
Nishant Sarmukadam, Frank Huang, Bing Zhao
From: Avinash Patil <patila@marvell.com>
Add missing "!" as we are supposed to check "!card->adapter"
in PCIe suspend handler.
Cc: "3.2+" <stable@vger.kernel.org>
Signed-off-by: Avinash Patil <patila@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
---
drivers/net/wireless/mwifiex/pcie.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c
index 3da89b4..237949c 100644
--- a/drivers/net/wireless/mwifiex/pcie.c
+++ b/drivers/net/wireless/mwifiex/pcie.c
@@ -164,7 +164,7 @@ static int mwifiex_pcie_suspend(struct pci_dev *pdev, pm_message_t state)
if (pdev) {
card = (struct pcie_service_card *) pci_get_drvdata(pdev);
- if (!card || card->adapter) {
+ if (!card || !card->adapter) {
pr_err("Card or adapter structure is not valid\n");
return 0;
}
--
1.7.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 3.8] mwifiex: fix typo in PCIe adapter NULL check
2013-01-22 5:04 [PATCH 3.8] mwifiex: fix typo in PCIe adapter NULL check Bing Zhao
@ 2013-01-22 10:06 ` Sergey V.
0 siblings, 0 replies; 2+ messages in thread
From: Sergey V. @ 2013-01-22 10:06 UTC (permalink / raw)
To: Bing Zhao
Cc: linux-wireless, John W. Linville, Avinash Patil, Amitkumar Karwar,
Yogesh Powar, Nishant Sarmukadam, Frank Huang
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On 2013-01-21 at 21:04:10, Bing Zhao <bzhao@marvell.com> wrote:
> From: Avinash Patil <patila@marvell.com>
>
> Add missing "!" as we are supposed to check "!card->adapter"
> in PCIe suspend handler.
>
> Cc: "3.2+" <stable@vger.kernel.org>
> Signed-off-by: Avinash Patil <patila@marvell.com>
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
> ---
> drivers/net/wireless/mwifiex/pcie.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/mwifiex/pcie.c
> b/drivers/net/wireless/mwifiex/pcie.c index 3da89b4..237949c 100644
> --- a/drivers/net/wireless/mwifiex/pcie.c
> +++ b/drivers/net/wireless/mwifiex/pcie.c
> @@ -164,7 +164,7 @@ static int mwifiex_pcie_suspend(struct pci_dev
> *pdev, pm_message_t state)
>
> if (pdev) {
> card = (struct pcie_service_card *)
pci_get_drvdata(pdev);
> - if (!card || card->adapter) {
> + if (!card || !card->adapter) {
> pr_err("Card or adapter structure is not
valid\n");
> return 0;
> }
Looks correct for me.
Reviewed-by: Sergey V. <sftp.mtuci@gmail.com>
Thanks.
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-22 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-22 5:04 [PATCH 3.8] mwifiex: fix typo in PCIe adapter NULL check Bing Zhao
2013-01-22 10:06 ` Sergey V.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox