Linux wireless drivers development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
	Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>,
	jjohnson@kernel.org, johannes@sipsolutions.net, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	jonas.gorski@gmail.com
Subject: Re: [PATCH v4 ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible
Date: Wed, 28 Jan 2026 09:01:58 +0100	[thread overview]
Message-ID: <32845805-5758-4c35-8818-ebccbfd9546a@kernel.org> (raw)
In-Reply-To: <74176aab-03d4-4095-890d-7ef1739b914b@oss.qualcomm.com>

On 27/01/2026 18:31, Jeff Johnson wrote:
> On 1/21/2026 1:50 AM, Miaoqing Pan wrote:
>> The 'firmware-name' property was introduced to allow end-users and
>> integrators to select use-case-specific firmware for the WCN6855.
>> But for M.2 WLAN chips, there is no suitable DTS node to specify
>> the 'firmware-name' property. In addition, assigning firmware for
>> the M.2 PCIe interface causes chips that do not use use-case-specific
>> firmware to fail. Therefore, abandoning the approach of specifying
>> firmware in DTS. As an alternative, propose a static lookup table
>> mapping device compatible to firmware names.
>>
>> ---
>> v2:
>> - Drops `firmware-name` from completely.
>> - Updates the commit message to clearly state that the property is
>>   obsolete and the change is ABI-breaking but safe for upstream.
>> v3:
>>  - Deprecate 'firmware-name' property instead of obsolete.
>>  - Keep the ABI backwards compatible.
>> v4:
>>  - Use of_machine_is_compatible() to simplify the code.
>>  - Add back Acked-by tag. 
>> ---
>>
>> Miaoqing Pan (2):
>>   wifi: ath11k: add usecase firmware handling based on device compatible
>>   dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name'
>>     property
>>
>>  .../net/wireless/qcom,ath11k-pci.yaml         |  1 +
>>  drivers/net/wireless/ath/ath11k/core.c        | 27 +++++++++++++++++++
>>  drivers/net/wireless/ath/ath11k/core.h        |  4 +++
>>  3 files changed, 32 insertions(+)
>>
>>
>> base-commit: d8e1f4a193101a72235416f189b01131a57e26e9
> 
> Krzysztof,
> Since you previously NAKed this series, can you confirm that your review
> comments have been addressed?


Binding looks fine, but I did not check the driver.

Best regards,
Krzysztof

  reply	other threads:[~2026-01-28  8:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21  9:50 [PATCH v4 ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible Miaoqing Pan
2026-01-21  9:50 ` [PATCH v4 ath-current 1/2] " Miaoqing Pan
2026-01-28 15:42   ` Vasanthakumar Thiagarajan
2026-01-29  2:10   ` Baochen Qiang
2026-01-21  9:50 ` [PATCH v4 ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property Miaoqing Pan
2026-01-28  8:00   ` Krzysztof Kozlowski
2026-01-27 17:31 ` [PATCH v4 ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible Jeff Johnson
2026-01-28  8:01   ` Krzysztof Kozlowski [this message]
2026-01-28  8:06     ` Miaoqing Pan
2026-01-28 15:30     ` Jeff Johnson
2026-01-30 15:15 ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32845805-5758-4c35-8818-ebccbfd9546a@kernel.org \
    --to=krzk@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=jjohnson@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=jonas.gorski@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miaoqing.pan@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox