From: Hans de Goede <hdegoede@redhat.com>
To: "Peer, Ilan" <ilan.peer@intel.com>,
Johannes Berg <johannes@sipsolutions.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Coelho, Luciano" <luciano.coelho@intel.com>
Subject: Re: pull-request: mac80211 2021-01-18.2
Date: Sun, 24 Jan 2021 11:54:39 +0100 [thread overview]
Message-ID: <348210d8-6940-ca8d-e3b1-f049330a2087@redhat.com> (raw)
In-Reply-To: <BN7PR11MB2610052E380E676ED5CCCC67E9BE9@BN7PR11MB2610.namprd11.prod.outlook.com>
Hi,
On 1/24/21 10:12 AM, Peer, Ilan wrote:
>> -----Original Message-----
>> From: Johannes Berg <johannes@sipsolutions.net>
>> Sent: Sunday, January 24, 2021 00:16
>> To: Hans de Goede <hdegoede@redhat.com>; netdev@vger.kernel.org
>> Cc: linux-wireless@vger.kernel.org; Peer, Ilan <ilan.peer@intel.com>;
>> Coelho, Luciano <luciano.coelho@intel.com>
>> Subject: Re: pull-request: mac80211 2021-01-18.2
>>
>> On Sat, 2021-01-23 at 22:31 +0100, Hans de Goede wrote:
>>>
>>> So I'm afraid that I have some bad news about this patch, it fixes the
>>> RCU warning which I reported:
>>>
>>> https://lore.kernel.org/linux-wireless/20210104170713.66956-1-hdegoede
>>> @redhat.com/
>>>
>>> But it introduces a deadlock. See:
>>>
>>> https://lore.kernel.org/linux-wireless/d839ab62-e4bc-56f0-d861-f172bf1
>>> 9c4b3@redhat.com/
>>>
>>> for details. Note we really should fix this new deadlock before 5.11
>>> is released. This is worse then the RCU warning which this patch fixes.
>>
>> Ouch. Thanks for the heads-up. I guess I'll revert both patches for now,
>> unless we can quickly figure out a way to get all these paths in order.
>>
>
> Thanks Hans and Johannes for handling this. I'll try to come up with a solution.
Great, thank you for looking into this. Let me know if you have a patch
which you want me to test on a RTL8723BS adapter.
One thing which I forgot to mention earlier, it is not just lockdep complaining
this appears to be a real deadlock, the wifi no longer functions, where
as it does function with the patch drops.
Regards,
Hans
next prev parent reply other threads:[~2021-01-24 10:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 20:47 pull-request: mac80211 2021-01-18.2 Johannes Berg
2021-01-18 22:50 ` patchwork-bot+netdevbpf
2021-01-20 17:59 ` Johannes Berg
2021-01-20 20:37 ` Jakub Kicinski
2021-01-20 20:39 ` Johannes Berg
2021-01-23 21:31 ` Hans de Goede
2021-01-23 22:15 ` Johannes Berg
2021-01-24 9:12 ` Peer, Ilan
2021-01-24 10:54 ` Hans de Goede [this message]
2021-01-24 13:03 ` Peer, Ilan
2021-01-25 9:47 ` Johannes Berg
2021-01-25 11:18 ` Hans de Goede
2021-01-25 12:40 ` Johannes Berg
2021-01-25 12:59 ` Hans de Goede
2021-01-25 13:03 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348210d8-6940-ca8d-e3b1-f049330a2087@redhat.com \
--to=hdegoede@redhat.com \
--cc=ilan.peer@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox