From: Ryder Lee <Ryder.Lee@mediatek.com>
To: "johannes@sipsolutions.net" <johannes@sipsolutions.net>
Cc: "Shayne Chen (陳軒丞)" <Shayne.Chen@mediatek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Evelyn Tsai (蔡珊鈺)" <Evelyn.Tsai@mediatek.com>
Subject: Re: [PATCH 1/2] wifi: mac80211: introduce ieee80211_refresh_tx_agg_session_timer()
Date: Tue, 21 Feb 2023 19:04:48 +0000 [thread overview]
Message-ID: <3519e733bb3ba72b307a9fe6f92086f9fbd6fb63.camel@mediatek.com> (raw)
In-Reply-To: <a3f50c4b4e75ff53a5611c3ef2d6345d4324cedb.camel@sipsolutions.net>
On Tue, 2023-02-21 at 10:57 +0100, Johannes Berg wrote:
> Hi,
>
> > > > Since there's no any keep alive packet being received by host
> > > > stack, leads to mac80211 destrory BA sesion.
> > > >
> > >
> > > More specifically, the BA session relies on client side's Tx data
> > > to
> >
> > Typo... I mean *our side*. Something like this
>
> Sorry. I'm just totally confused - I thought the initiator only set
> the
> timeout, but I see now that it's negotiated and the actual value used
> is
> from the client.
>
> Which explains basically everything.
>
>
Yup ... after accepting the AddBA Response we activated a timer,
*resetting it after each frame that we send* -
sta_tx_agg_session_timer_expired().
The .net_fill_forward_path() offloads tx path to HW, so it can only
rely on other way to reset as mac80211 isn't aware of that.
Ryder
prev parent reply other threads:[~2023-02-21 19:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 17:50 [PATCH 1/2] wifi: mac80211: introduce ieee80211_refresh_tx_agg_session_timer() Ryder Lee
2023-02-17 17:50 ` [PATCH 2/2] wifi: mt76: connac: refresh tx session timer for WED device Ryder Lee
2023-02-17 18:01 ` [PATCH 1/2] wifi: mac80211: introduce ieee80211_refresh_tx_agg_session_timer() Johannes Berg
2023-02-17 18:43 ` Ryder Lee
2023-02-17 18:53 ` Johannes Berg
2023-02-17 19:02 ` Ryder Lee
2023-02-20 2:55 ` Ryder Lee
2023-02-20 3:35 ` Ryder Lee
2023-02-21 9:57 ` Johannes Berg
2023-02-21 19:04 ` Ryder Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3519e733bb3ba72b307a9fe6f92086f9fbd6fb63.camel@mediatek.com \
--to=ryder.lee@mediatek.com \
--cc=Evelyn.Tsai@mediatek.com \
--cc=Shayne.Chen@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox