From: Johannes Berg <johannes@sipsolutions.net>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Shayne Chen <shayne.chen@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] wifi: mac80211: introduce ieee80211_refresh_tx_agg_session_timer()
Date: Fri, 17 Feb 2023 19:01:10 +0100 [thread overview]
Message-ID: <44f956b493e33bf394b2947b77e7c86f394b28ed.camel@sipsolutions.net> (raw)
In-Reply-To: <7c3f72eac1c34921cd84a462e60d71e125862152.1676616450.git.ryder.lee@mediatek.com>
On Sat, 2023-02-18 at 01:50 +0800, Ryder Lee wrote:
> This allows low level drivers to refresh the tx agg session timer, based on
> querying stats from the firmware usually. Especially for some mt76 devices
> support .net_fill_forward_path would bypass mac80211, which leads to tx BA
> session timeout for certain clients.
>
Does it even matter? We could just request sessions without a timeout in
the first place.
Or do you have a strong reason to need the timeout, such as limited
hardware resources for (TX) aggregation sessions?
But then maybe you should just time them out based on FW statistics
directly, rather than having to periodically refresh the timer in
mac80211?
I don't mind the patch, and I'll happily take it if it's needed, I'm
just wondering if that isn't a very roundabout way of achieving things.
johannes
next prev parent reply other threads:[~2023-02-17 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 17:50 [PATCH 1/2] wifi: mac80211: introduce ieee80211_refresh_tx_agg_session_timer() Ryder Lee
2023-02-17 17:50 ` [PATCH 2/2] wifi: mt76: connac: refresh tx session timer for WED device Ryder Lee
2023-02-17 18:01 ` Johannes Berg [this message]
2023-02-17 18:43 ` [PATCH 1/2] wifi: mac80211: introduce ieee80211_refresh_tx_agg_session_timer() Ryder Lee
2023-02-17 18:53 ` Johannes Berg
2023-02-17 19:02 ` Ryder Lee
2023-02-20 2:55 ` Ryder Lee
2023-02-20 3:35 ` Ryder Lee
2023-02-21 9:57 ` Johannes Berg
2023-02-21 19:04 ` Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44f956b493e33bf394b2947b77e7c86f394b28ed.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox