Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: "Gabriel Vinícius da Maia"
	<gabriel_v_maia@estudante.sesisenai.org.br>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtw88: add quirk to disable deep LPS for ASUS VivoBook X515JA
Date: Mon, 11 May 2026 01:16:56 +0000	[thread overview]
Message-ID: <3abf064f601c4836a4893d503c3ac7c4@realtek.com> (raw)
In-Reply-To: <CAC1kGwHi0AyV+kxjbRQE4TKvAc-3xq+uHUufCjfAnkfF8j=Y4g@mail.gmail.com>

Gabriel Vinícius da Maia <mailto:gabriel_v_maia@estudante.sesisenai.org.br> wrote:
> I was unable to test the patch in runtime. Building the module against
> my running kernel (6.19) failed due to version mismatch with the tree
> (7.1-rc2), specifically the kmalloc_obj() symbol introduced in the
> newer version.

Did you mean the patch on 6.19 works fine to you?

> 
> I then compiled the full kernel from the tree, but the resulting
> build lacked several modules required by Fedora 43 to boot properly,
> causing the system to hang during initialization.
> 
> However, the patch follows the same logic as commit b2bf9d61e14a,
> which disables deep LPS for an HP laptop with the same RTL8821CE
> chip and identical error messages. The dmesg output from my system
> shows the same pattern:
> 
>   rtw88_8821ce 0000:01:00.0: firmware failed to leave lps state
>   rtw88_8821ce 0000:01:00.0: failed to send h2c command

Maybe you can try to turn off entirely power save by
  iw wlan0 set power save off

But I wonder if these messages can affect your daily use?

> 
> I also investigated whether enabling FW_FEATURE_LPS_C2H would be a
> more general fix, but inspection of rtw8821c_fw.bin (version 24.11.0)
> shows the bit is not set and FW_FEATURE_SIG is also absent, causing
> the driver to discard the feature report entirely.

If FW_FEATURE_LPS_C2H is not set, it goes into 
__rtw_fw_leave_lps_check_reg(). Maybe you can try to enlarge the timeout
time or retry count. 



      parent reply	other threads:[~2026-05-11  1:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 16:49 [PATCH] wifi: rtw88: add quirk to disable deep LPS for ASUS VivoBook X515JA Gabriel Maia
2026-05-06  8:48 ` Ping-Ke Shih
     [not found]   ` <CAC1kGwEid2rT3KFV_Aqxd-Tz7uS+Yci2PNbaPWJ=R0x4zaVYug@mail.gmail.com>
     [not found]     ` <CAC1kGwHi0AyV+kxjbRQE4TKvAc-3xq+uHUufCjfAnkfF8j=Y4g@mail.gmail.com>
2026-05-11  1:16       ` Ping-Ke Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3abf064f601c4836a4893d503c3ac7c4@realtek.com \
    --to=pkshih@realtek.com \
    --cc=gabriel_v_maia@estudante.sesisenai.org.br \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox