RE: [PATCH] wifi: rtw88: add quirk to disable deep LPS for ASUS VivoBook X515JA

[Ping-Ke Shih <pkshih@realtek.com>]

Gabriel Maia <gabrielvinicius.damaia@gmail.com> wrote:
> On ASUS VivoBook X515JA laptops equipped with a Realtek RTL8821CE
> 802.11ac PCIe adapter (PCI ID: 10ec:c821, subsystem: 1a3b:3040),
> the driver periodically emits the following messages:
> 
>   rtw88_8821ce 0000:01:00.0: firmware failed to leave lps state
>   rtw88_8821ce 0000:01:00.0: failed to send h2c command
> 
> The firmware fails to leave the Low Power State (LPS) in time,
> causing subsequent h2c commands to be dropped. Disable deep LPS
> to avoid this issue.

Just want to know that messages become absolutely silent with this patch?

> 
> Signed-off-by: Gabriel Maia <gabriel_v_maia@estudante.sesisenai.org.br>

WARNING: From:/Signed-off-by: email address mismatch: 
'From: Gabriel Maia <gabrielvinicius.damaia@gmail.com>' != 
'Signed-off-by: Gabriel Maia <gabriel_v_maia@estudante.sesisenai.org.br>'

> ---
>  drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
> index bba370ad510c..b0eae0971ef4 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -1770,6 +1770,15 @@ static const struct dmi_system_id rtw_pci_quirks[] = {
>                 .driver_data = (void *)(BIT(QUIRK_DIS_CAP_PCI_ASPM) |
>                                         BIT(QUIRK_DIS_CAP_LPS_DEEP)),
>         },
> +       {
> +               .callback = rtw_pci_disable_caps,
> +               .ident = "ASUS VivoBook X515JA",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "VivoBook_ASUSLaptop X515JA_X515JA"),
> +               },
> +               .driver_data = (void *)BIT(QUIRK_DIS_CAP_LPS_DEEP),
> +       },
>         {}
>  };
> 
> --
> 2.53.0