From: Pardeep Kaur <pardeep.kaur@oss.qualcomm.com>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH ath-next v2 7/8] wifi: ath12k: fix 1-based ring index in REO Rx Received debugfs output
Date: Mon, 10 Aug 2026 10:25:56 +0530 [thread overview]
Message-ID: <41001b17-36b8-4c5c-9a8a-959ecf7b28ce@oss.qualcomm.com> (raw)
In-Reply-To: <746f106d-f435-47ca-a33b-32e4b97843f7@oss.qualcomm.com>
On 08-08-2026 20:56, Jeff Johnson wrote:
> On 8/6/2026 6:24 AM, Pardeep Kaur wrote:
>> From: Pardeep Kaur <pardeep.kaur@oss.qualcomm.com>
>>
>> The REO Rx Received section in device_dp_stats debugfs uses a 1-based
>> ring index ("Ring1:", "Ring2:", ...) which is inconsistent with the rest
>> of ath12k where rings are indexed from 0. Fix it to use 0-based indexing
>> and lowercase "ring%d:" to match the style used by all other ring counters
>> in the same function.
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6.r1-00402-QCAHKSWPL_SILICONZ-1
>>
>> Fixes: 84873d542e95 ("wifi: ath12k: print device dp stats in debugfs")
> drop the Fixes tag -- this is not something that needs backporting
will update this
>
>> Signed-off-by: Pardeep Kaur <pardeep.kaur@oss.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath12k/debugfs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/debugfs.c b/drivers/net/wireless/ath/ath12k/debugfs.c
>> index 216a1af22898..d4ea21aac21e 100644
>> --- a/drivers/net/wireless/ath/ath12k/debugfs.c
>> +++ b/drivers/net/wireless/ath/ath12k/debugfs.c
>> @@ -1215,7 +1215,7 @@ static ssize_t ath12k_debugfs_dump_device_dp_stats(struct file *file,
>> len += scnprintf(buf + len, size - len, "\nREO Rx Received:\n");
>>
>> for (i = 0; i < DP_REO_DST_RING_MAX; i++) {
>> - len += scnprintf(buf + len, size - len, "Ring%d:", i + 1);
>> + len += scnprintf(buf + len, size - len, "ring%d:", i);
>>
>> for (j = 0; j < ab->ag->num_devices; j++) {
>> len += scnprintf(buf + len, size - len,
next prev parent reply other threads:[~2026-08-10 4:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 13:24 [PATCH ath-next v2 0/8] wifi: ath12k: extend device DP stats for TX and RX observability Pardeep Kaur
2026-08-06 13:24 ` [PATCH ath-next v2 1/8] wifi: ath12k: fix out-of-bounds access on TX stats arrays Pardeep Kaur
2026-08-07 2:07 ` Jeff Johnson
2026-08-10 4:54 ` Pardeep Kaur
2026-08-06 13:24 ` [PATCH ath-next v2 2/8] wifi: ath12k: rename wbm_status to htt_status in HTT TX completion Pardeep Kaur
2026-08-06 13:24 ` [PATCH ath-next v2 3/8] wifi: ath12k: add TCL ring TX buffer allocation failure counter Pardeep Kaur
2026-08-06 13:24 ` [PATCH ath-next v2 4/8] wifi: ath12k: add device DP stats reset support via debugfs Pardeep Kaur
2026-08-07 2:14 ` Jeff Johnson
2026-08-10 4:55 ` Pardeep Kaur
2026-08-06 13:24 ` [PATCH ath-next v2 5/8] wifi: ath12k: add WBM RX error drop statistics Pardeep Kaur
2026-08-06 13:24 ` [PATCH ath-next v2 6/8] wifi: ath12k: track per-ring RX sent-to-stack count Pardeep Kaur
2026-08-06 13:24 ` [PATCH ath-next v2 7/8] wifi: ath12k: fix 1-based ring index in REO Rx Received debugfs output Pardeep Kaur
2026-08-08 15:26 ` Jeff Johnson
2026-08-10 4:55 ` Pardeep Kaur [this message]
2026-08-06 13:24 ` [PATCH ath-next v2 8/8] wifi: ath12k: add WBM SW desc fallback counter Pardeep Kaur
2026-08-06 14:40 ` [PATCH ath-next v2 0/8] wifi: ath12k: extend device DP stats for TX and RX observability Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41001b17-36b8-4c5c-9a8a-959ecf7b28ce@oss.qualcomm.com \
--to=pardeep.kaur@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox